Add end-to-end tests for app info - #8708
Closed
byrichardpowell wants to merge 1 commit into
Closed
byrichardpowell wants to merge 1 commit into
byrichardpowell wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new Vitest project runs in Windows CI, but its harness depends on Bash paths removed from the child environment.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds an end-to-end harness and comprehensive fixture catalog for exercising app info through the bundled CLI.
Changes:
- Adds app-info scenarios covering authentication, networking, configuration, extensions, and failures.
- Introduces isolated filesystem, process, state, and network test utilities.
- Registers the suite with Vitest and excludes synthetic fixtures from tooling.
| File | Description |
|---|---|
test/app-info.test.ts |
Defines app-info end-to-end scenarios. |
test/vite.config.ts |
Configures the command-test project. |
test/tsconfig.json |
Configures test TypeScript compilation. |
test/support/*.ts |
Implements the isolated command harness. |
test/fixtures/.gitignore |
Retains normally ignored fixture inputs. |
test/fixtures/app-information/** |
Provides synthetic projects and edge-case inputs. |
vite.config.ts |
Registers the new test project. |
tsconfig.json |
Includes the root Vitest configuration. |
eslint.config.js |
Excludes intentionally invalid fixtures. |
.prettierignore |
Preserves exact fixture contents. |
.nxignore |
Prevents fixtures from being treated as projects. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
byrichardpowell
force-pushed
the
rp/app-info-command-tests
branch
3 times, most recently
from
September 30, 2026 15:07
4e768cd to
6cba6fc
Compare
byrichardpowell
force-pushed
the
rp/app-info-command-tests
branch
from
September 30, 2026 15:14
6cba6fc to
81d9061
Compare
Contributor
|
I was going to review this, but it's a 7700 lines PR 😬 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
app infocrosses CLI startup, configuration discovery, authentication, network, persistent storage, extension loading, and lifecycle hooks. Existing unit tests do not prove how those pieces behave together through the shipped CLI entrypoint.WHAT is this pull request doing?
Adds an isolated command-level Vitest harness and 261
app infocases. Each case launchespackages/cli/bin/run.jsthrough bash, uses real temporary files and stores, and blocks unregistered network and subprocess activity.The suite covers result modes, configuration selection, linking, authentication, retries, caches, historical configuration inputs, extension type generation, localization, lifecycle behavior, and failure side effects.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add