Skip to content

Complete the beginner Wizard preparation and casting journey - #7

Merged
HarryCordewener merged 1 commit into
mainfrom
codex/pf2e-wizard-learning
Oct 18, 2026
Merged

HarryCordewener merged 1 commit into
mainfrom
codex/pf2e-wizard-learning

Conversation

@HarryCordewener

@HarryCordewener HarryCordewener commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

A beginner Wizard can now follow a named level-1 spellbook and preparation ledger through five practice turns, Refocus and daily reset. Three linked guides explain ordinary versus curriculum preparations, reusable cantrips, ranked slots, focus, Arcane Bond and basic saves. The existing school and casting pages lead directly to those procedures; all seven included Player Core schools are linked.

The example states its casting-statistic assumptions and links the full higher-level Wizard progression as an external primary dependency. It does not certify a complete character build. The nearby Thunderstrike circumstance modifier is corrected from bonus to penalty. Existing canonical identities and typed source headers are preserved.

Closes #6 for its bounded beginner Wizard preparation/casting scope. Complete character validation, final engine navigation and server-work budgets remain separate.

Validation:

  • Independent primary-rule review checked every selected spell, school grant, damage calculation and resource transition; final integration review passed.
  • Strict PackageValidator: all eight packages pass; navigation checker: 4,723 pages, 22,604 wiki links, nine journey groups and required direct instruction edges pass.
  • Actual Markdig rendering and Pf2eExtractor.ReadFields: all baseline 4,720 and revised 4,723 pages processed; no existing extracted fields changed, and new procedures introduce no inferred typed facts.
  • Eighteen isolated article browser checks at 1,440/320 widths fit, including guide tables; three guide destination clicks pass. These are not full-portal acceptance.
  • Actual privately published Production portal/native world installed this exact commit through authenticated package plan/apply; persisted installedCommit matches PR head, revision 2. Anonymous authorized wiki reads followed the guide/preparation/basic-save/school/casting links and browser Back. Six actual portal article checks at 1,440/320 widths fit with zero browser errors. Mobile tables are contained in 254px scrolling wrappers; keyboard ArrowRight scrolls the wide ledger from 0 to 200px. Desktop/mobile captures were visually inspected. This verifies the Wizard route, not complete engine navigation or performance.
  • Original pinned 4,714-file extraction fixture and content lock remain unchanged.

Candidate 1.2.0 remains unpublished. No tag, release, deployment or semantic activation is included.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: 1a75e943-f08c-4d01-b42a-204575e54005
📥 Commits

Reviewing files that changed from the base of the PR and between 99e0bfe and 3a6518d.

📒 Files selected for processing: 14
  • pf2e-remaster/README.md
  • pf2e-remaster/package.yaml
  • pf2e-remaster/wiki/category/character_creation.md
  • pf2e-remaster/wiki/category/rules.md
  • pf2e-remaster/wiki/category/spells.md
  • pf2e-remaster/wiki/main/arcane_school.md
  • pf2e-remaster/wiki/main/basic_saving_throws.md
  • pf2e-remaster/wiki/main/cast_a_spell.md
  • pf2e-remaster/wiki/main/learn_pf2e.md
  • pf2e-remaster/wiki/main/spell_preparation.md
  • pf2e-remaster/wiki/main/thunderstrike.md
  • pf2e-remaster/wiki/main/wizard_learning_guide.md
  • pf2e-remaster/wiki/main/wizard_spellcasting.md
  • tools/check-pf2e-navigation.py

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Walkthrough

Adds a level-1 Wizard learning route with spell preparation, casting, and saving-throw guidance. It also updates package navigation checks and changes Thunderstrike’s metal-target Reflex modifier.

Changes

Wizard learning and spellcasting route

Layer / File(s) Summary
Wizard school and preparation rules
pf2e-remaster/wiki/main/arcane_school.md, pf2e-remaster/wiki/main/spell_preparation.md, pf2e-remaster/wiki/main/wizard_spellcasting.md, pf2e-remaster/README.md
Adds school and curriculum guidance, explains daily spell preparation, and clarifies the scope of the Wizard progression table.
Level-1 Wizard ledger example
pf2e-remaster/wiki/main/wizard_learning_guide.md
States the example’s assumptions and tracks spellbook grants and daily preparations.
Casting, resource, and save procedures
pf2e-remaster/wiki/main/cast_a_spell.md, pf2e-remaster/wiki/main/basic_saving_throws.md, pf2e-remaster/wiki/main/spell_preparation.md, pf2e-remaster/wiki/main/wizard_learning_guide.md
Explains casting traits and basic saves, and records how spells, focus points, and preparations change in the worked example.
Learning route and navigation wiring
pf2e-remaster/package.yaml, pf2e-remaster/wiki/category/*.md, pf2e-remaster/wiki/main/learn_pf2e.md, tools/check-pf2e-navigation.py, pf2e-remaster/README.md
Adds the guide pages to the package and learning links, and checks the required route and direct links.

Thunderstrike save modifier

Layer / File(s) Summary
Metal-target Reflex modifier
pf2e-remaster/wiki/main/thunderstrike.md
Changes the metal-target Reflex modifier from a –1 circumstance bonus to a –1 circumstance penalty.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Suggested reviewers: claude

Merge Risk: ⚪ Minimal · up to 3a651

The PR adds a scoped Wizard learning route and changes the Thunderstrike modifier. No concrete user-facing failure is established; the rule and rendering details that could affect those changes remain unconfirmed.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (13 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: completing a beginner Wizard preparation and casting journey with linked level-1 guidance.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (13 skipped: 13 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@HarryCordewener
HarryCordewener merged commit 2af969d into main Oct 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complete the beginner Wizard preparation and spellcasting journey

1 participant