Repository navigation
Give Pathfinder 2e an authored entrance and explicit lesson progression - #12
Conversation
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 50 minutes for your next included review. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe package version changes to 1.3.1. The wiki adds a pinned PF2e learning entry and navigation between instructional pages. A checker validates the entry and required next-step links. ChangesPF2e learning path
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~12 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (13 skipped: 1… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly summarizes the main changes: a pinned Pathfinder 2e entrance and explicit lesson progression through the learning content. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (13 skipped: 13 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
88a8162 to
ab497b6
Compare
A new reader currently has to find the learning guide among reference topics. Add a pinned Start here — Learn PF2e introduction and named next-action/return blocks through the eight core lessons, retaining both Fighter and Wizard branches and the separate practice resets/day boundaries.
Bump the package and listing to 1.3.1. These are authored links and a safe generic Markdown container; the engine does not choose lesson order. Existing rules, arithmetic and source links are unchanged. Tracked by SharpMUSH/SharpMUSH#2044; broader player/architecture acceptance remains open.
Validation: the actual SharpMUSH PackageValidator passes in strict mode for all eight repository packages and index entries, including 4,725 PF2e pages. The source checker passes 22,706 links and nine journey groups and now requires the pinned entrance binding and each named progression/return link. Independent content review passed. The real installer applied the final source commit on a disposable copied world with a pre-package backup and no conflicts. Actual anonymous navigation reports eight starting-group members. The published portal completed 22 keyboard-driven lesson visits at 1440x1000/320x1000, with preserved return context and fully wrapped long related labels. Novice comprehension and full shorter-phone entry prominence remain open; SharpMUSH/SharpMUSH#2064 tracks the measured 320x800 entry gap. SharpMUSH/SharpMUSH#2065 tracks the observed large-update execution-budget warning. These are acceptance limits, not completed gates. No release tag, production package apply or deployment.