Repository navigation
Trim table headings used as card labels (2.22.1) - #70
Merged
Merged
Conversation
A heading padded to line its column up ("Idle ") read "Idle : 59s" to a
screen reader and in narrow card layouts.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015YDiaApsFRN4PnfRwGRp7i
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
Tableread as cards (linear for a screen reader, or too narrow for its columns) used each heading as the field label as it was. SharpMUSH's WHO pads itsIdleheading so the column lines up, and a screen reader heardIdle : 59s.Table.DrawCardsnow trims the spaces around a heading before it becomes a label. The table's own heading row is unchanged.Tests
FieldsAndTreeTests.Table_Linear_LabelsEachCellWithoutTheHeadingsPadding: fails before the change (Idle : 59s), passes after.SharpMUSH picks this up by bumping
MarkupStringVersiononce 2.22.1 is tagged.Generated by Claude Code
Summary by CodeRabbit
Idle: 59sinstead ofIdle : 59s, making label-value pairs cleaner in linear or narrow table layouts.