Added Knows Benchmark - #336
Open
farhanishmam wants to merge 2 commits into
Open
farhanishmam wants to merge 2 commits into
farhanishmam wants to merge 2 commits into
Conversation
…s, Slides) Knows evaluates browser agents on long-horizon document authoring in Google Workspace. An agent drives a real browser to build a Doc, Sheet, or Slide deck from a natural-language goal, and the result is graded checkpoint-by-checkpoint via the Workspace APIs, yielding a fractional reward rather than binary success. 110 tasks across 22 families and 3 Workspace apps (25 docs / 45 sheets / 40 slides), exposed as a single `knows` split. This is the AgentLab-side counterpart to the BrowserGym change that adds the `knows` action subset, benchmark config, and task metadata. As with TimeWarp, the benchmark itself lives in an external package (`browsergym-knows`), so AgentLab needs only the lazy import and a docs entry: - lazy `import browsergym.knows` in `_get_env_name`, so worker processes register the gym envs before `gym.make` (joblib/ray workers get a fresh `sys.modules`, so the parent's `prepare_backends()` import does not carry over) - a `Knows` row in the supported-benchmarks table No dependency change, matching the TimeWarp precedent: AgentLab declares no per-benchmark extras, and benchmark packages are installed out of band per the setup link. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical setup and reproducibility issues remain unresolved.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Adds AgentLab integration and documentation for the BrowserGym KNOWS benchmark.
Changes:
- Lazily registers
browsergym.knowsenvironments. - Adds KNOWS to the supported benchmark table.
| File | Summary | Findings |
|---|---|---|
src/agentlab/experiments/loop.py |
Registers KNOWS environments. | Critical (4 votes): Strict reproducibility treats knows as unknown because no benchmark version case exists. |
README.md |
Documents KNOWS benchmark setup and support. | Critical (2 votes): Setup is not installable or runnable from a clean AgentLab installation. Nit (1 vote): The setup URL currently resolves to 404. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| | [MiniWoB](https://miniwob.farama.org/index.html) | [setup](https://github.com/ServiceNow/BrowserGym/blob/main/browsergym/miniwob/README.md) | 125 | Medium | 10 | no | self hosted (static files) | soon | | ||
| | [OSWorld](https://os-world.github.io/) | [setup](https://github.com/ServiceNow/AgentLab/blob/main/src/agentlab/benchmarks/osworld.md) | 369 | None | - | - | self hosted | soon | | ||
| | [TimeWarp](https://timewarp-web.github.io/) | [setup](https://github.com/sparklabutah/timewarp) | 1386 | None | 30 | yes | self hosted | soon | | ||
| | [Knows](https://alexgill321.github.io/KNOWS-benchmark/) | [setup](https://github.com/alexgill321/Agent-Benchmark) | 110 | None | 120 | yes | live web | soon | |
Comment on lines
+931
to
+932
| elif task_name.startswith("knows"): | ||
| import browsergym.knows |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the KNOWS benchmark corresponding to the BrowserGym Knows PR #397