Repository navigation
Format refresh and freq with the invariant culture - #101
Merged
Merged
Conversation
The DAT writers and the filter formatted Refresh and Freq with the current culture, so a German or French system wrote "123,450000". SabreTools.IO parses these values with the invariant culture. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mnadareski
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to SabreTools/SabreTools.IO#5. The DAT writers format
RefreshandFreqwithToString("0.000000")in the current culture, so a German or French system writesrefresh="123,450000". Since IO#5,ConvertToDoubleparses that with the invariant culture and gets 123450000.FilterObjectalso formatsRefreshwith the current culture before it parses it, so arefresh/freqfilter does not match on such a system.This formats both with the invariant culture. The new tests set en-US, de-DE and fr-FR themselves and fail without the change on any system culture.
Measured on a de-DE system (net10.0):
19d73bd, with IO#5): without the change 10 round-trip tests (ClrMamePro, Listxml, M1, Mess) and 4 filter tests fail; with it all pass.I also ran the whole suite once per formatting group of the 606 specific cultures .NET knows (190 groups). With this change and IO main all pass, except
TypeLengthValueTests.Format_ValidUTCTimein 9 groups that use.as the time separator (fails the same without this change).Prepared with AI assistance (Claude Opus 5.5) and reviewed before submission.