Skip to content

Feat(#144): make form fields required - #211

Open
anneke wants to merge 1 commit into
mainfrom
feat/144-make-form-fields-required
Open

anneke wants to merge 1 commit into
mainfrom
feat/144-make-form-fields-required

Conversation

@anneke

@anneke anneke commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • make form fields required, and optional only by exception
  • adds choice-card variant to radiogroup story
  • updates variable used for the border in choice-card surrounding the field

Related issue

#144

Type of change

  • Fix
  • New feature / variant
  • Breaking change
  • Docs / repo tooling (no package code changed)
  • Chore / refactor

Checklist

  • pnpm build, pnpm lint, and pnpm format pass
  • Storybook story added/updated to cover the change (variants, sizes, states)
  • Visual snapshots updated (pnpm test:visual:update after pnpm build-storybook) if appearance changed
  • Changeset added (pnpm changeset) — required for any change to @surfnet/curve-react or @surfnet/curve-angular; N/A for docs/CI-only changes
  • React and Angular kept in parity, if applicable (contract updated in @surfnet/curve-contracts)

Screenshots

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

♿ Accessibility audit — WCAG 2.2 AA

✅ No violations across 370 stories / 11840 theme·mode combinations in @surfnet/curve-angular, @surfnet/curve-react.

Automated axe covers ~30–50% of WCAG 2.2 AA. Keyboard, screen-reader and reflow checks still need a manual pass. Full per-story JSON is in the run’s a11y-reports artifact.

@anneke
anneke force-pushed the feat/144-make-form-fields-required branch 5 times, most recently from 15193f8 to db29bc7 Compare October 12, 2026 08:26
Signed-off-by: Anneke Sinnema <mail@annekesinnema.nl>
@anneke
anneke force-pushed the feat/144-make-form-fields-required branch from db29bc7 to ba04d46 Compare October 12, 2026 08:49
@anneke

anneke commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

Ik wil deze graag mergen na overleg met het designteam op dinsdag 13 oktober

@anneke anneke linked an issue Oct 12, 2026 that may be closed by this pull request

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set approach for optional vs. required form fields

1 participant