Skip to content

feat(#184): change radio-button color variable, fix parity - #209

Merged
anneke merged 5 commits into
mainfrom
feat/184-radio-button-dot-color
Oct 7, 2026
Merged

anneke merged 5 commits into
mainfrom
feat/184-radio-button-dot-color

Conversation

@anneke

@anneke anneke commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • change the "dot" color (the marker) in the input element to fix contrast in Surf Green theme
  • make sure Angular component and React component look the same in different themes

Related issue

Closes #184

Type of change

  • Fix
  • New feature / variant
  • Breaking change
  • Docs / repo tooling (no package code changed)
  • Chore / refactor

Checklist

  • pnpm build, pnpm lint, and pnpm format pass
  • Storybook story added/updated to cover the change (variants, sizes, states)
  • Visual snapshots updated (pnpm test:visual:update after pnpm build-storybook) if appearance changed
  • Changeset added (pnpm changeset) — required for any change to @surfnet/curve-react or @surfnet/curve-angular; N/A for docs/CI-only changes
  • React and Angular kept in parity, if applicable (contract updated in @surfnet/curve-contracts)

Screenshots

Scherm­afbeelding 2026-10-06 om 13 47 03

The line around the input given to us by --input does not have high enough contrast with a white background, this needs to be a darker color, see https://www.w3.org/WAI/WCAG21/Understanding/non-text-contrast.html.

@anneke
anneke marked this pull request as draft October 6, 2026 11:49
@anneke

anneke commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

To do before merge:

  • update input border color if possible
  • make changeset (patch)
  • update visual baseline

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

♿ Accessibility audit — WCAG 2.2 AA

✅ No violations across 362 stories / 10136 theme·mode combinations in @surfnet/curve-angular, @surfnet/curve-react.

Automated axe covers ~30–50% of WCAG 2.2 AA. Keyboard, screen-reader and reflow checks still need a manual pass. Full per-story JSON is in the run’s a11y-reports artifact.

github-actions Bot added a commit that referenced this pull request Oct 7, 2026
anneke added 4 commits October 7, 2026 12:45
Signed-off-by: Anneke Sinnema <mail@annekesinnema.nl>
Signed-off-by: Anneke Sinnema <mail@annekesinnema.nl>
Signed-off-by: Anneke Sinnema <mail@annekesinnema.nl>
Signed-off-by: Anneke Sinnema <mail@annekesinnema.nl>
@anneke
anneke force-pushed the feat/184-radio-button-dot-color branch from 4c158c7 to 02b63c4 Compare October 7, 2026 10:46
Signed-off-by: Anneke Sinnema <mail@annekesinnema.nl>
@anneke anneke changed the title feat: fix parity between frameworks, fix color feat(#184): fix parity between frameworks, fix color Oct 7, 2026
@anneke anneke changed the title feat(#184): fix parity between frameworks, fix color feat(#184): change radio-button color variable, fix parity Oct 7, 2026
@anneke
anneke marked this pull request as ready for review October 7, 2026 14:47
@anneke
anneke merged commit 4cca4c0 into main Oct 7, 2026
1 check passed
@anneke
anneke deleted the feat/184-radio-button-dot-color branch October 7, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use --background for radio button dot instead of --primary-foreground

1 participant