Skip to content

Re-emit job events when start, duration or reduction changes #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
netniV merged 1 commit into from
Oct 15, 2026
Merged

Re-emit job events when start, duration or reduction changes #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions mods/src/patches/parts/sync.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1652,9 +1652,10 @@ static void player_inventories(std::unique_ptr<std::string>&& bytes)
static void jobs(std::unique_ptr<std::string>&& bytes)
{
using json = nlohmann::json;
static std::unordered_set<std::string> jobs_active;
static std::mutex jobs_active_mtx;
static std::atomic_bool is_first_sync{true};
using job_state = std::tuple<int64_t, int64_t, int64_t>;
static std::unordered_map<std::string, job_state> jobs_active;
static std::mutex jobs_active_mtx;
static std::atomic_bool is_first_sync{true};

if (auto response = Digit::PrimeServer::Models::JobResponse(); response.ParseFromString(*bytes)) {

Expand All @@ -1668,10 +1669,14 @@ static void jobs(std::unique_ptr<std::string>&& bytes)
const std::string& uuid = job.uuid();
uuids_in_response.insert(uuid);

const job_state state{job.starttime().seconds(), job.duration(), job.reductioninseconds()};

bool emit = false;
{
std::scoped_lock lk(jobs_active_mtx);
emit = jobs_active.insert(uuid).second;
const auto [it, inserted] = jobs_active.try_emplace(uuid, state);
emit = inserted || it->second != state;
it->second = state;
}

if (!emit) {
Expand Down Expand Up @@ -1720,8 +1725,8 @@ static void jobs(std::unique_ptr<std::string>&& bytes)
{
std::scoped_lock lk(jobs_active_mtx);
for (auto it = jobs_active.begin(); it != jobs_active.end();) {
if (!uuids_in_response.contains(*it)) {
job_array.push_back({{"type", "completed_" + SyncConfig::Type::Jobs}, {"uuid", *it}});
if (!uuids_in_response.contains(it->first)) {
job_array.push_back({{"type", "completed_" + SyncConfig::Type::Jobs}, {"uuid", it->first}});
it = jobs_active.erase(it);
} else {
++it;
Expand Down
Loading