Repository navigation
Fix the Edit Contributor button opening the wrong person - #557
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #539 (found while tracing it; does not by itself close it).
Problem
On a contributor's page, Edit Contributor linked to the edit page with the person's user id, but the edit page (like the contributor page) looks people up by project member id. Those are separate number sequences, so the button opened a different contributor in that project, or a not-found page, for most people.
Fix
Pass the page's own
contributorId(the project member id), as the contributors table and the edit page's own links already do. I checked every other link to these pages: they pass member ids correctly (the tag people table'suserIdfield is a member id, just misleadingly named).Testing
ContributorPage.test.tsx: with member 41 whose user id is 7, the Edit button points at/projects/3/contributors/41/edit. It fails without the change (it pointed at/7/edit). Typecheck (apart from the existinggetJsonSchema.test.tserrors) and lint pass. Not yet checked in a browser.🤖 Generated with Claude Code