Repository navigation

Various improvements - #78

Open

breyerml wants to merge 224 commits into

developfrom

optimizations

Open

Various improvements#78
breyerml wants to merge 224 commits into
developfrom
optimizations

Commits on May 24, 2025
- Improve performance (mainly on AMD GPUs) and change implementations slightly such that the backends are more similar.
  breyerml
  committed
  18691a5
Commits on May 26, 2025
- Additional performance improvement tests.
  breyerml
  committed
  6cddbb6
- Preliminary changes.
  breyerml
  committed
  a185caf
Commits on May 28, 2025
- Update CUDA implementation and update comments.
  breyerml
  committed
  c74aca8
- Do not use std::vector directly for the kernel matrix since it sequentially initializes all values to zero.
  breyerml
  committed
  dbc00ae
Commits on May 29, 2025
- Improve the performance of the OpenMP cg_explicit kernel matrix assembly and BLAS implementation. Align names more to the ones used in the other backends.
  breyerml
  committed
  10d303e
Commits on May 30, 2025
Commits on May 31, 2025
- Update documentation and add missing headers.
  breyerml
  committed
  0c68206
- Update the HIP backend kernels.
  breyerml
  committed
  a9e8271
- Fix Doxygen documentation.
  breyerml
  committed
  45832e7
- Add additional assert.
  breyerml
  committed
  10ff3c2
- Fix variable names.
  breyerml
  committed
  dad55f2
- Use typename instead of class.
  breyerml
  committed
  e6b76f2
- Move parallel zero memset to header function (used in multiple places).
  breyerml
  committed
  5913b50
- Add documentation and rearrange constant declarations.
  breyerml
  committed
  a67751b
- Inverse all temp indices for better consistency.
  breyerml
  committed
  54741ff
- Add missing doxygen documentation.
  breyerml
  committed
  46891d9
- Update the HPX backend kernels.
  breyerml
  committed
  fa5cea3
Commits on Jun 14, 2025
Commits on Jun 20, 2025
- Update some comments.
  breyerml
  committed
  39513f8
- Also use trimmed names in performance tracking output.
  breyerml
  committed
  3ef281d
- Always use a loop for the custom powi function.
  breyerml
  committed
  a20d76d
- The get_default_queue now honors the default target platform.
  breyerml
  committed
  1c55fb1
Commits on Jun 21, 2025
- Improve the AdaptiveCpp device pointer creation performance on CPUs with the OpenMP backend.
  breyerml
  committed
  b6b98fc
Commits on Jun 22, 2025
Commits on Jun 30, 2025
- Add missing include.
  breyerml
  committed
  63f8b6b
- Update the Kokkos backend kernels.
  breyerml
  committed
  ed5d124
- Update power function implementation.
  breyerml
  committed
  7f8acb5
Commits on Jul 1, 2025
- Fix Kokkos related compiler error.
  breyerml
  committed
  cfc3d68
- Update the OpenCL backend kernels.
  breyerml
  committed
  31b4f99
- Fix OpenCL kernel.
  breyerml
  committed
  b3f8b22
Commits on Jul 5, 2025
- Rename variable for better consistency with other backends.
  breyerml
  committed
  dc6c267
- Make blocking sizes constexpr instead of only const.
  breyerml
  committed
  23d6350
- Update comments.
  breyerml
  committed
  3eea873
- Update formatting for better consistency with the other backends.
  breyerml
  committed
  1c4e479
- Change THREAD_BLOCK_SIZE to THREAD_BLOCK_SIZE_uz.
  breyerml
  committed
  a029f23
- Fix documentation error using q vector instead of w vector.
  breyerml
  committed
  efda49d
- Update the stdpar backend kernels.
  breyerml
  committed
  8ecd618
- Fix stdpar tests after changing the kernel function interface (from free function to function object).
  breyerml
  committed
  ee08eaa
Commits on Jul 7, 2025
Commits on Jul 10, 2025
Commits on Jul 12, 2025
Commits on Jul 13, 2025
- Fix decltype error.
  breyerml
  committed
  88c69a3
Commits on Jul 20, 2025
- Improve AdaptiveCpp CMake warning for hierarchical and scoped kernels.
  breyerml
  committed
  d4145fe
- Fix wrong PLSSVM_ASSERT and update test case.
  breyerml
  committed
  06fa031
Commits on Aug 9, 2025
- Fix error where the CPU kernels where used on GPUs and vice-versa.
  breyerml
  committed
  b8ad451
- Interchange / and % in the stdpar kernel index calculation. Now, the correct index moves the fastest.
  breyerml
  committed
  c48818f
Commits on Aug 10, 2025
Commits on Aug 17, 2025
- Add Python pickle support.
  breyerml
  committed
  b658c4e
- Bump Pybind11 version to 3.0.0.
  breyerml
  committed
  4196499
- Convert the usage of py::enum_ to the new and recommended py::native_enum.
  breyerml
  committed
  d99e8b8
- Fix compiler warnings and remove deprecated functions.
  breyerml
  committed
  a3e3f45
Commits on Aug 23, 2025
- Interchange / and % in the stdpar kernel index calculation. Now, the correct index moves the fastest.
  breyerml
  committed
  43257c2
- If AdaptiveCpp is built with OpenCL support, it may happen that multiple devices for the same CPU are found since the AdaptiveCpp host device is always active. In this case, remove said host device…
  breyerml
  committed
  76a4f58
Commits on Sep 4, 2025
- Fix some inconsistencies (mainly documentation).
  breyerml
  committed
  c17ea43
- Fix typo.
  breyerml
  committed
  56668db
Commits on Sep 7, 2025
- Add check to the device_ptr such that if an empty device_ptr is constructed no memset operation is automatically performed. Add additional test to test against the new behavior.
  breyerml
  committed
  37468bc
- Improve final error message if an exception would escape the main function if MPI is not enabled.
  breyerml
  committed
  6f9a051
Commits on Sep 9, 2025
Commits on Sep 12, 2025
- The number of contexts must be greater or equal than one and not exactly one (would otherwise fail in multi-GPU setups).
  breyerml
  committed
  018e1a4
Commits on Sep 28, 2025
- Also output the device names for the stdpar implementations as list to be in line with the other backends (although it's guaranteed that stdpar at most has one device).
  breyerml
  committed
  e1a1940
- add AdaptiveCpp related JIT directory to the gitignore
  breyerml
  committed
  74b5658
Commits on Oct 13, 2025
Commits on Oct 18, 2025
Commits on Nov 30, 2025
- Fix wrong include guards and add missing #pragma once.
  breyerml
  committed
  c6e9d92
- Update documentation and includes.
  breyerml
  committed
  959a7f4
- Fix Doxygen parsing error.
  breyerml
  committed
  5ef41c6
- Replace magic numbers with named constants.
  breyerml
  committed
  c1e217e
- Move overloaded helper struct to the utility header.
  breyerml
  committed
  104c636
- Add explicit NOLINT statements.
  breyerml
  committed
  4af72fd
- Add missing const, noexcept, [[nodiscard]], etc specifiers.
  breyerml
  committed
  54113f4
- Remove redundant explicit default initializers.
  breyerml
  committed
  cae9b9c
- Add new type trait.
  breyerml
  committed
  fbb7a96
- Move the sign function to the operators namespace.
  breyerml
  committed
  18df510
- Do not use else after a return or throw.
  breyerml
  committed
  aec4a0a
- Update some logical conditions and optional handlings.
  breyerml
  committed
  534961a
- Use anonymous namespaces.
  breyerml
  committed
  404c34d
- Add configuration option to NOT include the "hpx/hpx_main.hpp" header (may lead to linker errors if included in multiple translation units.
  breyerml
  committed
  7a8f2f7
- Handle potential exception.
  breyerml
  committed
  7e18480
- Correctly handle SYCL namespaces.
  breyerml
  committed
  0555816
- Correctly use move, forward, and cref.
  breyerml
  committed
  1b903dd
- Explicitly add unused parameter names.
  breyerml
  committed
  8ee721f
- Do not make map_label virtual since it is called inside a constructor.
  breyerml
  committed
  16f715b
- Use the comm_ member variable instead of the (moved-from) comm parameter.
  breyerml
  committed
  eeb5d38
- Add friend declaration and make some constructors private.
  breyerml
  committed
  7f6597e
- Add explicit casts and remove some unnecessary ones.
  breyerml
  committed
  5900b0d
- Add requires to narrow down potential template parameter type.
  breyerml
  committed
  1968526
- Fix an error where for some reason the fill_array kernel is NOT called for HIP on NVIDIA GPUs (implements a fallback using the CPU).
  breyerml
  committed
  db75ce7
- Try to allocate the device_ptr memory only for sizes > 0.
  breyerml
  committed
  6e54ac0
- Use the operator[] instead of pointer arithmetic.
  breyerml
  committed
  e06b562
- Remove TODO.
  breyerml
  committed
  712c486
- Prevent exception escape.
  breyerml
  committed
  71cf7a6
- Rename variables.
  breyerml
  committed
  02ad38d
- Add reserve call.
  breyerml
  committed
  0ed284f
- Update the source location logic in case of MPI is available.
  breyerml
  committed
  1be3eeb
- Fix wrong PLSSVM_ASSERT condition.
  breyerml
  committed
  d5eef1a
- Rename variable.
  breyerml
  committed
  de0f1e8
- Fix some clang-tidy warnings.
  breyerml
  committed
  6d8ea0b
- Add CMake warning for the combination:
  breyerml
  committed
  286ff8b
- Warning needs not to be silenced anymore.
  breyerml
  committed
  624d343
- Add reinterpret_array functions.
  breyerml
  committed
  347492c
- Update documentation.
  breyerml
  committed
  f44915c
- Use standard std::array instead of C-style arrays.
  breyerml
  committed
  68dd5b3
- Add missing const and update scratch memory declaration.
  breyerml
  committed
  025211e
- Add comment regarding the hpx_main.hpp header to the README file.
  breyerml
  committed
  121c692
- Add clang-tidy.
  breyerml
  committed
  5e1551b
- Update documentation.
  breyerml
  committed
  2070e65
- Move forward declarations to a header file.
  breyerml
  committed
  9bc4418
- Update includes and header guards.
  breyerml
  committed
  68e57a0
- Do not use else after return or throw.
  breyerml
  committed
  2e29f95
- Remove forward declaration.
  breyerml
  committed
  10d7f07
- Add missing const or reference.
  breyerml
  committed
  d50e747
- Remove wrong return.
  breyerml
  committed
  f55de2d
- Remove redundant default initializations.
  breyerml
  committed
  1c2218f
- Update documentation strings.
  breyerml
  committed
  75f15b0
- Replace magic number with named variable.
  breyerml
  committed
  2bb9a02
- Explicitly name all parameters.
  breyerml
  committed
  5f4bf11
- Add explicit NOLINT.
  breyerml
  committed
  a1077bf
- Replace std::move with std::forward.
  breyerml
  committed
  a1b81e5
- Explicitly add pointer type.
  breyerml
  committed
  91cb6a4
- Remove redundant statement.
  breyerml
  committed
  621790c
- Improve documentation.
  breyerml
  committed
  977c42d
- Correctly guard compilation flag behind a generator expression.
  breyerml
  committed
  c8393e3
- Add clang-tidy support to the Python bindings directory.
  breyerml
  committed
  11388d4
Commits on Dec 2, 2025
- Rename all test cases to comply with GoogleTest's naming conventions.
  breyerml
  committed
  fb3473d
- Split the matrix tests into multiple files.
  breyerml
  committed
  7500fb7
- Update includes.
  breyerml
  committed
  29a6bb0
- Update include guards.
  breyerml
  committed
  559ba11
- Add missing references and const, use auto with explicit casts, remove unnecessary inline.
  breyerml
  committed
  bb4473f
- Update (failing) test cases.
  breyerml
  committed
  6ea9549
- Update namespace handling.
  breyerml
  committed
  9bcf86e
- Fix HPX linker error.
  breyerml
  committed
  4888708
- Fix some default initialization warnings.
  breyerml
  committed
  79f3e0d
- Improve optional handling.
  breyerml
  committed
  6b33c5a
- Add explicit clang-tidy NOLINT, add directory specific .clang-tidy files, and disable clang-tidy for the gtest target.
  breyerml
  committed
  d727d47
- Fix various clang-tidy warnings.
  breyerml
  committed
  2d05730
- Fix compilation errors and warnings.
  breyerml
  committed
  202fb8d
- Use correct factory function.
  breyerml
  committed
  5a77963
- Add missing tests.
  breyerml
  committed
  6ba55df
- Add the SVM parameter to the performance tracking output for the plssvm-predict executable.
  breyerml
  committed
  cac1d22
Commits on Dec 8, 2025
Commits on Dec 11, 2025
Commits on Dec 12, 2025
- For the dpcpp/icpx test presets disable PLSSVM_ENABLE_SYCL_HIERARCHICAL_AND_SCOPED_KERNELS since it is not supported in the Debug build type (internal compiler crash).
  breyerml
  committed
  7c8342f
Commits on Dec 14, 2025
Commits on Dec 15, 2025
- Fix clang-format.
  breyerml
  committed
  a20af0a
- Update GitHub actions.
  breyerml
  committed
  5a4db76
- Fix install documentation.
  breyerml
  committed
  c6d107d
Commits on Dec 19, 2025
Commits on Dec 20, 2025
- Add __sklearn_tags__ function which is mandatory since version 1.8.0.
  breyerml
  committed
  86462df
- Try reducing the amount of dots in the GitHub action output.
  breyerml
  committed
  e8f9413
Commits on Dec 21, 2025
Commits on Dec 22, 2025
Commits on Dec 28, 2025
- Small documentation consistency updates.
  breyerml
  committed
  8615532
Commits on Dec 30, 2025
- If the performance tracker (implemented as global singleton) is enabled and tests are run in parallel, race conditions may occur if more then one thread want to add a tracking entry (multiple concu…
  breyerml
  committed
  a7dcd91
Commits on Dec 31, 2025
- Fix error in SYCL's basic data parallel kernel (only manifested in multi-GPU setups): the grid_x_offset and grid_y_offset was swapped.
  breyerml
  committed
  6ec59bb
- Fix error in SYCL's basic data parallel kernel (only manifested in multi-GPU setups): the grid_x_offset and grid_y_offset was swapped.
  breyerml
  committed
  596155e
Commits on Jan 2, 2026
- Add missing offset to if conditions in the hierarchical and scoped kernel matrix assembly kernels.
  breyerml
  committed
  da69944
Commits on Jan 9, 2026
- Use plain c-style arrays instead of std::array again in the SYCL hierarchical kernel since std::array results in a SegFault when compiled for the CPU.
  breyerml
  committed
  1caf833
- Allocate device_ptr memory only for sizes > 0 on all backends (fixing test errors on CPUs).
  breyerml
  committed
  61cd504
Commits on Jan 10, 2026
- Use c-style arrays again instead of std::array to be more consistent (since c-style arrays HAVE to be used in the hierarchical kernels due to a icpx internal compiler SegFault) and to be sure that …
  breyerml
  committed
  3e1e943
Commits on Feb 3, 2026
- Include "cuda_runtime_api.h" for stdpar_nvhpc only if a GPU has been targeted.
  breyerml
  committed
  f647cce

Commits

Commits on May 24, 2025

Commits on May 26, 2025

Commits on May 28, 2025

Commits on May 29, 2025

Commits on May 30, 2025

Commits on May 31, 2025

Commits on Jun 14, 2025

Commits on Jun 20, 2025

Commits on Jun 21, 2025

Commits on Jun 22, 2025

Commits on Jun 30, 2025

Commits on Jul 1, 2025

Commits on Jul 5, 2025

Commits on Jul 7, 2025

Commits on Jul 10, 2025

Commits on Jul 12, 2025

Commits on Jul 13, 2025

Commits on Jul 20, 2025

Commits on Aug 9, 2025

Commits on Aug 10, 2025

Commits on Aug 17, 2025

Commits on Aug 23, 2025

Commits on Sep 4, 2025

Commits on Sep 7, 2025

Commits on Sep 9, 2025

Commits on Sep 12, 2025

Commits on Sep 28, 2025

Commits on Oct 13, 2025

Commits on Oct 18, 2025

Commits on Nov 30, 2025