Repository navigation
Light and overlay fixes [develop] [4/4] - #922
PetrilloAtWork wants to merge 168 commits into
Conversation
…plate It used to end when the template SPR goes under 1e-4 ADC#. Now it needs to stay within +/- 1w-4 ADC# for 20 nanoseconds. This should make it possible to include undershootings. All these parameters are currently hard-coded.
…icles that might cross cathode
Good catches on names and strings. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mvicenzi
left a comment
mvicenzi
left a comment
There was a problem hiding this comment.
This looks good to me! All developments have been imported: diff-ing this branch with my local area shows no unexpected differences.
jas1005
left a comment
jas1005
left a comment
There was a problem hiding this comment.
Everything looks fine from a release management standpoint. If Matteo's happy, I'm happy! I can confirm that the two PRs mentioned for production were successfully merged. So if there are no meaningful differences from Matteo's diff, we should be good to go.
|
trigger build LArSoft/larsoft@v10_26_00 LArSoft/lar*@LARSOFT_SUITE_v10_26_00 SBNSoftware/sbncode@v10_26_00 SBNSoftware/sbn*@SBN_SUITE_v10_26_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
trigger build LArSoft/larsoft@v10_26_00 LArSoft/lar*@LARSOFT_SUITE_v10_26_00 SBNSoftware/sbncode@v10_26_00 SBNSoftware/sbn*@SBN_SUITE_v10_26_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06_01 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
trigger build LArSoft/larsoft@v10_26_00 LArSoft/lar*@LARSOFT_SUITE_v10_26_00 SBNSoftware/sbncode@v10_26_00 SBNSoftware/sbnalg@v10_26_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06_01 SBNSoftware/sbnobj@v10_23_00 SBNSoftware/sbnanaobj@v10_26_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
@PetrilloAtWork and @mvicenzi, There are some build errors from CI build 15462 that need resolving. I'm attaching the build log from the CI build here: |
|
@jas1005 This PR needs SBNSoftware/sbncode#671, which was included only in sbncode v10_27_00, not in v10_26_00. Can you try bumbing the sbndcode version? |
4 participants
This is the mirror set of pull requests as #917 and #892 (and all dependent ones).
The approval of the content of this PR is in principle the same as for those, but because this branch was obtained by cherry-picking, some additional scrutiny may be justified.
Additional PR are required before/together with this one:
develop] [1/4] sbnalg#10develop] [2/4] sbncode#671develop] [3/4] icarusalg#102develop] [4/4] #922 (for listing completeness)Reviewers: