Repository navigation
Views fk guesser - #152
Open
tim-band wants to merge 22 commits into
Open
Views fk guesser#152tim-band wants to merge 22 commits into
tim-band wants to merge 22 commits into
Conversation
added 21 commits
September 23, 2026 14:43
Also: - fixed role change text - fixed remove all roles - allow intervals and copying from same column in aliased table
You can't copy or anchor from nullable (or via nullable) to non-nullable. You can't copy from an FK to an FK that points to a different table. Bugs fixed.
These don't work in Snowflake
Simplified the code as a result
because Snowflake doesn't like this.
Also loading hive partitioned parquet is now done by fastparquet.
Updated --views-to-tables help text. Added a test to show that PK/FK guessing works with views. Removed a spurious log call.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate the Foreign Key / Primary Key guesser from the Parquet file reading.
Allow the guesser to be used independently, make it work when
--views-to-tablesis used (views don't have FK/PK constraints so the normal method of understanding PKs or FK relationships won't work).Fixes #151