Repository navigation
구글 인증 중 화면 재생성 시 요청 복원 - #653
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
구글 인증 중 액티비티가 재생성되면 기존 요청을 잃고 인증을 다시 시작하던 문제를 수정한다.
Evidence
복원 시 새 인증 화면을 열지 않고 돌아온 인증 결과에 기존 verifier를 전달하며, 취소와 코드 없는 응답을 성공으로 처리하지 않는 Robolectric 테스트가 통과했다. 실제 구글 인증 결과 복귀와 제보된 증상의 동일 여부는 기기 확인이 필요하다.
Merge Danger
Closes #646