Repository navigation
Resolve ros_distro selectors in package tests - #164
Merged
Tobias-Fischer merged 2 commits intoOct 16, 2026
Merged
Conversation
Tobias-Fischer
force-pushed
the
feat/distro-test-selectors
branch
2 times, most recently
from
October 10, 2026 04:26
46e8dd0 to
e5b291c
Compare
Selectors that test ros_distro (e.g. if: ros_distro in ["humble", "jazzy"]) are resolved when a test file is put into a recipe, so one test file serves several distributions; platform selectors stay for rattler-build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tobias-Fischer
force-pushed
the
feat/distro-test-selectors
branch
from
October 15, 2026 20:41
e5b291c to
102428a
Compare
7 of 16 tasks
Contributor
Author
|
@traversaro this is ready for review/merge |
traversaro
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ros_distroselectors in package testsWhen a test file from
tests/is put into a recipe,if:selectors that testros_distroare resolved. One test file can then serve several distributions, which matters once they sharetests/throughextends. All other selectors (osx,win, …) are left unchanged for rattler-build.This replaces rendering distribution-specific tests with Jinja templates, as the distro template (Tobias-Fischer/ros-distro-template) did for
robot_state_publisher. Tobias-Fischer/robostack-distros already uses these selectors in its shared tests forrobot_state_publisher,ros2cliandrosidl_cli.There's a new test for the resolution (
vinca/test_distro_selectors.py); all 291 tests pass, ruff and pyrefly are clean, and the README has a short section.🤖 Generated with Claude Code