Skip to content

Add support for rclpy_message_converter and rclpy_message_converter_msgs in lyrical. - #43

Merged
traversaro merged 3 commits into
RoboStack:mainfrom
TomNysWF:add-rclpy-message-converter
Sep 14, 2026
Merged

traversaro merged 3 commits into
RoboStack:mainfrom
TomNysWF:add-rclpy-message-converter

Conversation

@TomNysWF

@TomNysWF TomNysWF commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Add support for rclpy_message_converter and rclpy_message_converter_msgs in lyrical.

@TomNysWF

TomNysWF commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

I had to add a different exclusion for the windows build to work, this same bug might also be present in other PR's

=>
The exclusion under packages_select_by_deps only kept it out of the top-level selection on win-64; it was still pulled in transitively as a dependency of autoware_internal_msgs/autoware_utils/autoware_utils_debug and failed there with MSVC error C1083 (long-path issue), aborting the Windows build before it ever reached the newly added rclpy_message_converter packages. Move it to packages_skip_by_deps/packages_remove_from_deps for win, matching the existing pendulum_control/rttest/tlsf pattern - it's only an unused package.xml of autoware_internal_msgs, not something its own .msg/CMake code actually needs.

@traversaro

Copy link
Copy Markdown
Member

I had to add a different exclusion for the windows build to work, this same bug might also be present in other PR's

=> The exclusion under packages_select_by_deps only kept it out of the top-level selection on win-64; it was still pulled in transitively as a dependency of autoware_internal_msgs/autoware_utils/autoware_utils_debug and failed there with MSVC error C1083 (long-path issue), aborting the Windows build before it ever reached the newly added rclpy_message_converter packages. Move it to packages_skip_by_deps/packages_remove_from_deps for win, matching the existing pendulum_control/rttest/tlsf pattern - it's only an unused package.xml of autoware_internal_msgs, not something its own .msg/CMake code actually needs.

I do not think that is a bug, it is a feature. If rclpy_message_converter or rclpy_message_converter_msgs is needed by autoware_internal_msgs/autoware_utils/autoware_utils_debug and one of those packages are needed on Windows, it make sense that the package is built. If that chain fails on Windows, either the build needs to be fixed, or autoware_internal_msgs/autoware_utils/autoware_utils_debug should be excluded for Windows. Adding the package to packages_remove_from_deps is dangerous, as it just removes the dependency, but if that dependency is there in the first place it is probably indeed needed, and removing could create runtime failures of the package.

@traversaro

Copy link
Copy Markdown
Member

Can you try adding them again after #41 has been merged? Thanks!

@traversaro
traversaro merged commit 29e88e3 into RoboStack:main Sep 14, 2026
5 checks passed
@TomNysWF
TomNysWF deleted the add-rclpy-message-converter branch September 14, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants