Repository navigation
Small fixes from #39–#41; uploads without tokens - #46
Merged
Merged
Conversation
This was referenced Oct 10, 2026
From Tim's PRs (the parts that fix real problems on main): - automerge goes by the label the PR has now (events can arrive out of order) and refuses to turn on without the bot token (a GITHUB_TOKEN merge doesn't start the build workflow) - CI installs with locked: the lock file must match pixi.toml - one build-branch generation per distribution at a time - check-patches includes shared/patch (a distribution's patches for a package replace the shared ones, like in vinca) - rs check accepts build_number 0 and an empty migration list; the pinning renders `migrations: []`; update-pinning fails when render-pinning does - import_distro: names follow the source distribution with --distro, files the old repository no longer has are removed, ci.yaml is kept Uploads use prefix.dev trusted publishing only: PREFIX_API_KEY and the anaconda.org upload (ANACONDA_API_TOKEN, also stripped from the generated workflows) are gone. Distributions whose channel is still on anaconda.org are read from there and upload to ROBOSTACK_UPLOAD_CHANNEL. Co-Authored-By: Tim de Jager <tdejager89@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tobias-Fischer
force-pushed
the
small-fixes
branch
from
October 10, 2026 00:53
776e8de to
064161c
Compare
This was referenced Oct 10, 2026
Tobias-Fischer
added a commit
that referenced
this pull request
Oct 10, 2026
Jobs that declare permissions get none they don't list, so the generated build jobs (id-token: write, attestations: write) had no contents permission; checking out only worked because the repository is public. rs gha adds contents: read to every job and refuses a job with permissions without it. Closes #38: the other half, tokens on the command line, went with #46. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #42, which GitHub closed when main's history was rewritten into topic commits; same branch, rebased (the change is identical).
Takes the parts of @tdejager's #39, #40 and #41 that fix real problems on main, kept small (see the review comments there), and removes the upload tokens.
From #39
GITHUB_TOKENdoesn't start the build workflow. A per-PR concurrency group is added too.locked: trueinstead offrozen, so a lock file that doesn't matchpixi.tomlfails up front.generate-<distro>concurrency group). Two quick merges no longer push build branches in parallel.check-patches: now also checksshared/patch. As in vinca, a distribution's patches for a package replace the shared ones. Until now,ros2-swri-serial-util.patchwas never checked.From #40
rs checkacceptsbuild_number: 0(whatnew-distrowrites) and an empty migration list.migrations: [].update-pinningfails whenrender-pinningfails.From #41 (
import_distro.py)--distro,ros-<source>-*names are converted using the source distribution.ci.yamlis kept on re-import.Uploads without tokens
PREFIX_API_KEYhandling is gone.ANACONDA_API_TOKEN, also stripped from the generated workflows, so no token appears on the command line any more.ROBOSTACK_UPLOAD_CHANNEL. Without it, the upload fails with a clear message.Left out
release.py.ANACONDA_API_KEY, so uploads would have lost their credentials. Now moot.add-packageunion, and the rollback machinery.package_name_mode: newswitch (it would drop theros-<distro>-*packages) and the staging/rollback machinery.Verified
rs checkpasses, and actionlint is clean.id-token: write.tobias-fischer/robostack-distro-test;robostack-lyrical.Fixes #27, fixes #29, fixes #32, fixes #36. Part of #26, #31, #34, #38.
🤖 Generated with Claude Code