Skip to content

Spinnaker Driver Improvement - #46

Open
guyfleeman wants to merge 5 commits into
masterfrom
dev/will/spinnaker_driver_rework_to_master
Open

guyfleeman wants to merge 5 commits into
masterfrom
dev/will/spinnaker_driver_rework_to_master

Conversation

@guyfleeman

@guyfleeman guyfleeman commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

This PR combines #42, #44, and #45 but against master rather than v2.0-alpha. If this lands in master we should close 42, 44, 45 so the history is clean, and then merge master to v2.0-alpha.

Still needs physical testing against local and league hardware. Most fixes were
tested on #45, but this has additional changes.

New Features:

  • Support for the BFLY-PGE(-13E4C) Gen 1 camera series, used by A-Team, RoboJackets, and Peachtree Open
  • Spinnaker driver now queries camera for supported bayering modes, and auto matches to supported CL kernel modes
  • Spinnaker driver now accepts pinning by serial/serial enumeration making indexing stable when cameras disconnect
  • Substantial improvements to logging warnings and errors within the driver
  • WARN_ONCE macro prevents spam of feature related warnings
  • Adds spinnaker_probe tool to list camera serials and dump supported driver features as json

Bug Fixes:

  • Spinnaker exceptions no longer escape the driver crashing the program
  • Boost exceptions within spinnaker shared library no longer escape the driver crashing the program
  • Missing camera features now warn once rather than crashing
  • Incomplete frames due to PHY layer checksum failures now log, count, and skip rather than crash
  • Fixed edge cases where camera resets and resolution changes would be silently ignored
  • Double free/mem release in the fallback path is fixed
  • Print logic on locking OpenCL shared buffer was inverted
  • Hard coded GigE packet MTU would crash when jumbo frames were disabled. This is now a warning, as performance is still likely to degrade when jumbo frames are disabled
  • Driver now exits cleanly on a variety of error conditions, like camera unplugged/setup failure
  • Extra link checks on spinnaker secondary dependencies warn if they're on the path

@guyfleeman
guyfleeman requested a review from lixfel October 24, 2026 23:08
@guyfleeman guyfleeman self-assigned this Oct 24, 2026
@guyfleeman

Copy link
Copy Markdown
Contributor Author

I was able to set core parameters in the lab. I think this is good to try on your end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant