Repository navigation
Spinnaker Open CL Fixes - #43
Closed
guyfleeman wants to merge 26 commits into
Closed
guyfleeman wants to merge 26 commits into
guyfleeman wants to merge 26 commits into
Conversation
…iles for docs maint, lots of cleanups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I caught a few things in testing I didn't catch on the first go.
There's a possible double free because of the Copy constructor in CLArray. I wrapped the raw pointed in a shared pointer with the free function overriden with munlock and free. This resolves that. It wasn't impacting the code as written, but exists as a bug and is very close to a foot gun with changes.
mlock function return logic was inverted to the print logic. https://pubs.opengroup.org/onlinepubs/9799919799/
Line 140 accidentally sets the CL_MEM_USE_HOST_PTR bit, instead of checks it. This results in a CL_INVALID_HOST_PTR error on some configuration paths.