Skip to content

Update dependencies and CI, fixes #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johguenther merged 11 commits into from
Oct 2, 2026
+629 −541
Merged

Update dependencies and CI, fixes #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
58b0aac
Update dependencies and CI
johguenther Aug 10, 2026
88fccfc
Bump CMake minimum required version to 3.10
johguenther Dec 10, 2025
a4c59e6
Fix enum size on Windows with older MSVC
johguenther Aug 11, 2026
4ce8456
CI updates
johguenther Mar 12, 2026
27f9ec7
Sanitizer: Shut down OSPRay before exit in ospBenchmark
johguenther Aug 21, 2026
506e9a6
MPI tutorial to use chrono::steady_clock like GLFWOSPRayWindow
johguenther Mar 12, 2026
88f76ad
Fix indexing and aliasing bugs in makeAMR
johguenther Jul 1, 2026
e7fec59
Bump to Embree v4.4 (switch to rtcTraversable)
johguenther Mar 16, 2026
a010a1e
Set DEPENDENTLOADFLAG also for Clang/SYCL
johguenther Aug 15, 2026
0b66ea9
Fix crash on GPU with multiple volumes
johguenther Aug 7, 2026
1fc3647
Fix MPI sanitizer and what it found
johguenther Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ jobs:
image: rockylinux:8.7
env-from-files: .github/workflows/dpcpp.env
cmd: |
module load cmake/3.25.3
module load mpi/mpich-x86_64
export CC=clang
export CXX=clang++
scripts/build/linux.sh -DBUILD_GPU_SUPPORT=ON
artifact-out: build-linux
artifact-path: build/install/ospray build/CMakeCache.txt build/*/build/CMakeCache.txt
Expand All @@ -41,7 +37,6 @@ jobs:
secrets: inherit
with:
runs-on: '"vis-perf-x8280-1"'
setup-benny: true
cmd: |
scripts/tests/run-benchmarks.sh
artifact-in: build-linux
Expand All @@ -52,7 +47,6 @@ jobs:
secrets: inherit
with:
runs-on: '"vis-perf-x8380-1"'
setup-benny: true
cmd: |
scripts/tests/run-benchmarks.sh
artifact-in: build-linux
Expand All @@ -63,7 +57,6 @@ jobs:
secrets: inherit
with:
runs-on: '"vis-perf-a3970x-1"'
setup-benny: true
cmd: |
scripts/tests/run-benchmarks.sh
artifact-in: build-linux
Expand All @@ -74,7 +67,6 @@ jobs:
secrets: inherit
with:
runs-on: '"vis-perf-i9-12900k-1"'
setup-benny: true
cmd: |
scripts/tests/run-benchmarks.sh
artifact-in: build-linux
Expand All @@ -88,21 +80,6 @@ jobs:
env-from-files: .github/workflows/gfx-ubuntu22.env
options: --device=/dev/dri:/dev/dri
runs-on: '"vis-perf-dg2-01"'
setup-benny: true
cmd: |
scripts/tests/run-benchmarks.sh GPU
artifact-in: build-linux

benchmark-pvc:
needs: build-linux
uses: intel-innersource/libraries.devops.renderkit.workflows/.github/workflows/docker.yml@main
secrets: inherit
with:
image: ubuntu:22.04
env-from-files: .github/workflows/gfx-ubuntu22.env
options: --device=/dev/dri:/dev/dri
runs-on: '"vis-perf-spr-pvc-01"'
setup-benny: true
cmd: |
scripts/tests/run-benchmarks.sh GPU
artifact-in: build-linux
51 changes: 37 additions & 14 deletions .github/workflows/ci.linux.gpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ jobs:
image: ubuntu:22.04
env-from-files: .github/workflows/dpcpp.env
cmd: |
module load cmake/3.25.3
export CC=clang
export CXX=clang++
scripts/build/linux.sh -G Ninja -DBUILD_GLFW=OFF -DBUILD_GPU_SUPPORT=ON -DBUILD_OSPRAY_MODULE_MPI=ON -DBUILD_OSPRAY_MODULE_MULTIDEVICE=ON
artifact-out: build-ubuntu2204-mpi-dpcpp
artifact-path: build/install/ospray build/CMakeCache.txt build/*/build/CMakeCache.txt
Expand All @@ -38,8 +35,10 @@ jobs:
with:
image: ubuntu:22.04
env-from-files: .github/workflows/icx-linux.env .github/workflows/gfx-ubuntu22.env # OIDN AOT needs ocloc
options: --device=/dev/dri:/dev/dri
runs-on: '"dg2"'
cmd: |
module load cmake/3.25.3
unset no_proxy && unset NO_PROXY && apt update -y && apt install -y intel-ocloc # for OIDN AOT
scripts/build/linux.sh -G Ninja -DBUILD_GLFW=OFF -DBUILD_GPU_SUPPORT=ON -DBUILD_OSPRAY_MODULE_MPI=ON -DBUILD_OSPRAY_MODULE_MULTIDEVICE=ON -DBUILD_EMBREE_FROM_SOURCE=ON -DBUILD_OPENVKL_FROM_SOURCE=ON -DBUILD_OIDN_FROM_SOURCE=ON
artifact-out: build-ubuntu2204-mpi-icx
artifact-path: build/install/ospray build/CMakeCache.txt build/*/build/CMakeCache.txt
Expand All @@ -49,10 +48,9 @@ jobs:
uses: intel-innersource/libraries.devops.renderkit.workflows/.github/workflows/docker.yml@main
secrets: inherit
with:
image: opensuse/leap:15.3
image: opensuse/leap:15.4
env-from-files: .github/workflows/icx-linux.env
cmd: |
module load cmake/3.25.3
scripts/build/linux.sh -DBUILD_GPU_SUPPORT=ON -DBUILD_EMBREE_FROM_SOURCE=ON -DBUILD_OPENVKL_FROM_SOURCE=ON

rocky8-mpich-dpcpp-build:
Expand All @@ -62,10 +60,7 @@ jobs:
image: rockylinux:8
env-from-files: .github/workflows/dpcpp.env
cmd: |
module load cmake/3.25.3
module load mpi/mpich-x86_64
export CC=clang
export CXX=clang++
export PATH=/usr/lib64/mpich/bin:$PATH
scripts/build/linux.sh -DBUILD_GPU_SUPPORT=ON -DBUILD_OSPRAY_MODULE_MPI=ON -DBUILD_OSPRAY_MODULE_MULTIDEVICE=ON
artifact-out: build-rocky8-mpich-dpcpp
artifact-path: build/install/ospray build/CMakeCache.txt build/*/build/CMakeCache.txt
Expand All @@ -74,6 +69,20 @@ jobs:

### TEST JOBS ###

dpcpp-cpu-ubu22-test:
needs: ubu22-mpi-dpcpp-build
uses: intel-innersource/libraries.devops.renderkit.workflows/.github/workflows/docker.yml@main
secrets: inherit
with:
image: ubuntu:22.04
artifact-in: build-ubuntu2204-mpi-dpcpp
artifact-out: test-ubuntu2204-dpcpp-cpu
artifact-path: build_regression_tests/tests*.xml build_regression_tests/failed*
artifact-on-failure: true
cmd: |
export PATH="$GITHUB_WORKSPACE/build/install/ospray/bin:$PATH"
scripts/tests/run_tests.sh "$GITHUB_WORKSPACE"

dpcpp-dg2-ubu22-test:
needs: ubu22-mpi-dpcpp-build
uses: intel-innersource/libraries.devops.renderkit.workflows/.github/workflows/docker.yml@main
Expand All @@ -89,7 +98,24 @@ jobs:
artifact-path: build_regression_tests/tests*.xml build_regression_tests/failed*
artifact-on-failure: true
cmd: |
module load cmake/3.25.3
export PATH="$GITHUB_WORKSPACE/build/install/ospray/bin:$PATH"
scripts/tests/run_gpu_tests.sh "$GITHUB_WORKSPACE"

dpcpp-bmg-ubu22-test:
needs: ubu22-mpi-dpcpp-build
uses: intel-innersource/libraries.devops.renderkit.workflows/.github/workflows/docker.yml@main
secrets: inherit
with:
timeout-minutes: 100
image: ubuntu:22.04
env-from-files: .github/workflows/gfx-ubuntu22.env
options: --device=/dev/dri:/dev/dri
runs-on: '"bmg"'
artifact-in: build-ubuntu2204-mpi-dpcpp
artifact-out: test-ubuntu2204-dpcpp-bmg
artifact-path: build_regression_tests/tests*.xml build_regression_tests/failed*
artifact-on-failure: true
cmd: |
export PATH="$GITHUB_WORKSPACE/build/install/ospray/bin:$PATH"
scripts/tests/run_gpu_tests.sh "$GITHUB_WORKSPACE"

Expand All @@ -108,7 +134,6 @@ jobs:
artifact-path: build_regression_tests/tests*.xml build_regression_tests/failed*
artifact-on-failure: true
cmd: |
module load cmake/3.25.3
export PATH="$GITHUB_WORKSPACE/build/install/ospray/bin:$PATH"
scripts/tests/run_gpu_tests.sh "$GITHUB_WORKSPACE"

Expand All @@ -127,7 +152,6 @@ jobs:
artifact-path: build_regression_tests/tests*.xml build_regression_tests/failed*
artifact-on-failure: true
cmd: |
module load cmake/3.25.3
export PATH="$GITHUB_WORKSPACE/build/install/ospray/bin:$PATH"
OMPI_ALLOW_RUN_AS_ROOT=1 OMPI_ALLOW_RUN_AS_ROOT_CONFIRM=1 scripts/tests/run_gpu_tests.sh "$GITHUB_WORKSPACE" SKIP_GPU TEST_MPI

Expand All @@ -146,7 +170,6 @@ jobs:
artifact-path: build_regression_tests/tests*.xml build_regression_tests/failed*
artifact-on-failure: true
cmd: |
module load cmake/3.25.3
export PATH="$GITHUB_WORKSPACE/build/install/ospray/bin:$PATH"
scripts/tests/run_gpu_tests.sh "$GITHUB_WORKSPACE" SKIP_GPU TEST_MULTIDEVICE

Expand Down
50 changes: 25 additions & 25 deletions .github/workflows/ci.linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,8 @@ jobs:
secrets: inherit
with:
image: rockylinux:8
dpcpp-version: intel/2025.3
cmd: |
module load cmake
module load intel/2022.1
export CC=icx
export CXX=icpx
export CXXFLAGS="-fhonor-infinities -fhonor-nans"
export CFLAGS=$CXXFLAGS
export LDFLAGS="-static-intel"
Expand All @@ -86,8 +83,7 @@ jobs:
with:
image: rockylinux:8
cmd: |
module load cmake
module load impi/2021.6
source $STORAGE_PATH/packages/apps/intel/oneAPI/mpi/latest/env/vars.sh
scripts/build/linux.sh -DBUILD_EMBREE_FROM_SOURCE=ON -DBUILD_OPENVKL_FROM_SOURCE=ON -DBUILD_OIDN=OFF -DBUILD_OSPRAY_MODULE_MPI=ON -DBUILD_ISA_AVX512=OFF -DTBB_VERSION=2021.9.0

build-rocky8-mpi-mpich:
Expand All @@ -96,8 +92,7 @@ jobs:
with:
image: rockylinux:8
cmd: |
module load cmake
module load mpi/mpich-x86_64
export PATH=/usr/lib64/mpich/bin:$PATH
scripts/build/linux.sh -DBUILD_EMBREE_FROM_SOURCE=ON -DBUILD_OPENVKL_FROM_SOURCE=ON -DBUILD_OIDN=OFF -DBUILD_OSPRAY_MODULE_MPI=ON -DBUILD_ISA_AVX512=OFF -DTBB_VERSION=2021.9.0
artifact-out: build-rocky8-mpi-mpich
artifact-path: build/install/ospray build/CMakeCache.txt build/*/build/CMakeCache.txt
Expand All @@ -108,8 +103,7 @@ jobs:
with:
image: rockylinux:8
cmd: |
module load cmake
module load mpi/openmpi-x86_64
export PATH=/usr/lib64/openmpi/bin:$PATH
scripts/build/linux.sh -DBUILD_EMBREE_FROM_SOURCE=ON -DBUILD_OPENVKL_FROM_SOURCE=ON -DBUILD_OIDN=OFF -DBUILD_OSPRAY_MODULE_MPI=ON -DBUILD_ISA_AVX512=OFF -DTBB_VERSION=2021.9.0

build-centos8:
Expand All @@ -128,7 +122,7 @@ jobs:
with:
image: centos:8
cmd: |
module load mpi/mpich-x86_64
export PATH=/usr/lib64/mpich/bin:$PATH
scripts/build/linux.sh -DBUILD_OSPRAY_MODULE_MPI=ON

build-centos8-mpi-openmpi:
Expand All @@ -137,7 +131,7 @@ jobs:
with:
image: centos:8
cmd: |
module load mpi/openmpi-x86_64
export PATH=/usr/lib64/openmpi/bin:$PATH
scripts/build/linux.sh -DBUILD_OSPRAY_MODULE_MPI=ON

build-rocky8-oidn-mpi:
Expand All @@ -146,8 +140,7 @@ jobs:
with:
image: rockylinux:8
cmd: |
module load cmake/3.15.2
module load mpi/mpich-x86_64
export PATH=/usr/lib64/mpich/bin:$PATH
scripts/build/linux.sh -DBUILD_OSPRAY_MODULE_MPI=ON
artifact-out: build-rocky8-oidn-mpi
artifact-path: build/install/ospray build/CMakeCache.txt build/*/build/CMakeCache.txt
Expand All @@ -165,7 +158,8 @@ jobs:
export LDFLAGS=-fsanitize=address
scripts/build/linux.sh -G Ninja -DBUILD_GLFW=OFF -DCMAKE_BUILD_TYPE=Debug -DBUILD_OSPRAY_MODULE_MPI=ON
artifact-out: build-linux-debug
artifact-path: build/install/ospray build/CMakeCache.txt build/*/build/CMakeCache.txt build/install/embree
# OSPRay is Debug and thus redistributes only the debug TBB; the Release dependencies need the release TBB
artifact-path: build/install/ospray build/CMakeCache.txt build/*/build/CMakeCache.txt build/install/tbb build/install/embree

build-ubuntu2404-gcc:
uses: intel-innersource/libraries.devops.renderkit.workflows/.github/workflows/docker.yml@main
Expand Down Expand Up @@ -227,8 +221,8 @@ jobs:
with:
image: rockylinux:8
cmd: |
module load cmake
module load mpi/mpich-x86_64
export PATH=/usr/lib64/mpich/bin:$PATH
export LD_LIBRARY_PATH=/usr/lib64/mpich/lib:$LD_LIBRARY_PATH
PATH="$GITHUB_WORKSPACE/build/install/ospray/bin:$PATH" scripts/tests/run_tests.sh "$GITHUB_WORKSPACE" TEST_MPI
artifact-in: build-rocky8-mpi-mpich
artifact-out: test-rocky8-gcc-mpi-mpich-avx2
Expand Down Expand Up @@ -281,8 +275,8 @@ jobs:
image: rockylinux:8
runs-on: '"avx512"'
cmd: |
module load cmake/3.15.2
module load mpi/mpich-x86_64
export PATH=/usr/lib64/mpich/bin:$PATH
export LD_LIBRARY_PATH=/usr/lib64/mpich/lib:$LD_LIBRARY_PATH
export OIDN_DEFAULT_DEVICE=cpu
PATH="$GITHUB_WORKSPACE/build/install/ospray/bin:$PATH" scripts/tests/run_tests.sh "$GITHUB_WORKSPACE" TEST_MPI
artifact-in: build-rocky8-oidn-mpi
Expand All @@ -296,7 +290,6 @@ jobs:
with:
image: centos:8
cmd: |
module load cmake
mkdir buildtut
cd buildtut
cmake -D ospray_DIR=`echo $GITHUB_WORKSPACE/build/install/ospray/lib/cmake/ospray-*` ../apps/ospTutorial/ospTutorialFindospray
Expand Down Expand Up @@ -390,8 +383,8 @@ jobs:
with:
image: rockylinux:8
cmd: |
module load cmake/3.15.2
module load mpi/mpich-x86_64
export PATH=/usr/lib64/mpich/bin:$PATH
export LD_LIBRARY_PATH=/usr/lib64/mpich/lib:$LD_LIBRARY_PATH
scripts/tests/run_tutorials.sh TEST_MPI
artifact-in: build-rocky8-oidn-mpi

Expand All @@ -402,8 +395,9 @@ jobs:
image: archlinux:latest
cmd: |
export PATH=$GITHUB_WORKSPACE/build/install/ospray/bin:$PATH
export LD_LIBRARY_PATH=$GITHUB_WORKSPACE/build/install/embree/lib:$GITHUB_WORKSPACE/build/install/ospray/lib:$LD_LIBRARY_PATH
export LD_LIBRARY_PATH=$GITHUB_WORKSPACE/build/install/tbb/lib/intel64/gcc4.8:$GITHUB_WORKSPACE/build/install/embree/lib:$GITHUB_WORKSPACE/build/install/ospray/lib:$LD_LIBRARY_PATH
export TBB_ENABLE_SANITIZERS=1
export ASAN_OPTIONS=intercept_tls_get_addr=0 # WA google/sanitizers#1322
scripts/tests/run_tests.sh $GITHUB_WORKSPACE
artifact-in: build-linux-debug

Expand All @@ -414,8 +408,9 @@ jobs:
image: archlinux:latest
cmd: |
export PATH=$GITHUB_WORKSPACE/build/install/ospray/bin:$PATH
export LD_LIBRARY_PATH=$GITHUB_WORKSPACE/build/install/embree/lib:$GITHUB_WORKSPACE/build/install/ospray/lib:$LD_LIBRARY_PATH
export LD_LIBRARY_PATH=$GITHUB_WORKSPACE/build/install/tbb/lib/intel64/gcc4.8:$GITHUB_WORKSPACE/build/install/embree/lib:$GITHUB_WORKSPACE/build/install/ospray/lib:$LD_LIBRARY_PATH
export TBB_ENABLE_SANITIZERS=1
export ASAN_OPTIONS=intercept_tls_get_addr=0 # WA google/sanitizers#1322
build/install/ospray/bin/ospBenchmark --benchmark_min_time=0s
artifact-in: build-linux-debug

Expand All @@ -426,7 +421,12 @@ jobs:
image: archlinux:latest
cmd: |
export PATH=$GITHUB_WORKSPACE/build/install/ospray/bin:$PATH
export LD_LIBRARY_PATH=$GITHUB_WORKSPACE/build/install/embree/lib:$GITHUB_WORKSPACE/build/install/ospray/lib:$LD_LIBRARY_PATH
export LD_LIBRARY_PATH=$GITHUB_WORKSPACE/build/install/tbb/lib/intel64/gcc4.8:$GITHUB_WORKSPACE/build/install/embree/lib:$GITHUB_WORKSPACE/build/install/ospray/lib:$LD_LIBRARY_PATH
export TBB_ENABLE_SANITIZERS=1
# Open MPI binary-patches mmap, which under ASan ends in SIGILL
export OMPI_MCA_memory=^patcher
export OMPI_MCA_opal_common_ucx_opal_mem_hooks=0
export ASAN_OPTIONS=intercept_tls_get_addr=0 # WA google/sanitizers#1322
export LSAN_OPTIONS=suppressions=$GITHUB_WORKSPACE/scripts/tests/sanitize_ignore.txt
OMPI_ALLOW_RUN_AS_ROOT=1 OMPI_ALLOW_RUN_AS_ROOT_CONFIRM=1 scripts/tests/run_tests.sh $GITHUB_WORKSPACE SKIP_CPU TEST_MPI
artifact-in: build-linux-debug
Loading
Loading