Repository navigation
Expose report and dataset operations through OCS - #609
Merged
Merged
Conversation
Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5
Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5
Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5
Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5
Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add versioned OCS endpoints in the existing ApiController for report listing, metadata and saved-filter data, owned dataset listing, and adding/updating or deleting dataset rows. Existing non-OCS URLs and payloads remain compatible.
Report reads include user, group and folder shares and reuse the viewer backend pipeline for saved filters, variables, sorting and transformations. Metadata excludes connection settings and share secrets. Public-link-only and panorama-only access are excluded; browser-side formatting and pivots remain client-side.
Dataset operations delegate directly to the existing V3 list and V4 write handlers, preserving ownership checks, validation, version updates and notifications. Writes require owned legacy datasets; flexible datasets retain the stable-column record API. V4 application errors remain success=false inside ocs.data with HTTP 200, as documented in openapi.json and the API guide.
Validation: 229 unit tests / 733 assertions passed. Live local Nextcloud checks covered report listing/metadata/data, authentication and missing-report errors, the unchanged V3 list, OCS dataset listing and both writes rejecting an inaccessible dataset. Successful dataset writes and shared access were not exercised live. OpenAPI JSON and schema references checked; no full OpenAPI validator run.
No duplicate Moment/dependency changes or unrelated Composer constraint edit included.
Assisted-by: Codex:GPT-5