Skip to content

Close a parent issue automatically when all its sub-issues are closed (job in rbs.yml) - #411

Closed
Trosper3 wants to merge 1 commit into
ReduxAPI_GUIfrom
ci/close-finished-parents
Closed

Trosper3 wants to merge 1 commit into
ReduxAPI_GUIfrom
ci/close-finished-parents

Conversation

@Trosper3

Copy link
Copy Markdown
Contributor

Lets a parent issue in this repo close itself once all its sub-issues are closed, using the shared workflow in Redux_Build_System. It's a second job in rbs.yml, so no workflow file is added.

Features

  • rbs.yml gains a close-parents job that calls ReduxISU/Redux_Build_System/.github/workflows/close-finished-parents.yml@main. It closes this repo's open issues labeled close-when-subissues-done once all their sub-issues are closed. Unlabeled issues, trackers included, are never touched.
  • New triggers: an issue closing, hourly (for sub-issues in other repos), and on demand. These run only close-parents. build-test still runs only on pushes and PRs.
  • The concurrency group adds the event name, so an hourly run can't cancel a push run on the same branch.

Same change as ReduxISU/Redux#950. Merge ReduxISU/Redux_Build_System#10 first: this calls its @main.

… rbs.yml

Adds a close-parents job that calls the shared close-finished-parents workflow in
Redux_Build_System on an issue closing and hourly. build-test still runs only on
pushes and PRs, so no workflow file is added.
@Trosper3

Copy link
Copy Markdown
Contributor Author

The rbs check fails at startup ("workflow file issue") until ReduxISU/Redux_Build_System#10 merges. GitHub checks every workflow rbs.yml calls before starting a run, and close-finished-parents.yml isn't on rbs main yet. I confirmed the file is valid by pointing it at the rbs PR branch for one run on ReduxISU/SPADE#50: build-test ran and close-parents was skipped, as intended. Then I reverted that. After #10 merges, re-run the rbs check here.

@Trosper3
Trosper3 marked this pull request as draft October 28, 2026 05:02
@Trosper3

Copy link
Copy Markdown
Contributor Author

Marked as draft until ReduxISU/Redux_Build_System#10 merges. Merging this first would make every rbs run in this repo fail at startup, because the shared workflow it calls wouldn't exist yet. Once #10 is in, I'll mark this ready and re-run the check.

@Trosper3
Trosper3 marked this pull request as ready for review October 28, 2026 05:08
@Trosper3 Trosper3 closed this Oct 28, 2026
@Trosper3 Trosper3 reopened this Oct 28, 2026
@github-actions

Copy link
Copy Markdown

Redux Build System — CI Report

npm · commit 0358d07

Operation Status Summary Time
audit ✅ no known vulnerabilities 0.5s
format-check ✅ 1 advisories 0.4s
lint ✅ 34 warnings 7.7s
typecheck ⏭️ no tsconfig.json —
unit-test ⏭️ no test script in package.json —
build ✅ built local/redux_gui:ci · 341MB 60.4s
integration-test ✅ /api/health ready · 15 passed 16.6s
push ⏭️ only on push to ReduxAPI_GUI —

Overall: ✅ 5 passed · 0 failed · 3 skipped

✅ format-check — 1 advisories
Severity Location Rule Message
info biome.json deserialize The configuration schema version does not match the CLI version 2.5.15
✅ lint — 34 warnings
Severity Location Rule Message
warning components/ContributorCard.js:16 @next/next/no-img-element Using <img> could result in slower LCP and higher bandwidth. Consider using <Image /> from next/image or a custom image loader to aut…
warning components/Visualization/svgs/No_Viz_SVG.js:4 no-unused-vars 'useContext' is defined but never used. Allowed unused vars must match /^_/u.
warning components/Visualization/svgs/StandardCircuitSvgReact.js:47 no-unused-vars 'url' is defined but never used. Allowed unused args must match /^_/u.
warning components/Visualization/svgs/StandardCircuitSvgReact.js:49 no-unused-vars 'gadgetMap' is defined but never used. Allowed unused args must match /^_/u.
warning components/Visualization/svgs/StandardCircuitSvgReact.js:50 no-unused-vars 'gadgetsOn' is defined but never used. Allowed unused args must match /^_/u.
warning components/Visualization/svgs/StandardGraphSvgReact.js:259 no-unused-vars 'simulation' is assigned a value but never used. Allowed unused vars must match /^_/u.
warning components/Visualization/svgs/StandardGraphSvgReact.js:318 no-unused-vars 'setCharge' is assigned a value but never used. Allowed unused vars must match /^_/u.
warning components/Visualization/svgs/StandardSATSvgReact.js:21 no-unused-vars 'error' is defined but never used.
warning components/Visualization/svgs/StandardSATSvgReact.js:3 no-unused-vars 'useContext' is defined but never used. Allowed unused vars must match /^_/u.
warning components/Visualization/svgs/StandardSATSvgReact.js:3 no-unused-vars 'useState' is defined but never used. Allowed unused vars must match /^_/u.
warning components/eventHandlers/handleUnload.js:6 no-unused-vars 'data' is assigned a value but never used. Allowed unused vars must match /^_/u.
warning components/hooks/ProblemProvider/Reducer.js:1 no-unused-vars 'React' is defined but never used. Allowed unused vars must match /^_/u.
warning components/hooks/ProblemProvider/Reducer.js:9 no-unused-vars 'useGenericInfo' is defined but never used. Allowed unused vars must match /^_/u.
warning components/hooks/ProblemProvider/Solver.js:1 no-unused-vars 'React' is defined but never used. Allowed unused vars must match /^_/u.
warning components/hooks/ProblemProvider/Verifier.js:1 no-unused-vars 'React' is defined but never used. Allowed unused vars must match /^_/u.
warning components/hooks/ProblemProvider/index.js:7 no-unused-vars 'React' is defined but never used. Allowed unused vars must match /^_/u.
warning components/pageblocks/ProblemRowReact.js:11 no-unused-vars 'useContext' is defined but never used. Allowed unused vars must match /^_/u.
warning components/pageblocks/ProblemRowReact.js:37 no-unused-vars 'ACCORDION_FORM_TWO' is assigned a value but never used. Allowed unused vars must match /^_/u.
warning components/pageblocks/SolveRowReact.js:11 no-unused-vars 'useContext' is defined but never used. Allowed unused vars must match /^_/u.
warning components/pageblocks/VerifyRowReact.js:11 no-unused-vars 'useContext' is defined but never used. Allowed unused vars must match /^_/u.
… and 14 more

@Trosper3

Trosper3 commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Closing this: we decided to close parent issues by hand, since each one gets checked before it closes anyway. Removing the automatic job everywhere instead (Redux_Frontend and Redux_Build_System get small removal PRs).

@Trosper3 Trosper3 closed this Nov 4, 2026
@Trosper3
Trosper3 deleted the ci/close-finished-parents branch November 4, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant