Skip to content

Update .coderabbit.yaml to exclude thirdparty/** via path filters - #1529

Merged
Arctis-Fireblight merged 1 commit into
Redot-Engine:masterfrom
Arctis-Fireblight:code-rabbit-config-update
Oct 18, 2026
Merged

Arctis-Fireblight merged 1 commit into
Redot-Engine:masterfrom
Arctis-Fireblight:code-rabbit-config-update

Conversation

@Arctis-Fireblight

@Arctis-Fireblight Arctis-Fireblight commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Excludes the thirdparty folder from Coderabbit's reviews.

The code in this folder isn't really our's to maintain outside of updating it periodically.
Having Coderabbit review it effectively just wastes our 300 files per PR limit for no real gain.

Summary by CodeRabbit

  • Chores
    • Excluded files under thirdparty/ from automated code reviews.

@Arctis-Fireblight Arctis-Fireblight self-assigned this Oct 18, 2026
@Arctis-Fireblight
Arctis-Fireblight requested review from a team October 18, 2026 09:15
@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

This pull request changes a CodeRabbit configuration file. Because it comes from a fork or its author is not a repository collaborator, reviews use only the configuration from the target branch. The proposed configuration will take effect after it is merged.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Redot-Engine/redot-engine/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: aa1ace3f-cc1e-4991-b5dd-70e33da1ba4b
📥 Commits

Reviewing files that changed from the base of the PR and between ca51bac and 12c1d93.

📒 Files selected for processing: 1
  • .coderabbit.yaml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The CodeRabbit configuration adds a path filter that excludes files under thirdparty/ from review.

Changes

Review path filtering

Layer / File(s) Summary
Exclude third-party paths
.coderabbit.yaml
The path filter excludes paths matching thirdparty/**.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: decryptedchaos, joltedjon

Merge Risk: ⚪ Minimal · up to 12c1d

This change excludes third-party files from review while leaving other paths eligible. No concrete merge risk remains from the change.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely states that .coderabbit.yaml excludes thirdparty/** through path filters. It matches the main change.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Arctis-Fireblight

Copy link
Copy Markdown
Contributor Author

@coderabbitai Can you confirm that I made the change to your config file correctly?

I want to confirm that the thirdparty/ directory is excluded from future reviews, but I also want to make sure that this wont remove your existing default exclusion list.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
fd --hidden --max-depth 2 '^\.coderabbit\.ya?ml$' .
if [ -f .coderabbit.yaml ]; then
  cat -n .coderabbit.yaml
fi

Length of output: 911


⚙️ CodeRabbit configuration inspected

Length of output: 98183


🤖 web_search executed:

site.docs.coderabbit.ai path_filters default exclusions custom path filters override default excluded files

Length of output: 710


🤖 web_search executed:

CodeRabbit default exclusions path_filters built-in exclusions preserved custom filters default ignore list

Length of output: 1448


🤖 web_search executed:

site:docs.coderabbit.ai .coderabbit.yaml configuration pull request base branch configuration changes take effect

Length of output: 857


@Arctis-Fireblight The change is correctly placed and uses valid syntax. I checked .coderabbit.yaml, Lines 17–18:

reviews:
  path_filters:
    - "!thirdparty/**"
  • ! marks an exclusion.
  • thirdparty/** matches files under the repository-root thirdparty/ directory, including subdirectories.
  • You do not need an additional inclusion pattern.

I cannot fully confirm the default-exclusion behavior. The schema gives path_filters an empty-list default, but the documentation I retrieved does not establish whether custom filters preserve a separate built-in exclusion list. An empty default alone does not prove either behavior.

Also, the active configuration returned by the configuration check still shows path_filters: []. The file change is correct, but I cannot confirm that the new filter is active yet. Please retry the configuration check after the updated configuration is loaded.

You are interacting with an AI system.

@Arctis-Fireblight
Arctis-Fireblight merged commit d2f7642 into Redot-Engine:master Oct 18, 2026
19 checks passed
@Arctis-Fireblight
Arctis-Fireblight deleted the code-rabbit-config-update branch October 18, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant