Repository navigation
Test the untested paths; drop two unreachable helpers - #12
Merged
Merged
Conversation
Codecov reported 63 lines without coverage on main (96.64%). Tests now cover: the in-place marginal API, `message_passing_marginalrule!`, and its refusal of a rule with no in-place form; the result card's modes (messages and marginals under the default algorithm, marginals and both under another), its log scale computed from the inputs and its HTML rows of incoming log scales; a node given by a function and a rule for a node with no declaration; the two-argument forms of NodeSpec, RuleCoverage, DependenciesSpec, TargetDependencies, Drawing, RuleContext and NodeFunctionLogPdf; the coverage table's labels for parametric algorithms; a RuleNotFoundError for arguments that are not a RuleArgs; annotations with no store and a rule's annotations; a joint of four members and RuleArgs from its parts; interface_groups, selection_arity and a redefined node; the macros' errors for a malformed target or cluster member; and an undefined log scale from a fallback or a cause of an engine's own. `input_labels`, which nothing calls, and `logscale_source(::Nothing)`, which cannot be reached, since an undeclared log scale is never a number, are gone. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 96.64% 99.25% +2.60%
==========================================
Files 25 25
Lines 1878 1875 -3
==========================================
+ Hits 1815 1861 +46
+ Misses 63 14 -49 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codecov reported 63 lines without coverage on
main(96.64%). This adds tests for the reachable ones and removes two helpers nothing can reach. Locally, on Julia 1.13 with CI's variables, line coverage goes to about 98.4%.Newly tested
message_passing_marginalrule!, and its refusal of a rule with no in-place form (it had no test at all);message_passing_rule);NodeSpec,RuleCoverage,DependenciesSpec,TargetDependencies,Drawing,RuleContextandNodeFunctionLogPdf, and the coverage table's labels for parametric algorithms;RuleNotFoundErrorfor arguments that are not aRuleArgs;RuleArgsfrom its parts;interface_groups,selection_arity, a redefined node's registry entry;targetor cluster member; undefined log scales from a fallback or a custom cause.Removed
input_labels: no caller.logscale_source(::Nothing): unreachable, since an undeclared log scale is anUndefinedLogScale, never a number.Left untested, as defensive branches with no realistic input: a few fallbacks in
diagnostics.jl(an unmatched type description, a rule input naming no interface, a method lookup that cannot fail) andheldfor a cluster inrulespec.jl.No user-visible change, so no CHANGELOG entry.
🤖 Generated with Claude Code