Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This updates the UI of the
toolbox-search, primarily by moving the search field into the flyout.The field is now an
IPositionablepinned to the flyout's top edge, with a separator at the head of the flyout contents reserving room for it. It is a focusable node of the flyout's workspace, so focusing it does not leave the toolbox or close the flyout, and it persists when the flyout contents is updated (while typing).ToolboxCategoryagain, thecreateDom_,getId()andgetFocusableElement()overrides are gone.SearchFieldNodemakes the input a focusable node of the flyout's workspaceSearchFlyoutNavigatormakes the field the get focused when moving in from the toolbox. In a vertical flyout, it makes it so up/down can cycle between the field and blocks.repeatReason for Changes
The search field was created in place of the category's label, leading to weird behavior such as not being able to style the category and not being able to select text within the field.
Test Coverage
Five unit tests were added, checking that:
Documentation
README updated with details about keyboard navigation.
Additional Information
Claude helped with boiler-plate for new files and some of the initial implementation shape. It also wrote the tests. Every line of generated code was carefully reviewed, if not modified or completely re-written by me.