Repository navigation
1.18 - Backport typing notification fix to 1.18 - #6169
Open
kwvanderlinde wants to merge 5 commits into
Open
kwvanderlinde wants to merge 5 commits into
kwvanderlinde wants to merge 5 commits into
Conversation
Contributor
|
@kwvanderlinde as per the comment in Discord:
The failing check on "[Build Verification / macos-15 w/JDK 21 (pull_request)]" seems to be something else beyond the commits though. Can that check be run again? |
Collaborator
Author
|
Yeah, the ARM Mac runner has been a tad flaky. All good now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Backports #5907
Description of the Change
The typing notification was broken in 1.18, but the fix only applied to 1.19. This backports the fix in preparation for the 1.18.8 release.
Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
This change is