Repository navigation
build(deps): bump the github-actions group across 1 directory with 8 updates #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jussielo-amd
merged 4 commits into
main
from
dependabot/github_actions/github-actions-718658f54d
Oct 27, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f0feafc
build(deps): bump the github-actions group across 1 directory with 8 …
dependabot[bot] 0295e5a
ci: restore RUSTFLAGS=-D warnings lost in setup-rust-toolchain v2.0.0…
jussielo-amd fa74680
docs(ci): fix stale prek-action pin comment (non-blocking nit from re…
jussielo-amd dc457c5
docs(ci): explain why RUSTFLAGS=-D warnings is set and when to replac…
jussielo-amd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actions-rust-lang/setup-rust-toolchainv2.0.0 changes its defaults in a way that silently weakens this repo's warning-as-errors gate.v1.17.0's default
rustflagsinput is"-D warnings", applied globally viaRUSTFLAGSso everycargo build/cargo build --release/cargo nextest runin these workflows fails on any compiler warning, not just the ones under explicitcargo clippy -- -D warningssteps.v2.0.0 changes the
rustflagsdefault to""and instead defaultsbuild-warningsto"deny"(setsCARGO_BUILD_WARNINGS=deny). Per this PR's own bundled release notes, that mechanism "is a new variable supported by cargo 1.97+" (build.warnings, stabilized in Rust 1.97.0). This repo'srust-toolchain.tomlpinschannel = "1.96.0", and neither the workflows nor.cargo/config.tomlsetRUSTFLAGS/build.warningsexplicitly anywhere else.Net effect after merging as-is: on cargo 1.96,
CARGO_BUILD_WARNINGS=denyhas no effect, so the previous global "-D warnings" safety net disappears for every barecargo build/cargo build --release/cargo nextest run/cargo teststep across ci.yml, nightly.yml, release.yml, e2e-selfhosted.yml, demo-gifs.yml, and dependabot-manifests.yml (thecargo clippy ... -- -D warningssteps stay protected since they pass the flag explicitly). New warnings introduced in code paths clippy doesn't cover (the PR's own Windows-clippy-gap comment nearby notes such gaps exist) would compile silently instead of failing CI.Fix: either bump
rust-toolchain.toml's channel to 1.97+ sobuild-warnings: denyactually takes effect, or passrustflags: "-D warnings"explicitly to eachsetup-rust-toolchainstep to preserve the old behavior until the toolchain is bumped.