Repository navigation
Add Oath Wallet directly to the main wallet selector - #1816
OathWallet wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The Vercel check for Workflow status update (1 November, current commit |
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Oath users currently have to choose the generic WalletConnect option in QuickSwap. This adds Oath Wallet directly to the main Connect Wallet list using Web3Modal's supported
customWalletsconfiguration.Selecting Oath opens the existing WalletConnect QR screen with Oath's name, rounded blue logo and connection instructions. On mobile, Web3Modal can hand the pairing URI to the native iOS app through
oathwallet://wc?uri=…. The entry includes the official App Store link. It does not register an injected browser provider or claim an Android/browser-extension version.Scope
customWalletsis configured. This is the SDK's existing behavior; the full directory remains available through All Wallets.Validation
npm install --legacy-peer-depswith Node 20, matching the deployment workflow: passed; no lockfile changes.npm run build: passed with existing repository warnings.node scripts/test-oath-wallet.mjs: 2 tests passed against the installed SDK, covering custom-wallet registration and exact native URI round-trip with synthetic pairing data. Only CRA's SVG asset import is substituted; the SDK is not mocked.tsc --noEmitis not green: the repository's TypeScript 4.9 compiler reports 2,086 dependency parse diagnostics. The unchanged base commit produces identical output with the same dependencies. A focused check of the new metadata against installed SDK types passes with TypeScript 5.9.3.GitHub preview status: Vercel reports “Account is blocked.” The local production build passed; hosted preview availability requires the deployment account owner to resolve that restriction.
Physical iPhone pairing, session approval and transaction signing were not performed in this PR's validation. The native URL format was checked against Oath's current parser; the standard QuickSwap provider still negotiates optional chains, and only mutually supported networks/methods should be approved.
Reviewer steps
Oath: https://oathwallet.org · iOS: https://apps.apple.com/app/id6780187283