Skip to content

Add Oath Wallet directly to the main wallet selector - #1816

Open
OathWallet wants to merge 1 commit into
QuickSwap:masterfrom
OathWallet:codex/oath-wallet-direct-connection
Open

OathWallet wants to merge 1 commit into
QuickSwap:masterfrom
OathWallet:codex/oath-wallet-direct-connection

Conversation

@OathWallet

@OathWallet OathWallet commented Oct 29, 2026 •

Copy link
Copy Markdown

Oath users currently have to choose the generic WalletConnect option in QuickSwap. This adds Oath Wallet directly to the main Connect Wallet list using Web3Modal's supported customWallets configuration.

Selecting Oath opens the existing WalletConnect QR screen with Oath's name, rounded blue logo and connection instructions. On mobile, Web3Modal can hand the pairing URI to the native iOS app through oathwallet://wc?uri=…. The entry includes the official App Store link. It does not register an injected browser provider or claim an Android/browser-extension version.

Scope

  • Reuses the existing Web3Modal 4.2.1 / WalletConnect provider; no dependency, chain, transaction, RPC or signing changes.
  • Generic WalletConnect, installed wallets and the All Wallets directory remain accessible.
  • Web3Modal 4.2.1 suppresses its automatic recommended-wallet rows when customWallets is configured. This is the SDK's existing behavior; the full directory remains available through All Wallets.

Validation

  • npm install --legacy-peer-deps with Node 20, matching the deployment workflow: passed; no lockfile changes.
  • npm run build: passed with existing repository warnings.
  • node scripts/test-oath-wallet.mjs: 2 tests passed against the installed SDK, covering custom-wallet registration and exact native URI round-trip with synthetic pairing data. Only CRA's SVG asset import is substituted; the SDK is not mocked.
  • ESLint on both changed TypeScript files and formatting on the new source/test: passed.
  • Chrome against the production build: Oath is directly visible in the main selector; selecting it renders an Oath-labelled real pairing QR and instructions; returning and selecting generic WalletConnect renders its QR; All Wallets loads the existing directory.
  • Standalone tsc --noEmit is not green: the repository's TypeScript 4.9 compiler reports 2,086 dependency parse diagnostics. The unchanged base commit produces identical output with the same dependencies. A focused check of the new metadata against installed SDK types passes with TypeScript 5.9.3.

GitHub preview status: Vercel reports “Account is blocked.” The local production build passed; hosted preview availability requires the deployment account owner to resolve that restriction.

Physical iPhone pairing, session approval and transaction signing were not performed in this PR's validation. The native URL format was checked against Oath's current parser; the standard QuickSwap provider still negotiates optional chains, and only mutually supported networks/methods should be approved.

Reviewer steps

  1. Build/run with the existing WalletConnect project configuration and open Connect Wallet.
  2. Select Oath Wallet directly. Verify the rounded logo, Oath title, QR and phone-scanning instructions.
  3. Go back and verify generic WalletConnect and All Wallets still work.
  4. On an iPhone with Oath installed, verify the app handoff and review/approve a supported-network session before considering end-to-end pairing verified.

Oath: https://oathwallet.org · iOS: https://apps.apple.com/app/id6780187283

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T22:18:03.664934Z bc43a2a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@OathWallet

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@OathWallet

OathWallet commented Oct 29, 2026 •

Copy link
Copy Markdown
Author

The Vercel check for bc43a2a reports “Account is blocked.” Could the project owner restore the connected Vercel account and retry the preview when the restriction is resolved? The check has not supplied a build failure to fix in this contribution. Codex has now completed a clean review of the current commit; the earlier usage-limit blocker is resolved. Local validation and remaining device checks are documented in the PR description.

Workflow status update (1 November, current commit bc43a2a70b): the following GitHub Actions runs also report action_required. Could a maintainer authorize the relevant fork checks?

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: bc43a2a70b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant