Repository navigation
Conversation
An adjoint frame with (datatype, parameter) columns gives a Series of per-parameter gradients for each cell. _adjoint_array passed that Series straight to np.asarray(dtype=float), so forecast() raised "ValueError: setting an array element with a sequence." The frame path that Python-Ensemble-Toolbox#166 replaced joined them via _to_singlelevel_columns; the gradients are now joined in column order again. The per-cell lookup moves to _adjoint_block, and each member's (nd, nx) Jacobian is stacked row by row. Verification: - new test_per_parameter_adjoint_columns_are_joined_into_one_gradient fails on 0a46451 with the ValueError above and passes here - test_adjoints.py, test_assimilation_pipeline.py, test_minires_sim.py pass - synthetic comparison against the first version of the fix: identical arrays, scaled and unscaled, single- and two-level columns Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rolfjl
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An adjoint frame with (datatype, parameter) columns gives a Series of per-parameter gradients for each cell. _adjoint_array passed that Series straight to np.asarray(dtype=float), so forecast() raised "ValueError: setting an array element with a sequence." The frame path that #166 replaced joined them via _to_singlelevel_columns; the gradients are now joined in column order again. The per-cell lookup moves to _adjoint_block, and each member's (nd, nx) Jacobian is stacked row by row.
Verification: