Repository navigation
+conda recipe to install on windows - #173
Merged
Merged
Conversation
rolfjl
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PET cannot currently be installed on Windows with
piporuvbecause ofgraphite-mapsand its dependencies: PET's EnIF analysis depends ongraphite-maps, which in turn needsscikit-sparseand the CHOLMOD C library. Neither package has a Windows build on PyPI; conda-forge providesscikit-sparseand CHOLMOD ready-made.import piptloads EnIF unconditionally, so this affects every PET run on Windows.What this PR adds
environment.yml: a recipe to install PET and its environment withconda:docs/installation_windows.md: prerequisites, install and check commands,and the pitfalls found along the way.
A Windows note in the EnIF tutorial, a nav entry in
mkdocs.yml, and achangelog entry.
README: Installation is split into "On Linux" and "On Windows".
No changes to
src/orpyproject.toml.Testing
On Windows 11 with Miniforge, in an environment built from
environment.yml:import piptandfrom sksparse.cholmod import choleskysucceed.tests/assimilation/test_enif.pypass.pytest -m "not slow": 583 passed, 6 failed, 2 skipped.The six failures are not installation problems:
tests/assimilation/test_subspace2.pycompare two analyses bitfor bit; on Windows they differ in the last floating-point digit (~1e-16).
tests/test_logging_and_paths.py::test_save_folder_is_not_created_by_reading_itexpects a
/path separator and gets\.Not tested: building the environment on Linux (its conda packages do resolve
for
linux-64), and rendering the docs with mkdocs.🤖 Generated with Claude Code, edited by @alex11818