Repository navigation
CI: bump build-and-inspect-python-package to v3.0.1 (fix failed v0.13.0 deploy) - #272
Merged
Merged
Conversation
The v0.13.0 deploy run failed in the "Check PyPI README" step (`twine check --strict`) with: InvalidDistribution: Invalid distribution metadata: '2.5' is not a valid metadata version pyproject.toml does not pin hatchling, so the build picked up hatchling 1.32.x, which writes Metadata-Version 2.5. The action's v2 line bundles twine 6.2.0 / packaging 26.2, which do not know 2.5. v3.0.0 of the action ships Twine 7 with metadata 2.5 support. The action no longer force-moves major tags, so pin the full commit SHA. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Not up to standards ⛔
|
mrava87
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The deploy run for v0.13.0 failed: https://github.com/PyLops/pyproximal/actions/runs/37135819955/job/111240026958
The wheel built fine, but the Check PyPI README step (
twine check --strict) inhynek/build-and-inspect-python-package@v2failed with:Root cause
pyproject.tomldoes not pinhatchling, so the build used the latest release (1.32.4), which writesMetadata-Version: 2.5.twine==6.2.0/packaging==26.2, which do not recognise metadata 2.5.2.4; 1.32.4 emits2.5. (1.32.0-1.32.3 not tested.)Fix
Bump the action to v3.0.1. v3.0.0 updates its build dependencies, including Twine 7, which adds support for metadata 2.5. As of v3 the action no longer force-moves major/minor tags, so it is pinned to the full commit SHA (
2abe76d…, the commit behind thev3.0.1tag).This keeps hatchling unpinned. The alternative was
hatchling < 1.32inbuild-system.requires, which would be a workaround to remove later.Not verified yet
I have not run the new action. After merging,
workflow_dispatchonPyProximal-deployruns only the build job and will confirm the check passes.Releasing afterwards
The release workflow builds the commit the tag points to, so v0.13.0 needs to be re-tagged on a commit containing this fix (or the release re-published) for the deploy to succeed.
🤖 Generated with Claude Code