Repository navigation
Type Packet.stream as StreamT | None - #2475
Merged
Merged
Conversation
Packets that weren't demuxed or encoded by a stream, such as `Packet()` or those from `CodecContext.encode` and `parse`, have no stream. The setter still requires a stream; assigning `None` raises `TypeError`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packet.streamisNonefor packets that weren't demuxed or encoded by a stream:Packet(),Packet(b"..."), and packets fromCodecContext.encode/parse. The stub claimed it was always set.StreamT | NoneStreamT; assigningNoneraisesTypeErrorat runtimeDemuxed packets always have a stream, so code reading
packet.streamnow needs to narrow it. In this repo that was two spots intests/test_streams.py(one now usespacket.stream_index);examples/mypy output is unchanged.