Repository navigation
Conversation
Each generated test in `tests/test_doctests.py` closed over the loop variable, so every test in a class ran the same doctest and most doctests never ran. Bind it as a default argument. That exposed the `code_to_tag` doctest failing: the finder stripped the `b` prefix from expected output, a Python 2 leftover. Remove it. Sphinx autodoc executes the `.pyi` stubs, which now subscript `Packet`, so the docs doctests failed with "type 'av.packet.Packet' is not subscriptable". Add `Packet.__class_getitem__` to match the stub's `Generic[StreamT]`.
WyattBlue
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/test_doctests.pyclosed over the loop variable, so every test in a class ran the module's last doctest — 9 of 16 doctests never ran. Bind it as a default argument.code_to_tagdoctest failing: the finder stripped thebprefix from expected output, a Python 2 leftover. Remove it..pyistubs, which now subscriptPacket(Enable mypy strict mode #2472), somake -C docs testfailed 12/12 with "type 'av.packet.Packet' is not subscriptable". AddPacket.__class_getitem__to match the stub'sGeneric[StreamT]; this also makesav.Packet[VideoStream]usable in runtime-evaluated annotations.