Repository navigation
Conversation
Member
|
This is a good enough trade-off, but we should make CodecContext generic over the frame type eventually. |
Contributor
Author
|
Thanks for the quick review.
Yea good idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #2447, there are currently quite a lot of stubtest errors in
av, i.e. mismatches between the runtime API and the stubs, 267 to be exact.This resolves 10 of those errors, bringing down the total to 267.
For completeness' sake, here are the exact stubtest errors (reported with the
--conciseflag, because, well, it's more concise):Those duplicate
@finaland@disjoint_baseerrors are a bit weird, but both disappear when@finalis applied (which kinda makes sense, since@finalis essentially a stricter variant of@disjoint_base, but still, IMO stubtest should've only complained about@finalhere).