Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Pin Uno.Sdk exactly to
7.0.0-dev.81and migrate Prism Uno to the .NET 10 assets supported by Uno 7. Match explicit Hosting/Markup references to that SDK's package manifest and let the SDK select its other companion packages, removing obsolete Uno 6 rendering package pins. Use the Uno 7 XAML behaviors package and migrate the sample's EventTriggerBehavior namespace while preserving Prism package and public API identities. Migrate the Android sample to the Uno 7 runtime namespaces andCreateHost()host builder.Document this release's specific N-1 exception: Uno 7 is expected to ship alongside Prism, and its removal of native rendering changes Prism.Plugins packaging. The general policy is unchanged. Add global.json to the Uno CI path filter so SDK updates run the Uno build and tests.
Bugs Fixed
API Changes
None in Prism. Uno packages require .NET 10; .NET 9 Uno targets are removed because Uno 7 provides no .NET 9 assets. Consumers directly using the old behaviors package should migrate to
Uno.Microsoft.Xaml.Behaviors.Interactivity.WinUI4.x andMicrosoft.Xaml.Interactivity.EventTriggerBehavior.Behavioral Changes
Uno 7 renders Android, iOS/tvOS, desktop and browser apps through Skia. Existing platform targets remain; Windows continues to use WinAppSDK. The sample shares its framework list and allows scoped desktop validation using
PrismUnoSampleTargetFrameworks.Validation on macOS (.NET SDK 10.0.301):
dotnet build PrismLibrary_Uno.slnf -c Release '-p:UnoTargetFrameworks=net10.0%3Bnet10.0-desktop%3Bnet10.0-android%3Bnet10.0-ios'passed, including package generation for all three Uno libraries.dotnet build e2e/Uno/HelloWorld/HelloWorld.csproj -c Release -p:PrismUnoSampleTargetFrameworks=net10.0-desktop -p:UnoTargetFrameworks=net10.0-desktoppassed.dotnet build e2e/Uno/HelloWorld/HelloWorld.csproj -c Release -m:1 -nr:false -p:PrismUnoSampleTargetFrameworks=net10.0-android -p:UnoTargetFrameworks=net10.0-androidpassed, including Release APK packaging.Cloud validation on Linux (.NET SDK 10.0.100, isolated workspace):
Uno.Extensions.Hosting.WinUI8.0.0-dev.101 andMicrosoft.Windows.CsWinRT2.3.1 passedResolveReferencesfornet10.0-windows10.0.19041and selectedWinRT.Runtime, Version=2.3.1.0from CsWinRT's net9.0 assets. This confirms reference selection only; the Windows generator cannot run on Linux.Prism.Container.Abstractions10.0.94-pre is unavailable on nuget.org and no private feed is configured in this environment. No cloud test results are claimed.Upstream evidence: Uno 7 migration guide, Uno SDK package manifest, Uno XAML behaviors compatibility.
PR Checklist
Docs impact: README records the exact SDK and the specific support-policy exception; Uno sample follows the new behaviors namespace.