Repository navigation
fix(auth): JWT_AUTH_HTTPONLY=False so the refresh token reaches the client - #180
Merged
Merged
Conversation
…esh token dj-rest-auth 7.x defaults JWT_AUTH_HTTPONLY True with no refresh cookie configured, so the login response carries refresh:"" and the client can never renew its 5-minute access token. Explicit body mode matches the localStorage-based frontend; flips to True + cookies in the planned httpOnly migration.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live-stack catch #2 of the login chain: after #179 fixed USE_JWT, login returned refresh:"" — dj-rest-auth 7.x defaults JWT_AUTH_HTTPONLY=True which blanks the body refresh while no cookie is configured either, so token renewal was impossible after 5 minutes. Body mode restored; cookie migration (spec-gap G11) will flip deliberately. 499/499 green.