Skip to content

Add pipeline comment indentation regression tests - #2260

Merged
Christoph Bergmeister (bergmeister) merged 1 commit into
copilot/fix-psuseconsistentindentation-issuefrom
review-pr-2231-comment-tests
Oct 27, 2026
Merged

Christoph Bergmeister (bergmeister) merged 1 commit into
copilot/fix-psuseconsistentindentation-issuefrom
review-pr-2231-comment-tests

Conversation

Copilot AI commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

PR Summary

Add regression coverage for comment-run indentation with IncreaseIndentationForFirstPipeline and IncreaseIndentationAfterEveryPipeline. The test verifies nested comment offsets, expected indentation through a second pipeline stage, analyzer cleanliness, and formatter idempotence. This test-only follow-up targets the head branch of #2231.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking (test-only)
  • Existing test file copyright header is retained
  • Added regression tests
  • PR is ready to merge (draft; awaiting CI)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused test-only changes have no identified blocking issues, though CI results remain pending.

No open issues 🎉

What changed in this PR

Adds test-only regression coverage for pipeline comment indentation, extending #2231’s work to preserve relative indentation within comment runs.

Changes:

  • Covers IncreaseIndentationForFirstPipeline and IncreaseIndentationAfterEveryPipeline, including nested comment offsets and second-stage command indentation.
  • Verifies no analyzer violations, unchanged formatter output, and formatter idempotence.
File Description
Tests/​Rules/​UseConsistentIndentation.tests.ps1 Adds parameterized regression tests for comment-run indentation under both pipeline modes.

Review effort: Balanced

@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review October 27, 2026 18:34
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 27e6f68 into copilot/fix-psuseconsistentindentation-issue Oct 27, 2026
11 checks passed
@bergmeister
Christoph Bergmeister (bergmeister) deleted the review-pr-2231-comment-tests branch October 27, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants