[jnasbyupgrade]

Summary

• test_factory 0.5.0 has been the released, real-world-installed version since 2017 -- issue CREATE EXTENSION fails on PG16+ without a superuser (RDS/Aurora): must be able to SET ROLE "test_factory__owner" #14 itself describes a live production failure against it.
• Every edit to sql/test_factory.sql on fix/issue-14-clean got silently baked into sql/test_factory--0.5.0.sql too, via pgxntool's own auto-regeneration -- retroactively rewriting what "version 0.5.0" contains without ever bumping the version number.
• Restores sql/test_factory--0.5.0.sql to match upstream/master byte-for-byte (verified). The issue CREATE EXTENSION fails on PG16+ without a superuser (RDS/Aurora): must be able to SET ROLE "test_factory__owner" #14 fix itself stays intact in the base sql/test_factory.sql file, ready for whichever version eventually ships it -- that decision isn't made here.
• Confirmed release_status in META.in.json/META.json is already "stable" in both -- no change needed.

Stacked on #18 (issue-14-clean, pushed to this repo for that purpose) rather than a fork-to-fork PR.

Test plan

• diff confirms the restored file is byte-for-byte identical to upstream/master's version.
• make lint passes.
• N/A running the test suite here: restoring 0.5.0 to its true (unfixed) content is expected to reintroduce issue CREATE EXTENSION fails on PG16+ without a superuser (RDS/Aurora): must be able to SET ROLE "test_factory__owner" #14's original symptom for a non-superuser fresh install at that version -- that's the correct, intentional state until a new version is decided and cut.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 323ac63d-d92b-4635-a41b-12081d1285d4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

[github-actions]

Bug: this pattern also matches the update scripts the comment above it says are exempt.

The added comment states:

The update script to stable (sql/*--<last-release>--stable.sql) is not affected by this and must stay committed.

But in gitignore glob syntax * matches any run of characters except /, so sql/*--stable.sql also matches sql/test_factory--0.5.0--stable.sql (with * = test_factory--0.5.0) — the very file this PR adds. It's harmless right now only because that file is already tracked (git doesn't apply .gitignore to tracked paths), but the next release's analogous update script (e.g. sql/test_factory--0.6.0--stable.sql, or a future test_factory_pgtap one) would be silently skipped by git add, shipping a distribution with no upgrade path and no error anywhere.

A negation line after it fixes this — sql/*--*--stable.sql requires two separate ---delimited segments before stable.sql, so it matches only <ext>--<version>--stable.sql update scripts, not the single-segment <ext>--stable.sql files this rule is meant to ignore:

Suggested change

	sql/*--stable.sql
	sql/*--stable.sql
	!sql/*--*--stable.sql

[github-actions]

Bug: default_version moves to 'stable' here, mirroring test_factory.control, but unlike test_factory.control (which gets sql/test_factory--0.5.0--stable.sql in this same PR), there's no corresponding sql/test_factory_pgtap--0.1.0--stable.sql anywhere in this diff.

PostgreSQL's ALTER EXTENSION ... UPDATE requires a literal sql/<extension>--<from>--<to>.sql script to move between two specific versions — there's no fuzzy/partial matching. Any existing test_factory_pgtap 0.1.0 install (the version that has shipped since this extension's only release) would fail ALTER EXTENSION test_factory_pgtap UPDATE with "no update path from version "0.1.0" to version "stable"".

This isn't caught by the test suite: test/install/load.sql's update-mode branch installs test_factory_pgtap fresh (at stable directly) rather than updating it from 0.1.0, so the missing path is never exercised.

Fix: add a sql/test_factory_pgtap--0.1.0--stable.sql script (can be a no-op, since no pgtap-side objects changed) mirroring what this PR already did for test_factory.

[jnasbyupgrade]

Superseded: the versioning-hygiene fix moved to #42 (merged, standalone against master). The remaining genuinely-needed content (the real GRANT-fix update script, and the load.sql update-mode role restructuring) has been folded directly into #18.