Repository navigation
Add make-variable inventory test; follow internal test-gate renames - #97
Merged
jnasbyupgrade merged 5 commits intoOct 7, 2026
Conversation
Paired with pgxntool commit f005e16, which renames the stub seam _CHECK_TEST_INSTALL_ERROR_STOP_SCRIPT to follow the _PGXNTOOL_ prefix convention for internal plumbing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Paired with pgxntool commit 9b5a39a, which renames check-stale-expected and check-test-install-error-stop to _check-stale-expected and _check-test-install-error-stop. make-variables.bats enumerates every variable pgxntool's *.mk files define (from make's own -p database) and fails on any that test/lib/pgxntool-variables.txt doesn't classify as api, internal, legacy or external. It also fails on stale entries and on names that don't match their class's prefix rule. It needs pg_config, but no foundation env and no running Postgres. CLAUDE.md: add bin/version to the user-invoked scripts in the API surface. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-install-error-stop-script
make -p labels an 'override' assignment's origin differently from a plain one, so PGXNTOOL_VERIFY_RESULTS_MODE dropped out of the inventory once it started being set via override. Classify the new _pgxntool_validate_choice helper as internal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jnasbyupgrade
added a commit
to Postgres-Extensions/pgxntool
that referenced
this pull request
Oct 7, 2026
…ets (#130) Rename the internal pieces of the test/install and stale-expected gates so their names mark them as internal, matching the `_PGXNTOOL_` convention Related pgxntool-test PR: Postgres-Extensions/pgxntool-test#97 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related pgxntool PR: Postgres-Extensions/pgxntool#130
Add
test/standard/make-variables.bats, which lists every make variable pgxntool's*.mkfiles define (from make's own-pdatabase, so no regex over base.mk) and checks it againsttest/lib/pgxntool-variables.txt.PGXNTOOL_*), internal (_PGXNTOOL_*), legacy (frozen pre-convention names) or external (PGXS/make-owned names pgxntool assigns).overrideassignment origins frommake -p, so a variable set viaoverride(e.g.PGXNTOOL_VERIFY_RESULTS_MODE) stays in the inventory.Also:
_PGXNTOOL_CHECK_TEST_INSTALL_ERROR_STOP_SCRIPT,_check-stale-expectedand_check-test-install-error-stopin make-test.bats and CLAUDE.mdbin/versionto CLAUDE.md's list of user-invoked scriptsMerge order: this follows a rename of names this repo's existing tests reference, so no single merge order is safe. Land it back-to-back with pgxntool#130, ideally before the next release.
Full suite against the paired branch: 307/307 passed, 0 skipped.
🤖 Generated with Claude Code