Repository navigation
Verify make pgtle produces output for both extensions - #104
Merged
jnasbyupgrade merged 1 commit intoOct 15, 2026
Merged
jnasbyupgrade merged 1 commit into
jnasbyupgrade merged 1 commit into
Conversation
The multi-extension test only checked that `make pgtle` exits 0. The `pgtle` recipe joins its per-extension pgtle.sh calls with `;`, so only the last extension's status reaches make: a failure (or a skipped extension) for ext_alpha still exits 0. Assert that at least one `pg_tle/<range>/` directory exists and that every range contains both `ext_alpha.sql` and `ext_beta.sql`. Fixes Postgres-Extensions#71 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/standard/multi-extension.batsis the only test that runsmake pgtlewith more than one extension, but it only checked that make exits 0.That exit status can't prove both extensions were processed: the
pgtlerecipe inbase.mkjoins its per-extensionpgtle.shcalls with;, so only the last extension's status reaches make. A failure or a dropped extension forext_alphastill exits 0.This adds inline assertions to the existing "make generates versioned SQL files" test:
pg_tle/<range>/directory exists, andext_alpha.sqlandext_beta.sql.Verified locally that each assertion fails when its case is forced (one
ext_alpha.sqlremoved;pg_tle/removed), and that the full suite passes.Fixes #71
🤖 Generated with Claude Code