Repository navigation
fix(email-offer): say the last key exits and ignore keys while hidden - #1591
Merged
Merged
Conversation
- After Yes, the screen says "Press any key to exit", since the offer is the run's last step. - While a too-small terminal hides the question, the picker is not mounted, so arrow keys can't move a highlight nobody sees; a key while the setup lines are hidden doesn't dismiss them. - The Workflows link needs an http(s) app host. - The fallback says to change into the app's directory first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
The hidden-setup test now shrinks and grows the terminal through ScreenContainer instead of injecting visibility, and checks the setup lines come back before the next key exits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… question The picker stays mounted with keys off while hidden, through a new `active` option on PickerMenu and useKeyBindings, so a resize no longer resets the highlight to Yes. The resize test now checks the host's exit request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ink detaches an inactive input listener in a passive effect, so a key sent on the first frame of the viewport notice still moved the hidden picker. The resize tests now go through the real screen container and press on that first frame. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ink's isActive attaches the listener a render late too, so a key on the first frame after the question came back was dropped. The listener now stays attached and only the handler checks active. The hidden-start test resizes the real screen container instead of setting the context. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The guard reset ran in a passive effect, so an Enter on the first frame after a long hide answered at once. It now runs in a layout effect. The resize test checks the restored highlight on its own, and a new test presses Enter on that first frame. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With color on, Ink puts escape codes between the highlight marker and the label, and inside the viewport notice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ignoring keys on a hidden picker needed a new option on the shared PickerMenu and useKeyBindings, and each fix to it found another timing gap. It goes back to main's behaviour and stays a known issue. The copy fix, the hidden setup lines, the link check and the leads stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Arrow keys can't move a highlight nobody can see, and the one-second guard restarts with the remounted picker. The shared PickerMenu and useKeyBindings stay as on main; the highlight resets to Yes after a resize. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The container rewrite dropped main's check that a question hidden after it showed takes neither Enter nor Esc. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Unmounting it while hidden let an Enter on the first hidden frame answer through the picker's last callback. The question keeps main's picker; a test now guards that a hidden Enter answers nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Silthus
marked this pull request as ready for review
November 20, 2026 13:04
PR overviewNo security issues were found in this pull request. Reviews
|
|
✅ Security review complete — No findings above the confidence threshold, in 6 min. Add the |
edwinyjlim
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #1508, the email provider question is the Wizard's last step, behind the flag
wizard-email-provider-offerat 0%. Four small rough edges are left, all listed as known issues on #1508:file:.Merge risk
Note
🔵 Merge risk: low · two-way door (merge-risk rubric)
wizard-email-provider-offeris on. The flag is at 0%, so merging changes nothing a user sees.--base-urlthat isn't http(s) now means no question, where feat(analytics): ask about the email provider after install #1508 asked and printed that link.emailSetupBlockinexit-line.ts), as the pinned walk shows.PickerMenuanduseKeyBindingsare as onmain.wizard-email-provider-offerto off.Tier: non-critical
Changes
EmailProviderOfferScreen): "Press any key to exit", the words other final screens use.workflowsUrlinemail-provider-offer.ts): only anhttp:orhttps:app host gets a link. Any other scheme means no question. The comment now credits clearing the user and password with dropping credentials.email-setup-command.ts): "Change into your app's directory, then run this:", and for a pinned run "…, then run this, adding the --base-url this run used:".Test plan
Gates on this branch:
pnpm typecheckgreen,pnpm lintwith no errors, and the full suite green at14cd2352.Each new row fails with
main's code:email-provider-offer.test.ts:file:///srv/posthogandjavascript:alert(1)as the pinned instance ask nothing.email-setup-command.test.ts: the pinned and non-plain fallback leads.EmailProviderOfferScreen.test.tsx: "Press any key to exit" after Yes.EmailProviderOfferScreen.test.tsx, through the real screen container and terminal resizes: after Yes, a key on the first hidden frame asks no exit, and the next key at 120x40 asks the host to exit with 0.Rows that guard
main's behaviour through the real container, and fail if it breaks:visiblecheck.Live walks at
14cd2352: real Wizard installs under a pty, flag on, against a sandbox app with Resend. Every run exited 0 and sent oneshownand oneanswered, withproviders: ["Resend"]. A non-web pinned instance can't be walked, because the install can't finish against it; unit tests cover it.main(Known issues), so Enter answeredyesx; back to 120x40;xx--base-url https://us.posthog.com; Enter;xKnown issues
Both are as on
main:LLM context
Agent context and decisions
Built by Claude Code, Claude Opus 5.5 (
claude-opus-5-5), as the follow-up to #1508.main, with both gaps under Known issues. Rejected: anactiveoption on the sharedPickerMenuanduseKeyBindings, where each review round found another timing gap; and unmounting the picker while hidden, which let an Enter on the first hidden frame answer unseen🤖 Generated with Claude Code
How did you test this code?
14cd23514cd23545549a6to14cd23514cd235Not checked: none recorded
Gaps: judge: The judge holds only on proof that a non-http(s) pinned host gets no offer. A live install cannot finish against a file: or javascript: host, so no walk can reach the question; email-provider-offer.test.ts:126 runs the real eligibility code on a completed-session fixture and fails on main. The conductor accepted this gap in d-02ded214, and the review, risk and quality questions pass., accepted by 🤖 agent 2026-11-20
Full receipt (PostHog team): https://artifacts.posthog.com/a/PVbqjAyGtw39eTxsC9Rdss