Skip to content

fix(wizard): ignore quoted aborts and scope migration analytics - #1575

Merged
edwinyjlim merged 1 commit into
mainfrom
codex/email-review-follow-up
Nov 18, 2026
Merged

edwinyjlim merged 1 commit into
mainfrom
codex/email-review-follow-up

Conversation

@sarahxsanders

Copy link
Copy Markdown
Collaborator

Problem

Linear Pi runs can stop on an [ABORT] example in a blockquote or code fence. The shared session store also parses email migration skill IDs to derive migrated_from.

Follow-up to #1507.

Changes

  • Read standalone program abort markers outside Markdown blockquotes and fenced code blocks. Continue to accept a reason on the line after a bare marker.
  • Derive migrated_from in the skill program. The runner applies program-provided analytics tags and clears them at the start of each invocation.

Test plan

  • Run the focused Pi, signal parsing, program runner, and analytics tests.
  • Run TypeScript typecheck and check formatting and lint on the touched files.
  • Build the CLI and run email --help.

@sarahxsanders
sarahxsanders requested a review from a team as a code owner November 18, 2026 15:34
@github-actions

Copy link
Copy Markdown

🧙 Wizard CI

Run the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands:

Test all apps:

  • /wizard-ci all

Test all apps in a directory:

  • /wizard-ci ai-observability
  • /wizard-ci basic-integration
  • /wizard-ci feature-flags
  • /wizard-ci mcp-analytics
  • /wizard-ci replay-vision
  • /wizard-ci revenue
  • /wizard-ci self-driving
  • /wizard-ci warehouse
  • /wizard-ci warehouse-seeded

Test an individual app:

  • /wizard-ci ai-observability/anthropic
  • /wizard-ci ai-observability/google-adk
  • /wizard-ci ai-observability/groq
Show more apps
  • /wizard-ci ai-observability/manual-capture
  • /wizard-ci ai-observability/openai
  • /wizard-ci ai-observability/openai-agents
  • /wizard-ci ai-observability/opentelemetry
  • /wizard-ci ai-observability/vercel-ai
  • /wizard-ci basic-integration/android
  • /wizard-ci basic-integration/angular
  • /wizard-ci basic-integration/astro
  • /wizard-ci basic-integration/django
  • /wizard-ci basic-integration/fastapi
  • /wizard-ci basic-integration/flask
  • /wizard-ci basic-integration/flutter
  • /wizard-ci basic-integration/javascript-node
  • /wizard-ci basic-integration/javascript-web
  • /wizard-ci basic-integration/laravel
  • /wizard-ci basic-integration/next-js
  • /wizard-ci basic-integration/nuxt
  • /wizard-ci basic-integration/python
  • /wizard-ci basic-integration/rails
  • /wizard-ci basic-integration/react-native
  • /wizard-ci basic-integration/react-router
  • /wizard-ci basic-integration/sveltekit
  • /wizard-ci basic-integration/swift
  • /wizard-ci basic-integration/tanstack-router
  • /wizard-ci basic-integration/tanstack-start
  • /wizard-ci basic-integration/vue
  • /wizard-ci feature-flags/django
  • /wizard-ci feature-flags/next-js
  • /wizard-ci mcp-analytics/custom-dispatcher
  • /wizard-ci mcp-analytics/go-sdk
  • /wizard-ci mcp-analytics/python-sdk
  • /wizard-ci mcp-analytics/ruby-sdk
  • /wizard-ci mcp-analytics/rust-sdk
  • /wizard-ci mcp-analytics/typescript-sdk
  • /wizard-ci replay-vision/javascript-node
  • /wizard-ci replay-vision/next-js
  • /wizard-ci replay-vision/react-vite
  • /wizard-ci revenue/stripe
  • /wizard-ci self-driving/astro
  • /wizard-ci self-driving/fastapi
  • /wizard-ci self-driving/nuxt
  • /wizard-ci self-driving/react-router
  • /wizard-ci self-driving/sveltekit
  • /wizard-ci warehouse/monorepo-env
  • /wizard-ci warehouse/multi-source-next
  • /wizard-ci warehouse/stripe-node
  • /wizard-ci warehouse/zero-source
  • /wizard-ci warehouse-seeded/next-stripe
  • /wizard-ci warehouse-seeded/next-stripe-declined

Test against a Context Mill branch:

  • /wizard-ci all context-mill:my-branch

Add context-mill:<branch> to any command above to pin the Context Mill branch. It defaults to main.

Results will be posted here when complete.

@veria-ai

veria-ai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

PR overview

No security issues were found in this pull request.

Reviews

@posthog-security-review-bot posthog-security-review-bot Bot added the security-review Request a security review label Nov 18, 2026
@posthog-security-review-bot

posthog-security-review-bot Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

✅ Security review complete — 8eae9216d36c

No findings above the confidence threshold, in 6 min.

Add the security-review label to run again on the latest commit.

@sarahxsanders

Copy link
Copy Markdown
Collaborator Author

/wizard-ci revenue/stripe

@wizard-ci-bot

wizard-ci-bot Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

🧙 Wizard CI Results

Trigger ID: bd3b92f
Workflow: View run

App Confidence PR YARA
revenue/stripe/stripe-next-js-saas-starter 5/5 #5227 (logs) ✓
revenue/stripe/stripe-saas-demo 5/5 #5226 (logs) ✓

Configuration

Setting Value
Wizard ref codex/email-review-follow-up
Context Mill ref main
PostHog ref master

Search for trigger ID bd3b92f in wizard-workbench PRs.

@posthog-security-review-bot posthog-security-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agent-driven security review - no findings.

@posthog-security-review-bot posthog-security-review-bot Bot removed the security-review Request a security review label Nov 18, 2026
@sarahxsanders

Copy link
Copy Markdown
Collaborator Author

/wizard-ci revenue/stripe/stripe-saas-demo context-mill:codex/revenue-preserve-checkout-reference

@wizard-ci-bot

wizard-ci-bot Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

🧙 Wizard CI Results

Trigger ID: 1a4a6a4
Workflow: View run

App Confidence PR YARA
revenue/stripe/stripe-saas-demo 5/5 #5228 (logs) ✓

Configuration

Setting Value
Wizard ref codex/email-review-follow-up
Context Mill ref codex/revenue-preserve-checkout-reference
PostHog ref master

Search for trigger ID 1a4a6a4 in wizard-workbench PRs.

@gewenyu99 gewenyu99 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥸 Reviewed by NotVincent, totally not Vincent. The real Vincent will review it separately. Probably slop, please disregard.

Two leftovers from #1507 that sit outside this diff:

I think five existing abort cases will still land on the busy handoff screen, because:

  • isRunFailure in src/tui/mint-failure.ts skips the handoff only for the codes in DECISIONS: AgentYaraViolation, AgentAbort, and DetectUnsupportedPlatform.
  • The abort cases in audit, upload-source-maps, self-driving, and web-analytics-doctor set DetectNoPosthogSdk, CliInteractiveRequired, or AuthMissingScope, and the linear runner puts the matched case's code on the outro.
  • Those runs show "The Wizard's a little busy" over the case's own message.
 const DECISIONS = new Set<string>([
   ErrorCodes.AgentYaraViolation,
   ErrorCodes.AgentAbort,
   ErrorCodes.DetectUnsupportedPlatform,
+  ErrorCodes.DetectNoPosthogSdk,
+  ErrorCodes.CliInteractiveRequired,
+  ErrorCodes.AuthMissingScope,
 ]);

I think wizard email will time out wizard_ask while the person sets up DNS records or a project secret key, because:

  • createSkillProgram has no askTimeoutMs option, so the run uses DEFAULT_ASK_TIMEOUT_MS, 5 minutes.
  • error-tracking and upload-source-maps set 30 minutes for the same kind of browser errand.
     estimatedDurationMinutes: 5,
     abortCases: TRANSACTIONAL_EMAIL_ABORT_CASES,
+    askTimeoutMs: LONGER_ASK_TIMEOUT_MS,
   }),

createSkillProgram needs to pass askTimeoutMs through to run for that line to work.

@edwinyjlim

Copy link
Copy Markdown
Member

we can address vincent's findings on a diff PR. it's an old bug

@edwinyjlim
edwinyjlim merged commit 0e1ea8c into main Nov 18, 2026
22 checks passed
@edwinyjlim
edwinyjlim deleted the codex/email-review-follow-up branch November 18, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants