Repository navigation
fix(wizard): ignore quoted aborts and scope migration analytics - #1575
Conversation
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
PR overviewNo security issues were found in this pull request. Reviews
|
|
✅ Security review complete — No findings above the confidence threshold, in 6 min. Add the |
|
/wizard-ci revenue/stripe |
🧙 Wizard CI ResultsTrigger ID:
Configuration
|
|
/wizard-ci revenue/stripe/stripe-saas-demo context-mill:codex/revenue-preserve-checkout-reference |
🧙 Wizard CI ResultsTrigger ID:
Configuration
|
gewenyu99
left a comment
There was a problem hiding this comment.
🥸 Reviewed by NotVincent, totally not Vincent. The real Vincent will review it separately. Probably slop, please disregard.
Two leftovers from #1507 that sit outside this diff:
I think five existing abort cases will still land on the busy handoff screen, because:
isRunFailureinsrc/tui/mint-failure.tsskips the handoff only for the codes inDECISIONS:AgentYaraViolation,AgentAbort, andDetectUnsupportedPlatform.- The abort cases in
audit,upload-source-maps,self-driving, andweb-analytics-doctorsetDetectNoPosthogSdk,CliInteractiveRequired, orAuthMissingScope, and the linear runner puts the matched case's code on the outro. - Those runs show "The Wizard's a little busy" over the case's own message.
const DECISIONS = new Set<string>([
ErrorCodes.AgentYaraViolation,
ErrorCodes.AgentAbort,
ErrorCodes.DetectUnsupportedPlatform,
+ ErrorCodes.DetectNoPosthogSdk,
+ ErrorCodes.CliInteractiveRequired,
+ ErrorCodes.AuthMissingScope,
]);I think wizard email will time out wizard_ask while the person sets up DNS records or a project secret key, because:
createSkillProgramhas noaskTimeoutMsoption, so the run usesDEFAULT_ASK_TIMEOUT_MS, 5 minutes.error-trackingandupload-source-mapsset 30 minutes for the same kind of browser errand.
estimatedDurationMinutes: 5,
abortCases: TRANSACTIONAL_EMAIL_ABORT_CASES,
+ askTimeoutMs: LONGER_ASK_TIMEOUT_MS,
}),createSkillProgram needs to pass askTimeoutMs through to run for that line to work.
|
we can address vincent's findings on a diff PR. it's an old bug |
Problem
Linear Pi runs can stop on an
[ABORT]example in a blockquote or code fence. The shared session store also parses email migration skill IDs to derivemigrated_from.Follow-up to #1507.
Changes
migrated_fromin the skill program. The runner applies program-provided analytics tags and clears them at the start of each invocation.Test plan
email --help.