Repository navigation
chore: revert version bump to re-run the 3.34.2 release - #365
Closed
marandaneto wants to merge 1 commit into
Closed
marandaneto wants to merge 1 commit into
marandaneto wants to merge 1 commit into
Conversation
This reverts commit 16decc9.
marandaneto
marked this pull request as ready for review
November 18, 2026 12:16
marandaneto
enabled auto-merge (squash)
November 18, 2026 12:16
PR overviewNo security issues were found in this pull request. Reviews
|
ioannisj
approved these changes
Nov 18, 2026
4 of 6 tasks
Member
Author
|
Replaced by #366. The default revert message quoted a skip-CI marker, which skipped CI here and would also skip the release workflow after a squash merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The 3.34.2 release did not finish (run).
posthog-ruby3.34.2 was pushed to RubyGems, but the step that waits for the gem to show up crashed with Bundler 4.1. #364 fixed that step. Because the failure stopped the job early:posthog-ruby3.34.2 has no git tag and no GitHub release.posthog-rails3.26.5 was never published. RubyGems still has 3.26.4.Re-running the failed run would not help. A re-run uses the workflow file from the commit that started the run, so it would still have the broken wait step. A manual run from
mainwould not help either. The version bump commit already deleted the changeset, so the workflow would find nothing to release.This PR reverts the version bump commit 16decc9. That brings back the
ruby-flags-explicit-geoip-defaultchangeset and sets the versions back toposthog-ruby3.34.1 andposthog-rails3.26.4. When it merges, the release workflow runs again with the fixed wait step:posthog-ruby3.34.2 andposthog-rails3.26.5.posthog-ruby3.34.2 is already on RubyGems and skips the push. It then creates the tag and GitHub release.posthog-rails3.26.5 is built, pushed, tagged, and released.💚 How did you test it?
git revert 16decc9applied cleanly on top ofmain.pnpm changeset status --verboseplansposthog-ruby3.34.2 andposthog-rails3.26.5, the same versions as the failed release.posthog-ruby3.34.2 and 404 forposthog-rails3.26.5. This matches what the publish step checks before it pushes.📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
posthog-railsby hand, so the release goes through the normal workflow and approval.posthog-rubychangeset. Otherwise the release would bump to 3.34.3 instead of finishing 3.34.2.