Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .sampo/changesets/frozen-deque-clean.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
pypi/posthog: patch
---

Keep `frozenset` and `deque` property values when cleaning events instead of replacing them with `None`.
11 changes: 11 additions & 0 deletions posthog/test/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import sys
import time
import unittest
from collections import deque
from contextlib import ExitStack
from unittest import mock
from dataclasses import dataclass
Expand Down Expand Up @@ -315,6 +316,16 @@ def test_clean_containers_and_invalid_dict_values(self):
"12345678-1234-5678-1234-567812345678",
]

assert utils.clean(
{
"frozenset": frozenset([Decimal("1.5")]),
"deque": deque([UUID("12345678123456781234567812345678")]),
}
) == {
"frozenset": [1.5],
"deque": ["12345678-1234-5678-1234-567812345678"],
}

bad_value = object()

def clean_or_raise(value):
Expand Down
4 changes: 2 additions & 2 deletions posthog/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import re
import threading
import time
from collections import defaultdict
from collections import defaultdict, deque
from dataclasses import asdict, is_dataclass
from datetime import date, datetime, timezone, timedelta
from decimal import Decimal
Expand Down Expand Up @@ -89,7 +89,7 @@ def clean(item):
return str(item)
if isinstance(item, (str, bool, numbers.Number, datetime, date, type(None))):
return item
if isinstance(item, (set, list, tuple)):
if isinstance(item, (set, frozenset, list, tuple, deque)):
return _clean_list(item)

item = _clean_pydantic_model(item)
Expand Down
Loading