Repository navigation
fix(mcp): don't tell agents to wait for a conversation_id - #1192
lucasheriques wants to merge 1 commit into
Conversation
Reword the `conversation_id` tool-argument description to match posthog-js: pass an id only if an earlier response included one, run the first call on its own, then reuse any id it returned. Why: under the carried-session guard (ADR-0013), calls that already carry a transport session or token never receive an id, so "do not issue parallel tool calls until you have it" made an obedient agent serialize every call. Tested: `pytest posthog/test/mcp` -> 659 passed, 10 skipped (mcp 1.30.0); `ruff format --check`, `ruff check` clean. Text checked equal to the agreed wording.
posthog-python Compliance ReportDate: 2026-11-05T13:13:01.646204+00:00 ✅ All Tests Passed!121/121 tests passed Capture_V1 Tests✅ 95/95 tests passed View Details
Capture_Ai Tests✅ 5/5 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
Feature_Flags_Local_Evaluation Tests✅ 4/4 tests passed View Details
|
SDK performance: posthog-python2 changes worth reviewing: 2 observed improvements. Flags require at least a 5% change in the median and all six pairs agreeing on direction. This is a noise filter, not proof of a performance change or a CI gate.
View all results
Values are medians of paired measurements. Not flagged does not mean unchanged. Unavailable means a measurement could not be provided, not zero. Estimated allocation measurements retain their instrumentation uncertainty. RSS measures the whole process, not just SDK allocations; observed peaks are sampled checkpoints. Paired ranges in the diagnostics describe variability, not confidence intervals. Each shard uses its own runner; compare Before PR against With PR within a row, not across shards. Compared 102 metric rows; 102 rows shown in all results. Omitted or shortened data remain in |
|
Superseded by #1191, which drops the parallel-call wait from the conversation_id description completely. |
💡 Motivation and Context
The injected
conversation_idargument description told agents "do not issue parallel tool calls until you have it". A request that already carries a transport session or a PostHog session token never receives a conversation id, because the carried-session guard skips minting. An agent that follows the old text would wait for an id that never arrives and make every call one at a time. A customer reported this on PostHog/posthog#119784.This is the Python twin of PostHog/posthog-js#5578, and the text is byte-identical. The wait is now limited to the first call's response. The guidance that makes correlation work stays: make the first call alone, reuse any id you got, and never invent one.
💚 How did you test it?
pytest posthog/test/mcpon mcp 1.30.0: 659 passed, 10 skipped. Tests reference the constant, so none assert the wording.📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Claude Code (Opus 5.5 lead, Sonnet 5.5 for the edit), directed by Lucas. The new text matches posthog-js exactly, so both SDKs advertise the same description.