Repository navigation
feat(flags): support known-absent property keys in local evaluation #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marandaneto
wants to merge
7
commits into
main
Choose a base branch
from
feat/flags-known-absent-property-keys
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
778a8c8
feat(flags): accept known-absent person and group property keys
marandaneto 9ac3f94
feat(laravel): forward known-absent property keys to flag evaluation
marandaneto 25264e0
fix(laravel): validate known-absent keys before the no-identity early…
marandaneto 337de46
fix(laravel): validate known-absent keys in the PostHog fake
marandaneto bbd3670
test(flags): cover unsupported operators in cohort leaves before know…
marandaneto 3692184
ci: upgrade the SDK test harness to 1.34.0
marandaneto dc196fe
test: accept the native jsonSerialize call count of newer PHP patch r…
marandaneto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "posthog-php": minor | ||
| "posthog-laravel": minor | ||
| --- | ||
|
|
||
| Flag evaluation methods take optional `personPropertyKeysKnownAbsent` and `groupPropertyKeysKnownAbsent` arguments listing property keys known to be absent. Local evaluation resolves a listed key without falling back to `/flags`: `is_not_set`, `is_not` and the `not_*` string operators match, and every other operator doesn't. A remote request carries the keys. A list over 1000 keys throws `InvalidArgumentException`. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2 · Use a major core release for incompatible method signatures
An application subclass overriding
Client::getFeatureFlag()or another changed non-final method with its existing signature now fails PHP's declaration compatibility check when loaded. Marking this releaseminordelivers that fatal error through existing Composer^4constraints, even without using the new arguments. Preserve override compatibility or select a major core bump.