Repository navigation
fix: preserve the compliance adapter retry delay defaults - #322
Merged
Merged
Conversation
Contributor
posthog-php-socket Compliance ReportDate: 2026-11-18T09:42:27.467734+00:00 ✅ All Tests Passed!47/47 tests passed Capture Tests✅ 30/30 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
Contributor
posthog-php-fork_curl Compliance ReportDate: 2026-11-18T09:42:32.787692+00:00 ✅ All Tests Passed!47/47 tests passed Capture Tests✅ 30/30 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
Contributor
posthog-php-lib_curl Compliance ReportDate: 2026-11-18T09:41:48.652710+00:00 ✅ All Tests Passed!47/47 tests passed Capture Tests✅ 30/30 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
This was referenced Nov 15, 2026
marandaneto
marked this pull request as ready for review
November 17, 2026 09:41
dustinbyrne
approved these changes
Nov 17, 2026
…1.1-20261115 # Conflicts: # .github/workflows/sdk-compliance.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The compliance adapter supplied
max_retries=3even when the harness omitted it. Translating that count into the SDK's backoff-duration option lowered the Retry-After ceiling to 800/801 ms, so all three consumers retriedRetry-After: 3too early.Preserve the native 10000 ms ceiling when
max_retriesis omitted. Keep explicit retry-count mappings unchanged and document their coupling to the delay ceiling. The retry-queue spec permits clamping Retry-After to the SDK's backoff ceiling. No divergence is introduced in the behavior changed here.Use published harness 1.32.0, with immutable reusable-workflow SHA
dde638562d33572b5c8ac3a2eafc98b92ffa2261. The Compose image, README and report-checker docstring match that release. All three consumer profiles retain the complete 30 capture and 17 flag cases. No filters, capabilities or advisory semantics change.This changes only compliance infrastructure, not production SDK code, the production Retry-After parser or public API. There is no changeset or SDK release intent. The earlier
noneintent was removed because this PR has no production-code changes.💚 How did you test it?
lib_curl,socketand foregroundfork_curl. A 429 withRetry-After: 3followed by 200 must flush successfully with exactly two requests at least 2.5 seconds apart. All three cases failed on the original adapter at about 0.8 seconds and passed with the original fix.PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s sdk_compliance_adapter -v: 17 tests passed, including the three default-backoff regressions and existing explicit retry-count 0/1/3 checks.memory_limit=1G. This result predates the harness-pin-only follow-up. Native production code is unchanged. Coverage was unavailable locally because the host has no coverage driver.5b86c69b8adff6803fbf363114bec9105098ac2cpassed isolated full-branch autoreview againstorigin/main(085df129048960b7763f05d6ddc33783909086fd), including a clean mandatory secret scan. No actionable findings.Hosted verification
All 27 latest hosted checks pass at
5b86c69b8adff6803fbf363114bec9105098ac2c. The actual downloaded reports from run 44058869193 all pass against published harness 1.32.0:lib_curlsocketfork_curlEach report independently passes the unchanged strict inventory checker, with 47 unique passing rows and no omissions or extra cases. Every hosted lane pulled the published V1 image digest
sha256:7eb6c62e2241ddd48a2dfb326652e7933cd2fe26e0ffcad98cd385d603b4eb82. TheRun testscommand succeeds and its failure-warning step is skipped in each lane, establishing actual process exit 0 rather than advisory green alone. No failing test was filtered, suppressed or rerun to hide a failure.The report-completeness jobs intentionally validate inventory rather than require every assertion to pass. Actual reports and harness exits must also be checked before claiming compliance is green.
📝 Checklist
Agent context
Human-driven, agent-assisted implementation and verification. The original adapter fix and its before/after transport evidence are preserved. This follow-up updates the published harness and removes the unnecessary non-release changeset. New commits are signed and pushed without rewriting history. The isolated Pi reviewer has tools disabled and retains the mandatory secret scan. Human review is required before merge.
Related PRs
Merged prerequisites: sdk-specs #223 and harness #112. Harness 1.32.0 is now published.
SDK follow-ups: iOS #1083, Elixir #253, Node #5747, Ruby #362.