Repository navigation
Conversation
…eck first Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a wizard branch:
Add Results will be posted here when complete. |
…t clicks are lost Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…handler exception Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…h report sections Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s a pixel for clicks Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ck condition Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…racking Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The click and open advice added after it kept conflicting across notes; a redesign as one rule per site class follows separately. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#486 merged before its last review fixes landed. With the skill on
main, a migrate-email run can still:openTracking.enable: falsecan follow the account's open tracking instead.enable: !recipient.optedOut, to a PostHog template that tracks every recipient's clicks.clickTracking, since the skill read that as overriding the account's open tracking too.clickson brings back a plain-text email's click counts. PostHog tracks only the links in the HTML part.Note
🔵 Merge risk: low, 🟡 once a release reaches people · two-way door at merge, one-way once a person applies the released skill's rewrites: the sends it rewrites stay in their app
clickson.Changes
sendgrid/mapping.md: each ofopenTrackingandclickTrackingwith a fixedenabledecides for itself, whatever the account's setting is. Each one the send doesn't set follows the account, even when it sets the other.3-inventory.md:click tracking set at run time.resend/account.mdandsendgrid/account.md: point to Step 3's exception for a site whose open events feed a webhook handler.7-rewrite.mdand9-report.md: a plain-text link the provider tracked, such as with SendGrid'senableText: true, counts no clicks in PostHog. Step 7 notes each such site, and the report names the loss and says turningclickson counts only HTML links.The first commit is
b5c3854..d43cc1dfrom #486's branch, cherry-picked ontomain. The next two fix the majors its review found. Later commits tried to fix the report's click and open advice sentence by sentence; each fix created a new conflict between notes, so the last commit restores the text of the third commit. That advice is being redesigned as one rule per site class in a follow-up.Known issues
context/skills/migrate-email/references/3-inventory.md:81: a site whose click tracking changes from send to send, such asenable: !recipient.optedOut, moves into the code with clicks off, but the plan doesn't keep the condition. The report's advice to turnclickson for safe links could then track recipients who opted out. Tracked as a follow-up.context/skills/migrate-email/references/sendgrid/account.md:33andresend/account.md:37: both guides keep a site whose open events feed a handler on its provider even when its open tracking is known off. Step 3 does that only when nobody knows. The site stays, so nothing breaks. Tracked in the same follow-up.context/skills/migrate-email/references/9-report.md:40: for a site that moves withopensoff and whose open events feed a webhook handler, the "Webhook handlers" section lists PostHog's opened event as the replacement, though that send records no opens. The text is onmainfrom feat(migrate-email): map provider tracking settings to tracking and sensitive #486. Tracked in the same follow-up.How I checked it
At
c3e3e47, withmainmerged atb4d7cd9(after #541). The two conflicts, in7-rewrite.md"Write down" and9-report.md's notes list, keep both sides:main's note on each retry the move removed, and this PR's plain-text click notes.vitest run scripts/plugins/tests scripts/lib/tests: 437 tests passed, andnode scripts/build.jspassed.Live run: headless Claude Code (Opus 5.5, high effort) ran the built
migrate-email-sendgridbundle end to end on a generated SendGrid Node.js app, with SendGrid's open and click tracking on and plain-text click tracking off:openTracking: { enable: false },clickTracking: { enable: true }tracking: { opens: false }: the fixed setting wins over the accountclickTracking: { enable: false }trackingfield: opens follow the accountclickTracking: { enable: !recipient.optedOut }click tracking set at run timenoted, never to a PostHog templateclickTracking: { enable: true, enableText: true }, links in HTML and plain textShadow diff from
main(b4d7cd9) toc3e3e47, both built fresh: only3-inventory.md,7-rewrite.md,9-report.md, the provideraccount.md, and SendGrid'smapping.mdin themigrate-email-resendandmigrate-email-sendgridbundles, plusmanifest.json, change; every other file is byte-identical.🤖 Agent context
Autonomy: Human-driven (agent-assisted)
claude-opus-5-5), as a worker in a T3 Code thread.mainand ran one review round atc3e3e47: its three majors are the Known issues above, or ask for a production-data check that doesn't apply to a skill that reads app code.🤖 Generated with Claude Code