Repository navigation
feat(migrate-email): map provider tracking settings to tracking and sensitive #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
221 commits
Select commit
Hold shift + click to select a range
f034ecd
fix(skills): ship a variant's own reference folder in its bundle
Silthus 177e741
refactor(skills): share the email sender setup as a partial
Silthus 8169d7e
feat(skills): add the migrate-email skill with a Resend variant
Silthus 5e019aa
fix(skills): keep migrate-email's summary values bare and define a site
Silthus 6e902dc
fix(skills): point migrate-email at the transactional email docs and …
Silthus 0286e23
fix(skills): check migrate-email's API access with the real tools and…
Silthus 0920218
refactor(skills): share the posthog-node client setup as a partial
Silthus 64a2397
feat(skills): move Resend sends to posthog-node in migrate-email
Silthus ad4b0c7
fix(skills): keep migrate-email from splitting sends or faking the ol…
Silthus b2965cc
fix(skills): handle suppressed recipients and dynamic subjects in mig…
Silthus f8f4fea
fix(skills): keep a suppressed copy address from passing as a sent email
Silthus 8dcd459
fix(skills): warn that retrying a send with a suppressed copy address…
Silthus 154e8f5
fix(skills): leave migratedFrom off the posthog-node client in migrat…
Silthus 9cd85f5
fix(skills): check that posthog-node has the code form before migrate…
Silthus 41ca66a
fix(skills): detect resend over smtp, stop without sends, and record …
Silthus 0e526b9
refactor(scripts): ship variant references through the local referenc…
Silthus e51df39
merge: feat/migrate-email-resend into feat/migrate-email-resend-cutover
Silthus 8c841cd
fix(skills): tie migrate-email's test send to its own events and repo…
Silthus 4ad8c6e
fix(skills): let migrate-email move on when DNS waits and read templa…
Silthus 020b877
merge: feat/migrate-email-resend into feat/migrate-email-resend-cutover
Silthus 8452a82
fix(skills): pin migrate-email's test start to the database clock and…
Silthus 53a190c
fix(skills): keep migrate-email's test clock uncached and report depe…
Silthus 50b5f27
fix(skills): keep migrate-email's chain query uncached on its rerun
Silthus 8f77354
fix(skills): keep cc, bcc, headers, tags and attachments sites on Res…
Silthus d871b8e
Merge feat/migrate-email-resend into feat/migrate-email-resend-cutover
Silthus b9d785e
Drop local templates and parked fields from the cutover steps
Silthus 5edeb92
feat(migrate-email): set migratedFrom on the posthog-node client
Silthus 64cf8ef
fix(migrate-email): ask for the PostHog template ID before a template…
Silthus 85f6096
fix(migrate-email): check each PostHog template and its sender before…
Silthus a759ff4
fix(migrate-email): ask about a repeat import and test a send that na…
Silthus 5c8a34b
fix(migrate-email): ask for the PostHog template ID and sender before…
Silthus e053dab
Merge feat/migrate-email-resend into feat/migrate-email-resend-cutover
Silthus efa4933
fix(skills): read Dirent.path when parentPath is missing in the migra…
Silthus 5e40f2a
Merge feat/migrate-email-resend into feat/migrate-email-resend-cutover
Silthus 2c36853
fix(migrate-email): match account.md's template-content rule to Step 3
Silthus 8dcf6e7
fix(migrate-email): keep a site on Resend when its idempotency key do…
Silthus 07dbf3a
fix(migrate-email): name PostHog's idempotency key rule exactly
Silthus a1376c0
Merge feat/migrate-email-resend into feat/migrate-email-resend-cutover
Silthus 21f683e
fix(migrate-email): end Step 8's email check when the person declines…
Silthus d157859
docs(migrate-email): say where a send without distinctId lands
Silthus 5dcdd21
docs(migrate-email): test Step 8 on a site that passes distinctId
Silthus 4fc8d41
docs(migrate-email): say why cc, bcc and attachments stay on Resend
Silthus 9664659
docs(migrate-email): name the real reason a field stays on Resend
Silthus 4e5a672
docs(migrate-email): give scheduled sends and topics a reason too
Silthus 8d88206
fix(migrate-email): keep a site on Resend when its key length is unbo…
Silthus 5863a99
fix(migrate-email): quote Resend fallbacks with single quotes only
Silthus eed16c6
fix(migrate-email): record the PostHog key as set only after a check …
Silthus 2d91936
fix(migrate-email): accept spaces around = in the key check
Silthus 074130e
fix(migrate-email): check the last assignment of the PostHog key
Silthus 5c92245
docs(migrate-email): ask for the transactional_email:write scope
Silthus f5080a7
Merge remote-tracking branch 'origin/feat/migrate-email-resend' into …
Silthus 254dbb9
fix(migrate-email): name the transactional email scope in the preflight
Silthus 464644f
Merge branch 'feat/migrate-email-resend' into feat/migrate-email-rese…
Silthus 4b0f257
feat(migrate-email): move Resend sends in every PostHog SDK's language
Silthus c4ed38c
fix(migrate-email): keep the app booting and check the whole project …
Silthus a658c75
fix(migrate-email): use the one Rust client the app's features build
Silthus cffc009
feat(migrate-email): carry posthog-sdks.md's rules into the rewrite f…
Silthus 6ab1cc2
Merge the migration lane's per-SDK rules into feat/migrate-email-all-…
Silthus f6b6af8
fix(migrate-email): check the merged SDK rules against the SDK heads
Silthus ef2c2e9
fix(migrate-email): give Elixir email its own instance when the app u…
Silthus fbd1e83
fix(migrate-email): never pass nil for Elixir's host or token
Silthus 78d56ce
fix(migrate-email): fall back past a nil :posthog host in Elixir
Silthus bb711c5
fix(migrate-email): list the error names once and state reply-to per SDK
Silthus 5398fd9
fix(migrate-email): give email its own client behind a reverse proxy
Silthus 6924d48
test(migrate-email): pin keeping the secret key off the proxied client
Silthus 2ebcce0
feat(migrate-email): bring Resend templates into the code
Silthus 5d29690
feat(migrate-email): map turned-off open and click tracking to track_…
Silthus ec3783e
feat(migrate-email): map only turned-off open tracking to track_opens…
Silthus 4ce6c2d
docs(migrate-email): record engagement events only when engagement ca…
Silthus dc66635
feat(migrate-email): map turned-off open tracking to the tracking option
Silthus a90c30a
fix(migrate-email): use SDK tracking names and skip tracking on templ…
Silthus 07c4c06
feat(migrate-email): map a provider's sensitive or no-track setting t…
Silthus 553a223
fix(migrate-email): mark every migrated code send sensitive
Silthus 0192a3d
fix(migrate-email): keep an app's PostHog key, and a Resend HTTP call…
Silthus d2e2848
Merge #451 at 0192a3d (keep an app's PostHog key, and an HTTP call's …
Silthus 5c996de
fix(migrate-email): keep email off a disabled client, and pass numeri…
Silthus 20036d6
Merge #451 at 5c996de (no email on a disabled client, numeric IDs as …
Silthus dddd616
fix(migrate-email): keep undeadlined HTTP sites on Resend and keep im…
Silthus 8234d71
fix(migrate-email): record the send's own sender, replace markers in …
Silthus e9953c0
fix(migrate-email): map Go's other Resend error checks and keep Outlo…
Silthus ecd0366
fix(migrate-email): render variables in Go's Outlook blocks and scope…
Silthus 7e5a468
fix(migrate-email): keep encoded URL values as they are in Go templates
Silthus e22fa6c
Merge branch 'main' into feat/migrate-email-resend
Silthus 7afab6e
Merge branch 'feat/migrate-email-resend-cutover' into feat/migrate-em…
Silthus ae88e6e
Merge branch 'feat/migrate-email-resend' into feat/migrate-email-rese…
Silthus 6b41f33
feat(migrate-email): move the shared step changes from the SendGrid l…
Silthus a366b71
fix(migrate-email): list Resend webhook handlers, keep ignored argume…
Silthus f279e43
fix(migrate-email): keep provider content inert in code literals, and…
Silthus 487262b
fix(skills): close the migrate-email preparation gaps the QA swarm found
Silthus 00b9aa3
fix(skills): tighten the migrate-email key check and template rules
Silthus bde5bb6
Merge branch 'feat/migrate-email-resend' into feat/migrate-email-rese…
Silthus 708f7f1
fix(migrate-email): keep each site's own HTTP deadline
Silthus 56158d1
fix(migrate-email): keep marketing sends on the provider
Silthus 04e7c84
fix(migrate-email): read the provider's report notes without the impo…
Silthus 7c388d1
Merge branch 'feat/migrate-email-resend' into feat/migrate-email-rese…
Silthus 0186ee2
fix(migrate-email): answer the round 1 review of the rewrite and veri…
Silthus 30f3873
fix(migrate-email): match baseline typecheck errors without their line
Silthus dc18f5d
fix(migrate-email): count each baseline typecheck error
Silthus c33bf45
Merge branch 'feat/migrate-email-resend-cutover' into feat/migrate-em…
Silthus a2994e9
fix(migrate-email): keep a named recipient on Resend
Silthus bde40bc
Merge remote-tracking branch 'origin/feat/migrate-email-resend' into …
Silthus e4221d8
Merge remote-tracking branch 'origin/feat/migrate-email-resend-cutove…
Silthus 82d6ebf
fix(migrate-email): settle deadlines, attribute quoting, and suppress…
Silthus 497d017
fix(migrate-email): keep a site on Resend when it needs a suppressed …
Silthus 69edcdd
fix(migrate-email): keep a Resend SDK send with an abortable signal o…
Silthus 22df812
Merge remote-tracking branch 'origin/feat/migrate-email-resend-cutove…
Silthus e36fd64
fix(migrate-email): own email clients, long deadlines, clicks and tem…
Silthus 08c9d15
test(migrate-email): drop the tests that match the skill's own wording
Silthus bb14da9
fix(migrate-email): blank .NET host, long .NET deadlines, shared temp…
Silthus eeeb620
fix(migrate-email): keep a Go site whose template fills CSS from a value
Silthus 64bb2a2
fix(migrate-email): count brought-in templates as code content, stop …
Silthus 8ead8e1
fix(migrate-email): keep enable_local_evaluation off the Python async…
Silthus 0158aef
fix(migrate-email): keep sites that branch on one kind of network fai…
Silthus f6978e7
fix(migrate-email): keep separate connect limits, require ext-curl fo…
Silthus ad23a92
fix(migrate-email): keep a Go request's transport limits
Silthus 7ccc0ee
fix(migrate-email): keep a Python whole-request limit on the provider
Silthus eef1481
fix(migrate-email): settle untracked clicks, timeout kinds, and the m…
Silthus efb8451
fix(migrate-email): read Faraday's timeout by its adapter
Silthus f658354
fix(migrate-email): keep a site whose handler needs an event PostHog …
Silthus a66e15b
fix(migrate-email): upgrade mocked send tests to the HTTP boundary
Silthus 18ab351
fix(migrate-email): fake fetch instead of keeping a send mock
Silthus ced460c
Merge commit '18ab3510a0b5cb457fab6a6b3d6079d8078bbc2d' into HEAD
Silthus e14c1fc
fix(migrate-email): keep a Ruby site with a partial Net::HTTP timeout
Silthus a943460
fix(migrate-email): note a must-be-sensitive template in its plan row
Silthus 45c5716
fix(migrate-email): keep network failures off Resend's 503 branch
Silthus d51979c
fix(migrate-email): allow a loopback app host in Go and .NET tests
Silthus 17c6ca1
feat(migrate-email): ask before adding an open pixel to untracked email
Silthus cff58f5
fix(migrate-email): route a network failure the way Resend's code did
Silthus 96e10a2
Merge commit 'cff58f516b33b2fe5eb3c0a5d2704f874f7c3d85' into HEAD
Silthus 6f7abcb
fix(migrate-email): test with a standard-library server, never a mock…
Silthus 8776c81
fix(migrate-email): ask about a test dependency only where one is needed
Silthus 63c3dfe
fix(migrate-email): ask before adding any test tool, in every language
Silthus bad56da
Merge branch 'feat/migrate-email-all-sdks' into feat/migrate-email-tr…
Silthus c6f7e9a
fix(migrate-email): move untracked-open sites with opens off, no ask
Silthus 21e1d27
feat(migrate-email): re-import the suppression list weekly while site…
Silthus a65bb90
fix(migrate-email): check the project before a suppression re-import
Silthus b28e13b
fix(migrate-email): write the re-import's project check out in Step 5
Silthus b2dfe53
fix(migrate-email): confirm the production project before a re-import
Silthus 731b092
fix(migrate-email): read the project token with project-get
Silthus 8929f93
fix(migrate-email): switch the MCP back after a re-import
Silthus e5735c8
fix(migrate-email): name the production project in a by-hand re-import
Silthus 8b9757e
fix(migrate-email): let a re-import without the tool say so
Silthus 349a407
fix(migrate-email): let a re-import say why it got no list
Silthus 2df1f26
fix(migrate-email): read the project token with project-get
Silthus 090ac92
Merge #451 (feat/migrate-email-resend-cutover) into feat/migrate-emai…
Silthus d8dd2d4
fix(migrate-email): ask for re-imports only when the provider keeps a…
Silthus 94d44d3
fix(migrate-email): record a provider with no list before the tool check
Silthus 952dc2b
fix(migrate-email): name the engagement switch and say why code sends…
Silthus 8c4d1b2
Merge feat/migrate-email-all-sdks into feat/migrate-email-track-opens…
Silthus 322370a
fix(migrate-email): name the project's engagement setting and the cli…
Silthus cf0cca5
fix(migrate-email): keep a click-handler template site with opens off…
Silthus 51a6543
fix(migrate-email): keep an open-handler site with unknown tracking o…
Silthus 2b8d0d6
fix(migrate-email): end a re-import early when the provider keeps no …
Silthus 5e0607f
fix(migrate-email): keep sites a Resend webhook handler acts on, and …
Silthus eeed7cb
fix(migrate-email): check every error in a rewritten line against its…
Silthus 5f5debd
fix(migrate-email): check for a provider without a suppression list b…
Silthus cb26a5f
Merge #451 (feat/migrate-email-resend-cutover) into feat/migrate-emai…
Silthus 77b680b
fix(migrate-email): give Step 8 one rule for which typecheck errors a…
Silthus e7a7f3f
Merge #451 (feat/migrate-email-resend-cutover) into feat/migrate-emai…
Silthus 1d85155
fix(migrate-email): tie the kept Resend error names to posthog-node, …
Silthus 013a98e
Merge #450 (feat/migrate-email-resend) into feat/migrate-email-resend…
Silthus 19b1b90
fix(migrate-email): mark secret emails sensitive, check template keys…
Silthus fdea2d3
fix(migrate-email): send sensitive only with rendered content, and on…
Silthus 2fe8430
fix(migrate-email): check the app's Node version and count removed er…
Silthus 6c45e23
Merge remote-tracking branch 'origin/feat/migrate-email-resend-cutove…
Silthus 4087e6c
fix(migrate-email): carry the key, sensitive and Node checks; count r…
Silthus 808f61d
fix(migrate-email): name each SDK's sensitive flag; list the moved keys
Silthus b6eb5b0
Merge feat/migrate-email-all-sdks into feat/migrate-email-track-opens…
Silthus fd58f93
fix(migrate-email): move the template keys to after cutover; edge reason
Silthus 7dcc992
fix(migrate-email): fold #472's secret-only sensitive rule into every…
Silthus b46e4bc
Merge feat/migrate-email-all-sdks into feat/migrate-email-track-opens…
Silthus f1ba031
fix(migrate-email): scope the runtime check to where each site runs
Silthus a0b01bc
fix(migrate-email): check every server that shares the SDK's manifest
Silthus 8f51a57
fix(migrate-email): keep every site on a manifest an unsupported serv…
Silthus 6b0083e
fix(migrate-email): count workspace and root lockfile installs in the…
Silthus ef71e1f
fix(migrate-email): keep a site whose HTTP client retries a request w…
Silthus 6fdfdf7
fix(migrate-email): count only a retry setup that covers the POST
Silthus 6d4801f
fix(migrate-email): name the retry setups as examples, not a full list
Silthus caff403
fix(migrate-email): read the retry setup's options before counting it
Silthus 7aad014
fix(migrate-email): count a requests adapter whose max_retries is a n…
Silthus a090b5b
chore: merge main after #450 landed
Silthus 66dc2b2
Merge branch 'feat/migrate-email-resend-cutover' into feat/migrate-em…
Silthus 6d3d8b0
fix(migrate-email): keep a site that reads Resend's response headers
Silthus 610e703
fix(migrate-email): name each SDK's retry delay in its rewrite file
Silthus d186900
fix(migrate-email): keep a send that turns Resend's plain-text part off
Silthus 088f35b
fix(migrate-email): cover react and run-time empty text, word the tem…
Silthus 3b204b7
fix(migrate-email): check the text-part rule in Step 3, count Go's em…
Silthus f3bb668
fix(migrate-email): ask whether a copied Resend template turns its pl…
Silthus 355df95
fix(migrate-email): offer the full-access key for the plain-text ques…
Silthus 74040e5
fix(migrate-email): note every template's plain text, offer the key o…
Silthus b99cea5
fix(migrate-email): sync suppression calls on the reasons PostHog stores
Silthus 9eb4180
fix(migrate-email): report suppression-list calls instead of syncing …
Silthus 1bcc53c
fix(migrate-email): say only hard bounces block a moved send
Silthus de31adb
Merge feat/migrate-email-all-sdks into feat/migrate-email-track-opens…
Silthus daf563e
fix(migrate-email): give the add item a check the app can make
Silthus d00e808
fix(migrate-email): ask in Step 3 which sites rely on a suppression add
Silthus b9d6110
Merge feat/migrate-email-all-sdks into feat/migrate-email-track-opens…
Silthus 2fe5090
fix(migrate-email): ask about hand-added suppressions too
Silthus b006c9b
fix(migrate-email): keep the sites when nobody can say who relies on …
Silthus cd9e38a
fix(migrate-email): ask about the suppression list before the templat…
Silthus 4db6763
fix(migrate-email): list the suppression note in the plan file rules
Silthus 4bffa25
Merge feat/migrate-email-all-sdks into feat/migrate-email-track-opens…
Silthus 0a6ae00
fix(migrate-email): keep Rust sites on runtimes other than Tokio
Silthus f98eb3b
fix(migrate-email): require Tokio's timers for the Rust async client
Silthus 418cc5a
chore: merge main after #451 landed
Silthus 37c0020
Merge feat/migrate-email-all-sdks (#472 final head) into feat/migrate…
Silthus 2a15cac
Merge main into feat/migrate-email-track-opens-and-clicks
Silthus 7f3e6b8
Merge main into feat/migrate-email-track-opens-and-clicks
Silthus ad76d77
fix(migrate-email): answer panel round 3 on tracking text
Silthus c54a7db
fix(migrate-email): act on the shared-template opens note in Step 9
Silthus bb9d947
fix(migrate-email): skip an unconfirmed opens-off template in Step 8'…
Silthus 0f39f57
Merge main into feat/migrate-email-track-opens-and-clicks
Silthus 4d6e759
fix(migrate-email): keep an opens-off site on its provider when a tra…
Silthus 61fdf91
Merge main into feat/migrate-email-track-opens-and-clicks
Silthus d40f3fa
docs(migrate-email): ask Resend click tracking with opens, tighten tr…
Silthus 71e6fe2
docs(migrate-email): move opens-off sites into code, never to a PostH…
Silthus c6a9d89
docs(migrate-email): check opens before asking for a PostHog template
Silthus 5b0b757
docs(migrate-email): pick the code form for opens-off sites before te…
Silthus f4680f1
Revert "docs(migrate-email): pick the code form for opens-off sites b…
Silthus bc4bec7
docs(migrate-email): keep tracked-sensitive sites off PostHog templates
Silthus b5c3854
docs(migrate-email): turn clicks on only for emails with links safe t…
Silthus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.