Repository navigation
Conversation
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a wizard branch:
Add Results will be posted here when complete. |
A send with its own content and legacy substitutions stayed on SendGrid only because SendGrid put the values in. The code now does the same replace before the send, under the escaping rule of template-to-code.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eat/migrate-email-postmark
…eat/migrate-email-mailgun
…at/migrate-email-loops
…/migrate-email-smtp
A Postmark template send now moves by bringing the template, inside its
layout, into the code and rendering TemplateModel there. A template made
in PostHog is used only when the person asks for one.
Moves now that stayed before: raw {{{x}}} and {{& x}} values, sections
on any value that is never a list, tested with Mustachio's truth test,
inverted sections used as fallbacks, ../ to any outer scope, and
template sends with opens or links untracked. The email carries the
CSS that InlineCss inlined.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A Mailgun template site now moves by bringing the version's HTML into the code, rendered with its Handlebars semantics, with the version's From, Subject, and Reply-To headers where the site sets none. A template made in PostHog is used only when the person asks for one. What moves that stayed before: t:text (the code writes the text part), triple braces, if/unless on non-boolean values, each with else, @index, @FIRST, @last, ../, with that can be missing or has an else, tracking fields next to a template, and a send to one address with recipient-variables, whose %recipient.<name>% values the code now puts into the subject and content itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every Loops send renders an email stored at Loops, so no Loops site could move unless the person rebuilt the email as a template in PostHog. Each site now moves by bringing its Loops email into the code. - The Content API's LMX, its theme, and its components become email-safe HTML, tag by tag; a preview send's source covers the dashboard way, MJML emails, and what LMX leaves out, such as social icon images. - Data variables, fallbacks, every conditional section operator, and array blocks render in the code, with Loops' text truth test written out. - Subject, preview text, Name, From, Reply, and language come from the email's settings; a data variable in them is rendered. - Values the code builds as HTML, Nodemailer sends through smtp.loops.so, and the email settings with variables now move. CC, BCC, contact and event properties, number or boolean operators, and MJML unsubscribe links still keep a site. - The Liquid conversion stays, for a template the person asks for. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-email-mailgun # Conflicts: # scripts/lib/tests/migrate-email-skill.test.js
…email-loops # Conflicts: # scripts/lib/tests/migrate-email-skill.test.js
A send of a template stored at Resend now moves by bringing the email into the code: its HTML and text become a file next to the send, the code renders the variables, and the site sends the code form. A template made in PostHog, sent by its ID, is used only when the person asks for one. - template-to-code.md, from the provider stack (#459's 4b15d2e), as is. - Steps 3, 7 and 9 and description.md: the same change as 4b15d2e, ported onto this base's text. - Resend: a "Templates" part with the in-code table. Resend never escapes a value, so the shared escaping rule applies. A fallback covers a missing value only, since Resend inserts "" as it is. A value the site passes for from, reply-to or subject wins over the template's, as Resend does. The Liquid conversion moves under "Templates made in PostHog". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pture is on Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…of turning engagement capture off captureEngagement only decides whether engagement events land on the recipient's person. PostHog still adds its open pixel and never rewrites a code send's links, so provider tracking never maps to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…of turning engagement capture off captureEngagement only decides whether engagement events land on the recipient's person. PostHog still adds its open pixel and never rewrites a code send's links, so provider tracking never maps to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…f turning engagement capture off captureEngagement only decides whether engagement events land on the recipient's person. PostHog still adds its open pixel and never rewrites a code send's links, so provider tracking never maps to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… is on captureEngagement only decides whether engagement events land on the recipient's person. PostHog still adds its open pixel and never rewrites a code send's links, so provider tracking never maps to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…urning engagement capture off captureEngagement only decides whether engagement events land on the recipient's person. PostHog still adds its open pixel and never rewrites a code send's links, so provider tracking never maps to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…and never add engagement capture in the rewrite Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Step 3's list question Follow #472's shared steps: each entry on the provider's list maps to a PostHog reason (bounce, complaint, manual), and Step 3's question about sites that rely on the list covers only sites whose host's provider keeps one, naming that provider in the reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Step 5 now finds the calls that change the provider's list in mapping.md. SMTP sends never change it, so the section sorts calls to the host provider's own API by what its reference says, and treats an unclear one as a removal so the report names it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
PostHog Review · Standard · reviewed 70cdd37: 1 Should fix.
This is review round 10 on this pull request. When findings keep coming back in the same code, the approach is usually the problem. Before the next fix, check whether a different design would remove the whole class of findings.
…SMTP MailKit raises MessageSent each time a message is sent, as its docs say; the moved PostHog send would skip the handler, such as one that marks queued mail sent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…on SMTP A subclass of SmtpClient that overrides OnMessageSent runs code after each send without a client.MessageSent line, so the row now names it too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…erride on SMTP An override of any SmtpClient member can change what the client does during the send, such as a DSN request, and the moved send would skip it. Keeping every such subclass replaces a list of hooks that the API reference can't fully back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
PostHog Review · Standard · reviewed 2e9deba: 1 Should fix.
This is review round 11 on this pull request. When findings keep coming back in the same code, the approach is usually the problem. Before the next fix, check whether a different design would remove the whole class of findings.
A catcher such as SMTP_HOST=localhost in .env.development used to get only a report note, so development sends went through PostHog to real recipients once its key was set. The moved code now keeps the SMTP send in those environments by the app's own environment setting, and a site in an app with no such setting stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An environment name can disagree with the host, such as staging with NODE_ENV=production and a Mailpit host, which sent staging mail through PostHog to real recipients. The moved code now keeps the SMTP send when the host it reads is a local catcher, as sdk-reference.md lists them, and the stay reason for apps with no environment setting is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Branching on the host after the code's fallback, such as SMTP_HOST ?? 'localhost', kept production on SMTP once the person removed the variable, and a list of catcher hosts was never complete. The branch now compares the variable's own value with the catcher host the env file sets, an unset variable goes to PostHog, and the plan row names both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…he repo sets The branch now compares the variable's own value with every catcher host the repo's env or compose files set, adds the variable to the development env file when only the code's fallback names the catcher, and keeps those lines out of the SMTP variables the person removes after cutover. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The catcher values now come from every place outside production that Step 6 lists, CI workflows and test setup included. A fallback-only catcher's line goes into each committed env file the app loads outside production, and the plan row asks each developer and CI job to set it when no such file is committed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…each Adding a catcher line to a committed .env that production also loads would route production into the catcher once its override is removed. A catcher named only by the code's fallback, or set in a file production loads, now keeps the site. The other catcher hosts come from a search for the host variable itself, not Step 6's key search. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…roduction env sets it A test or CI run that left the variable unset reached the catcher through the code's fallback, and the moved branch sent it through PostHog. Such a site now stays unless every environment outside production that the search finds sets the variable itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No repository search can prove every environment outside production sets the variable, and an empty value still takes a || fallback. Any catcher in the code's fallback now keeps the site, with its own reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…on runs A fallback inside a branch the code picks only outside production belongs to that environment branch, which the row already keeps, so such a site moves its production path instead of staying. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…th's site This reverts 8587c1c. Moving the production path of a site whose non-production branch falls back to a catcher left staging on the provider whenever that branch read a real host, and broke it once the person removed the variable. Keeping the whole site is the safe side: it only leaves a site on SMTP that could have moved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
PostHog Review · Standard · reviewed a4d4130: 2 Should fix.
This is review round 12 on this pull request. When findings keep coming back in the same code, the approach is usually the problem. Before the next fix, check whether a different design would remove the whole class of findings.
…ent or a body encoding A worker that pulls from a queue on the pool's idle event stops draining once its sends leave the pool. Nodemailer's docs have described the message's base64 and hex encoding both as how the text and html strings are encoded and as their transfer encoding, so a site setting either stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Any listener of the pool's idle event keeps the site, not only `on`, and every message encoding other than UTF-8 or quoted-printable keeps it, since the docs leave open whether the strings need decoding. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Under the reading where `encoding` names how the strings are encoded, quoted-printable changes the body as much as base64 does, so only UTF-8 lets the site move. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
PostHog Review · Standard · reviewed 94b2a0d: 2 Should fix.
This is review round 13 on this pull request. When findings keep coming back in the same code, the approach is usually the problem. Before the next fix, check whether a different design would remove the whole class of findings.
…rectory An explicit empty `text` next to `html` sent no plain-text part, which a PostHog send can't do, as the Resend mapping already says. A System.Net.Mail client set to a pickup directory hands the message to another program, and the moved send would deliver it instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No SMTP client makes a text part from the HTML, so `text: ''` and a left-out `text` send the same message. Both move, with the plan-row note that PostHog adds a text part. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
PostHog Review · Standard · reviewed da9c846: 1 Should fix.
This is review round 14 on this pull request. When findings keep coming back in the same code, the approach is usually the problem. Before the next fix, check whether a different design would remove the whole class of findings.
A suppressed send the code goes on from answers no data, so a later log of the ID would throw into the failure path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
A person who sends over SMTP and asks to move those sends to PostHog gets no help:
migrate-emailcovers Resend and, with the provider PRs stacked beside this one, SendGrid, Postmark, Mailgun and Loops. Each of those keeps its own SMTP sends with "PostHog has no SMTP relay".With this PR,
migrate-email-smtpmoves sends through an SMTP client, such as Nodemailer,smtplibor PHPMailer, to PostHog's email send in each language where PostHog has an SDK with an email send, andwizard migrate smtpruns it. Resend's run now points its SMTP sends here.Important
The core
migrate-emailskill, #472, has landed, and this PR now targetsmain;1b3e7fbmerges main into it. Each provider PR adds its own provider and lands in any order. The lists they all touch,config.yaml,AGENTS.mdand the skill test, conflict in one line each as they land.It adds one provider folder, one config variant, one
AGENTS.mdrow and the provider in the bundle test, and points Resend's SMTP row here. The shared steps it uses come from #472.It waits for the PostHog SDK releases with the code-form email send. Nothing merges until code sends are live and usable for customers: Michael's rule for #451 and every PR stacked on it.
Impact
Sends that arrive with
migratedFrom: 'smtp'show whether people use this skill to move off SMTP. Read it 14 days after the Wizard runsmigrateas a family.Merge risk
Caution
🔴 Merge risk: high · two-way door until the next context-mill release ships the skill; one-way once agents run it, because a migration's changes persist in each app's code and PostHog account · no switch-off: a revert only stops new runs
Tier: critical (b: high grade at merge)
wizard migrate smtp; there is no flag to turn it off.main(8cd7381) shows the build changes only the newmigrate-email-smtpbundle, Resend's SMTP row, and their manifest entries.Rollout
migratedFrom: 'smtp'and theirvalidation_errorandnetwork_errorshare in the 14 days after the Wizard ships it. No alert covers a single customer's migrated sends: missing.Summary
references/smtp/holds the three files each variant has:sdk-reference.md: the SMTP clients in Node.js (Nodemailer), Python (smtplib,aiosmtplib), Ruby (mail,net-smtp), PHP (PHPMailer, Symfony Mailer), Go (net/smtp, gomail, go-mail), .NET (MailKit,System.Net.Mail), Elixir (gen_smtp) and Rust (lettre), with each client's errors, the framework mailers, and the two Node.js renderers that run inside the send. A host table names the provider behind each host, and the host or a Nodemailerservicename sets that provider's region.smtp.loops.socarries a Loops template send as JSON, so its sites stay with a reason that nameswizard migrate loops, orwizard skill migrate-email-loopson a Wizard whosemigratetakes no provider. Nodemailer's non-SMTP transports,smtp-serverandmailparserare listed as not SMTP.mapping.md:list),icalEvent,priority,sender,dsn, AMP and other alternatives, a message the code writes by hand (raw,net/smtp,Net::SMTP), several recipients, a message with noTo, a Rubymailinterceptor, observer, or adelivery_handlerthe app sets on the message (whether a framework assigned it is read in the installed framework), a message with no subject or no body, which PostHog refuses, aSystem.Net.Mailpickup directory (a .NET pickup directory), framework mailers, and a language without a PostHog SDK that sends email. Sites withcc,bcc, envelope-only recipients or attachments stay too, because no PostHog SDK takes them yet. Adateof the send time and amessageIdnothing reads move without it. EachreplyToentry is written as a bare address string first, a name-less address object as its address and a comma-separated string as a list, and areplyTopassed in as a parameter is read at its callers.gen_smtp'ssend/2andsend/3, which answer a process id before the send ends, stay;send_blockingmoves. .NET follows the enclosing method, asrewrite-dotnet.mddoes: a send in a method that isn'tasyncstays assynchronous .NET sendunless the person agrees to make it async, asked before Step 4 sets up a sender, except a method that returns the send'sTaskwith no result, which moves; a site that returns the SMTP send's own result stays asreturns the SMTP send's resultonly when a caller reads a field "Code around the send" doesn't convert or relies on its type, such as aTask<string>whose callers use the string,asyncor not; otherwise it returns what callers read in the shape they read it, such as{ messageId: data?.id }, and a caller's check that section converts, such as ofinfo.rejected, changes at the caller;System.Net.Mail'sSendAsyncwith aSendCompletedhandler stays. A Ruby message withperform_deliveriesoff keeps that skip under the same condition. Nodemailer'sdisableFileAccesswith a body from apathkeeps the site, and so do sends through a Nodemailerpoolthat setsrateLimit, awaited or not, and sends started at once through any pool, a pool whoseidleevent or capacity the code reads (an SMTP pool's idle event), and a Nodemailer messageencodingother than UTF-8 (a Nodemailer body encoding), a timer around the send stays around the PostHog send, as the core's rewrite files say,smtplib'stimeoutis a deadline those sites keep, since Python's SDK limits each network wait too, the Rubymailgem's open and read timeouts move only when the installednet-smtpandnet-protocolshow open, read and write at one number, oneaiosmtplib.SMTPclient shared by tasks that send at once keeps the site asconcurrent sends through one SMTP connection, while every other timeout the code sets on the SMTP client keeps the site as a deadline the PostHog SDK can't keep, as Step 7 says (the mapping's "HTTP" part says which is which), a Symfony MailerMessageEventlistener or message bus, a PHPMaileraction_function, a MailKitMessageSenthandler, and a MailKitSmtpClientsubclass that overrides any of its members (MailKit SmtpClient subclass). A moved Go send takescontext.WithoutCancelof the context in scope, inside anyselectwith a timer that stays around it, since no Go SMTP client let a context stop a message once connected, and a go-mail site whose context was already done keeps the dial's failure path.captureEngagement: PostHog adds its open pixel to every email and counts no clicks. Whether a site's emails had an open pixel goes to the core's one ask for every provider, Step 3's "Opens the provider didn't track": a host with no tracking provider behind it, such as the company's own mail server, and open tracking off or never set up at a provider behind the host (such as Amazon SES with neither a configuration set that records opens nor the account's engagement tracking left on for the sends) mean no pixel, so the person is asked once whether PostHog may add one, andopen tracking offkeeps the sites when not; a host nobody can answer for keeps its sites asopen tracking not checked.account.mdsays where each provider behind the host sets open tracking. Opens tracked moves, with a plan-row note when the host tracked clicks.validation_erroronly when it takes every permanent refusal of the sender, the recipient and the message, with a5xxcheck, and nothing else. A branch on one kind of refusal, such as a refused recipient, would widen to everyvalidation_error, and a branch without a5xxcheck also took temporary4xxrefusals, sincesmtplib's andaiosmtplib's refusal classes, Nodemailer'sEENVELOPEandEMESSAGE, and .NET's refusal exceptions carry any reply code: both keep the site, like a branch on a failed login or a temporary refusal, and a branch on one kind of network failure, such as a connection error, stays ascatches one kind of network failure, as Step 7 says, in the site or in a caller its error reaches. A site that reads Nodemailer'sinfobeyondmessageIdstays. A check that skips the send when the SMTP settings are missing checks the PostHog secret key instead. A local catcher the code picks by environment keeps its branch, and one set by config alone, an env or compose file, gets a branch on the variable's own value, before any fallback the code adds: the SMTP send stays when it equals a catcher host set for that variable outside production, found by searching the repository for the variable (env, example env, compose, CI and test setup files), and PostHog takes the rest, an unset variable included. A catcher in the code's fallback, such asSMTP_HOST ?? 'localhost', keeps the site asa local catcher in the code's fallback, and one set in a file production also loads keeps it asa local catcher production could reach. The plan row names the variable and each catcher value, whose lines stay after cutover.name,codeandstatusCode, neverresponseCode. A Pythonexcept smtplib.SMTPExceptionmoves only when a refused and a lost connection ran the same code before;aiosmtplib, whose refusals are notOSErrors, gets its own rule, and anexcept ConnectionErroraround it, which a read timeout passed, keeps the site. At everyaiosmtplibsite that can use TLS, the agent reads the installed client for whether a TLS failure escapesSMTPException; when it does, it follows thesmtplibrule. Ruby'sNet::SMTPgroup rescue and MailKit'sSmtpCommandExceptionhandlenetwork_errorfirst: they raise it again, or, when the first later handler of the sametrythat takes a network failure is a catch-all, such asrescue StandardErrororcatch (Exception), run its code, and any other first handler keeps the site; a Ruby message whose ownraise_delivery_errorsis off catches every PostHog error. A caller's catch of the SMTP client's error class adds PostHog's error class.nodemailer-express-handlebarsrenders the view with the plugin's own options first (an emptyextNamefalls back to.handlebars, as the plugin does), and addsexpress-handlebars, a peer dependency, when the app doesn't list it.email-templatesmoves only withsend: trueandpreview: false, merges locals and message insend's order, and addslodashwhen the app lacks it. A header that names a template stored at the provider keeps its site.$workflows_email_*event, except a click. A handler that matches by the Message-ID, the provider's message id or a header keeps its sites, and so does one that acts on clicks, since a code-form send counts none, or on another event PostHog has none for, such as a deferral or an unsubscribe, as in Resend's mapping.mailgem under Action Mailer, and MailKit's IMAP.account.md: the provider behind the host holds the DNS records and any suppression list, read in the region the host names. Its records sit next to PostHog's, and a mailbox provider's MX, SPF and DKIM records stay. No provider key is created. A sending service's dashboard export maps each entry to PostHog'sreason:bounce,complaintormanual. Step 3's question about sites that rely on the provider's list covers only sites whose host's provider keeps one, and names that provider in the reason.mapping.md's "Calls that change the suppression list" sorts calls to the host provider's own API into adds and removes for Step 5, and treats an unclear one as a removal. Mailbox providers and a server the person runs keep no list, so the plan line for such a host tells the report to ask for no weekly or final re-import for the sites that stay on it, and a re-import run stops, without asking for an export, when no host keeps a list. Soft bounces and unsubscribes are left out, with the reason why.Outside the folder, Resend's SMTP row now reads "Always here", and names
wizard migrate smtp, orwizard skill migrate-email-smtpon a Wizard whosemigratetakes no provider yet. SendGrid's, Postmark's and Mailgun's SMTP rows get the same line once this PR and theirs have both landed: the one that lands second changes it.Evidence
8ead8e1, then convergence: the merge (4d20258) was clean.a548b41follows the core's shared rules: the mapping's "HTTP" part names what counts as a site's own deadline and Step 7 says what to do with it, replacing this folder's own client recipe; tracking and clicks point to Step 7, a site whose clicks feed a handler stays, a suppressed send without a message id keeps a site that returns or stores the id (in Step 3's table since6545921), duplicatedfromquoting and idempotency text is gone, andaccount.mdwrites no full-access key line and reports the unsubscribe count under "For the report".8ead8e1againsta548b41: 287 bundles at the base, 288 at the head. Only the newmigrate-email-smtpbundle, Resend's SMTP row, and the manifest and skill-menu entries change; the SMTP bundle's shared step and rewrite files are byte-identical to the core's, and every other bundle is byte-identical.7ccc0ee, then reconcile: the merge (6006e68) was clean.1b4b634follows the core's two new rules: a timeout the code sets on the SMTP client, which limits connecting and each command apart, keeps the site asthe PostHog SDK can't keep the request's deadline, where it had moved with a plan-row note, and a branch on one kind of network failure keeps the site ascatches one kind of network failure, the core's reason, in place of this folder's own reasons. Only SMTP specifics stay: which client timeouts and catches fall under each rule.f658354, then reconcile with the second: the merge (6ea9ef5) was clean, straight fromd06e0f0.8a7fd1cfollows the core's timeout kinds: Python's and Ruby's SDKs limit each network wait, sosmtplib'stimeoutand themailgem's equal open and read timeouts are kept as the site's deadline instead of keeping the site; a timer around the call,asyncio.wait_forandTimeout.timeoutincluded, stays around the PostHog send; a client's default is no deadline, as Step 7 says. The core's click rule for templates made in PostHog doesn't apply, since every moved SMTP site sends in the code form, and nothing here contradicts its UUID message id.8a7fd1c, the one read for the read 17 fix and both reconciles: correctness found thataiosmtplib'stimeoutlimits each whole SMTP reply, not each network read (checked in its source), so the Python SDK can't keep it; fresh eyes found that a handler acting on an event PostHog has none for, which Resend's mapping keeps, still moved here, and a leftover Ruby timeout item. Fixed in84ed7c0:aiosmtplib'stimeoutkeeps the site, such handlers keep their sites asits <event> events feed a webhook handler, and the item is gone.17c6ca1, then reconcile: the merge (4d234bb) was clean.f75659dfollows Michael's decision of one core ask for untracked opens: this folder's own ask for a host with no tracking provider and its stay rule for tracking off at a provider behind the host become pointers to Step 3's "Opens the provider didn't track", with its reasonsopen tracking offandopen tracking not checked, andaccount.mdsays where each provider behind the host sets open tracking. The webhook rule already keeps a site whose handler acts on an event PostHog has none for; the folder has no own sensitive-template note and no text on mocked tests.f75659d: correctness found nothing. Fresh eyes found that the moved host question asked only about opens though the plan-row click note needs clicks, and that an Amazon SES configuration set also tracks opens as the sending identity's default. Fixed inddc6b8f. Its third finding, that the core's new section-pointer test builds only Resend's bundle, is a core test outside this lane's files, reported as a follow-up for the core.ddc6b8f: correctness found nothing. Fresh eyes found that Amazon SES's account-wide Virtual Deliverability Manager engagement tracking adds the open pixel with no configuration set, and that "tracking off" should say open tracking. Fixed ina621fc6.a621fc6: correctness found nothing. Fresh eyes found that a configuration set can turn the account's engagement tracking off. Fixed inff3152b.ff3152b: correctness found nothing; fresh eyes found one nit, that the SES clause should name the engagement tracking it limits. Fixed in3779c9d.090ac92, then reconcile: the merge (ac5e3da) was clean. The folder reads no project token and has no text on mocking the PostHog send. The core's section-pointer test now runs for every provider, so it checks this folder's "Step N says under" pointers, the follow-up from the final read atf75659d, and passes. The core's weekly re-import (Step 5's "Re-import only" and the report) needed one SMTP rule, found by the reads below: a host whose provider keeps no list has nothing to re-import.ac5e3da: correctness found nothing. Fresh eyes found that the report would ask for a weekly re-import of a host that keeps no list. Fixed in5737a5a.5737a5a: correctness found nothing. Fresh eyes found that Step 9 reads only the plan, so the plan line has to carry the no-re-import decision, and that a re-import run reached the no-list exit only after its project question. Fixed inbe9dba7, with this description.be9dba7: correctness found nothing. Fresh eyes found that a re-import run opensaccount.mdonly at Step 5's step 2, after the project question, so the exit placed before step 1 never ran there, and that it didn't switch a changed project back. Fixed in39ea11c: the exit runs where step 2 reads it and switches back as step 1 says. Reading the provider's notes before step 1 is a follow-up for the core.39ea11c: correctness found nothing. Fresh eyes found that with the import tool missing, "Re-import only" never opensaccount.md, so the no-list exit doesn't run. Step 5's order is the core's, so this is a follow-up for the core, listed under Gaps.39ea11c: quality found that a Nodemailer pool'srateLimitalso holds sends the code awaits one by one, so a pool rule for concurrent sends alone would drop that throttle. Fixed inb7cdb55: a pool that setsrateLimitkeeps the site asrate limit on an SMTP pool. Risk asked for the no-list re-import path in the callout, added as an uncovered row.b7cdb55: correctness found nothing. Fresh eyes found that a pool site with both a rate limit and concurrent sends named only the concurrency reason, and that the Summary and Gaps didn't name the rate-limit rule. Fixed inee13330, with this description: the rate-limit check comes first and names its own reason.ee13330: correctness and fresh eyes found nothing.e7a7f3f, then reconcile: the merge (ea37ae6) was clean. The core's "Re-import only" now reads the provider's notes first and stops when the provider keeps no list at all (5f5debd), which fixes the no-list path of the final read atbe9dba7.00f94admoves this folder's exit to that check: the provider keeps none at all only when no host's provider keeps a list.00f94ad: correctness found nothing; fresh eyes found that the callout still named the old shadow-diff base. Fixed in this description.00f94ad: one P2, that a RubyMail::Messagewith adelivery_handlersends throughhandler.deliver_mail(message) { ... }, checked against themailgem's source, a read around Fleet's guard corrected ine82bfcc. Fixed ind55927b: such a site stays; the thread is resolved.d55927b(frome7a7f3f, the whole PR, after read 32 was given the core head and an empty diff): correctness found that an SMTP message without a subject or a body would move, though PostHog's code send refuses both (message_templates.pysend serializer: "needs a subject", "needshtml,textor both"); fresh eyes found that the empty-list tick inaccount.mdapplied to an app whose other host keeps a list, and that the description didn't named55927b. Fixed in0cc0ca4, with this description.0cc0ca4(fromd55927b): correctness found nothing; fresh eyes found that the new rows judged the message a renderer site passes, sonodemailer-express-handlebarsandemail-templatessites would stay, and that a subject or body built at run time had no rule. Fixed inee41b56: both rows judge what the send ends up with after its render, and a run-time value is read at its callers.ee41b56(from0cc0ca4): correctness found nothing; fresh eyes found that a body the app renders in its own code was sent to the site's callers. Fixed in1e58d82: such a body is judged by reading its renderer.1e58d82(fromee41b56): correctness found that a fixed template whose loop renders nothing could still move; fresh eyes found that a pass-through renderer such asmarked(body)skipped its callers and that thesubjectrow still sent a built subject to the callers. Fixed in0fff458: both rows read a value through the code that builds it, read only the inputs that can make it empty at the callers, and keep the site when it can be empty.0fff458(from1e58d82): correctness found nothing; fresh eyes found that two stay examples named a template feature, not an empty result. Fixed in91e31ec: a site stays only when the whole body can be empty. Its question on an emptyhtmlnext totextis checked against PostHog's send serializer, which refuses only when both are empty.91e31ec(from0fff458): correctness found nothing; fresh eyes found two template examples that still named a shape, not a result. Fixed ina657e74: the site stays when some path through the code gives an empty body, and a body that renders text on every path moves.a657e74(from91e31ec): correctness found nothing; fresh eyes found that the path test read one field as the body, and that "Templates" still moved app-rendered content without the body row. Fixed in0eae397:htmlandtextmust both be empty on the same path, and "Templates" points at the row.0eae397(froma657e74): both lenses found nothing.0eae397: two P2s, fixed inba3d7e7, threads resolved: the Rubymailgem's equal open and read timeouts moved thoughnet-smtpsets no write timeout from them, and oneaiosmtplib.SMTPclient shared by concurrent tasks sent one message after another, so such sites now stay asconcurrent sends through one SMTP connection. Both were checked in source read around Fleet's guard, corrected ine82bfcc.ba3d7e7(from0eae397): both lenses found that the mapping's "HTTP" part still moved equal Ruby timeouts; fresh eyes also found this description's Calls bullet out of date. Fixed in53926aeand here.53926ae(fromba3d7e7): correctness found nothing; fresh eyes found one nit, that "HTTP" now grouped Ruby's SDK with the ones that limit the whole request. Fixed inf16033f.f16033f(from53926ae): correctness found nothing; fresh eyes found that Rubymailtimeouts both at 60 matchnet-smtp's write timeout, the one number the Ruby SDK keeps. Fixed inb1cb775: that case moves.b1cb775(fromf16033f): both lenses found nothing.b1cb775, its third and last round: one P2, that a TLS failure such asssl.SSLCertVerificationErrormay escapeaiosmtplib.SMTPException, soexcept EmailErrorwould catch what the old catch let through. aiosmtplib's API reference lists no TLS error in any Raises section and doesn't say whether one is wrapped, soe82bfccmakes it an installed-client read: a site with TLS reads the installedaiosmtplib, and stays ascatches one kind of network failurewhen such a failure escapesSMTPExceptionor the client doesn't settle it.e82bfcc: Fleet's Git allowlist blocks the GitHub orgscole(aiosmtplib),ruby(net-smtp,net-protocol) andmikel(themailgem). Earlier reads of their source on this PR went around that guard:gh apicalls through a loop over repo names, so the guard never saw the org, and a curl of themailgem. The copies are deleted, and nothing more was read from those orgs. Corrected claims: thedelivery_handlerstay now cites themail2.9.1Mail::Messagedocs on rubydoc.info, and its Action Mailer exception, which no docs page states, became a read of the installed framework; the Rubymailtimeout rule, which the Ruby docs hosts couldn't confirm (404 and 521), became a read of the installednet-smtpandnet-protocolfor the write timeout; the sharedaiosmtplib.SMTPstay now cites aiosmtplib's "Parallel Execution" docs instead of its lock;sdk-reference.mdandmapping.mdsaySMTPExceptionis the base of every class aiosmtplib's API reference lists, instead of every failure.e82bfcc(fromb1cb775): correctness found nothing; fresh eyes found that a Rubymailtimeout the code leaves unset wasn't read, that aiosmtplib's default STARTTLS wasn't counted as TLS, and that this description didn't name the new checks. Fixed inb437891and here.b437891(frome82bfcc): both lenses found that a client withstart_tls=Falsethat callsstarttls()itself skipped the TLS check. Fixed inb7deb08: everyaiosmtplibsite reads the installed client.b7deb08(fromb437891): correctness found nothing; fresh eyes found that a client with no TLS at all now read the installed client for a TLS failure it can't have. Fixed in27dcd87: the exclusion is back, narrowed to a site that keeps TLS off.27dcd87(fromb7deb08): correctness found nothing; fresh eyes found that aconnect()oraiosmtplib.send()call could turn STARTTLS back on past the constructor'sstart_tls=False, and that this description's Errors bullet still said every site. Fixed in0389ee9, with this description: the exclusion holds only when the client and everyconnect()oraiosmtplib.send()call keep TLS off and the code never callsstarttls().0389ee9(from27dcd87): correctness found nothing; fresh eyes found one nit, that a bareconnect()keeping the client'sstart_tls=False, or a site that only callsaiosmtplib.send(), didn't meet the wording. Fixed in788dc38: the exclusion asks how each connection runs.788dc38(from0389ee9): both lenses found nothing.788dc38(the extra run on the new head): one P2, that the Ruby and MailKit bullets raisednetwork_errorpast a later handler of the sametrythat took the connection failure before. Fixed indaa3986, as Step 7 says for a later handler, thread answered and resolved.daa3986(from788dc38): correctness found nothing; fresh eyes found that a later handler that took only some network failures, such ascatch (IOException)orrescue Net::OpenTimeout, would get all of them, and that this description's Errors bullet still said the catches raise first. Fixed in92234c0, with this description: only one later handler that took every network failure runs fornetwork_error; otherwise the site stays ascatches one kind of network failure.92234c0(fromdaa3986): correctness found nothing; fresh eyes found that a later handler of the named failures let a failed TLS handshake pass, and that several later handlers with the same code had no rule. Fixed in94aeca1.94aeca1(from92234c0): correctness found nothing; fresh eyes found that any list of failure kinds misses one, such as a DNS failure or a connect timeout, and that this description's Errors bullet was out of date. Fixed indf7d219, with this description: a later handler runs fornetwork_erroronly when it is the language's catch-all, and one that takes some network failures by class keeps the site.df7d219(from94aeca1): correctness found nothing; fresh eyes found that a by-class handler before a catch-all matched both rules, and that a parent class such asSystemCallErrororSystemException, or a filtered catch, fit neither. Fixed in4f92605: the first later handler that takes a network failure, by its class or a parent class, decides; only a catch-all with no filter runs fornetwork_error.4f92605(fromdf7d219): correctness found nothing; fresh eyes found that a Ruby group rescue that also listsTimeout::ErrororIOErrortook those failures itself, and that a filteredcatchthat can't match a network failure counted as one. Fixed infd6b57f: such a group rescue keeps the site, and a filteredcatchcounts only when its filter can be true for a network failure.fd6b57f(from4f92605): both lenses found that awhenfilter that logs and returns false still runs for a network failure, so throwingnetwork_errorpast it skips that code; fresh eyes also found that a MailKit catch ofSmtpCommandExceptionwith only some network classes had no rule. Fixed ine456706: such a filtered catch keeps the site unless it only tests the type and no network failure passes it, and so does such a partial list, as in Ruby.e456706(fromfd6b57f): correctness found nothing; fresh eyes found that a type-only filtered catch before a catch-all became the first handler, so its skip never applied, and that a list naming every known network class read as one that moves. Fixed ina05dd04: the search skips a type-only filtered catch that lets no network failure through, and an old catch that listsSmtpCommandExceptionwith any network failure class keeps the site.a05dd04(frome456706): correctness found nothing; fresh eyes found that a latercatch (Exception ex) when (ex is not OperationCanceledException), which ran for every network failure, kept the site. Fixed in120ff07: such a type-only filter that lets every network failure through counts as a catch-all.120ff07(froma05dd04): both lenses found nothing.120ff07: two P2s, fixed ine97f590and answered: a .NET method that returns the send'sTaskstayed as a synchronous send thoughrewrite-dotnet.mdmoves it, and a name-lessreplyToaddress object or a comma-separatedreplyTostring went to PostHog as it was; each entry is now written as a bare address string first.e97f590(from120ff07): correctness found nothing; fresh eyes found that a method returning aTask<T>with the send's result, such as aTask<string>, would change type for its callers, and that this description's Calls and Fields bullets were out of date. Fixed inc75b3e8, with this description: only aTaskwith no result moves.c75b3e8(frome97f590): correctness found nothing; fresh eyes found that anasyncmethod returning the awaited send's result moved while the same method withoutasyncstayed. Fixed inae049a8: a "Code around the send" row keeps any site that returns the SMTP send's own result to its callers,asyncor not.ae049a8(fromc75b3e8): correctness found nothing; fresh eyes found that the new row kept every helper that returns the send's result, such asreturn transporter.sendMail(opts)orreturn d.DialAndSend(m), which moved before. Fixed in04a49e2: the row follows the callers, and the moved site returns what they read.04a49e2(fromae049a8): correctness found nothing; fresh eyes found that the Calls row still kept aTask<T>result outright, and that the row didn't say to keep the shape callers read, such asmessageId. Fixed in8c4fbcb: the Calls row defers to "Code around the send", which uses the Node.js rule's test and returns what callers read in the shape they read it.8c4fbcb(from04a49e2): correctness found nothing; fresh eyes found that the example{ messageId: data.id }would throw on a suppressed send, which has no data, and that this description's Calls bullet was out of date. Fixed in0c8563f, with this description: the example is{ messageId: data?.id }, with no id on that path.0c8563f(from8c4fbcb): correctness found nothing; fresh eyes found one wording nit on row 86's order, declined as wording only.0c8563f: passes. Every judge line passes: proof, owed, review, risk (high, with the Tier set to critical), and quality (low: the same row-86 wording). CI's requiredbuildruns only on PRs into main, an accepted gap.1b3e7fb): feat(migrate-email): move Resend sends in every PostHog SDK's language #472's head418cc5a, then main8cd7381. The two conflicts,resend/mapping.mdand the shared skill test, were paths where main's blob equals418cc5a's, so this branch's side was kept; the merge adds nothing beyond418cc5a.cee573afollows feat(migrate-email): move Resend sends in every PostHog SDK's language #472's shared steps: suppression entries map to PostHog'sreason, and Step 3's list question is scoped to hosts whose provider keeps a list. This folder'smapping.mdhad no "which entries count" text to drop.cee573a(from0c8563f): correctness found nothing. Fresh eyes found that Step 5 now looks for the calls that change the provider's list inmapping.md, which had none for SMTP, fixed in70cdd37; a core-text finding on Resend's retry delay, rejected here as feat(migrate-email): move Resend sends in every PostHog SDK's language #472's, for the core lane; and a Summary nit, fixed in this description.70cdd37(fromcee573a): correctness found nothing; fresh eyes found one wording nit, that a call clearing a temporary block lands in "After cutover", declined: it adds a report line and changes no outcome.70cdd37: one P2, that a MailKitclient.MessageSent += ...handler runs after each send and the moved send would skip it. Fixed in1629c5d: such a site stays; the thread is answered and resolved.1629c5d(from70cdd37): correctness found nothing; fresh eyes found that aSmtpClientsubclass overridingOnMessageSenthad no+=line to match, fixed ine4a2fef, and that this description didn't name the new row, fixed here.e4a2fef(from1629c5d): correctness found nothing; fresh eyes found that otherSmtpClientoverrides, such as one requesting delivery notifications, still moved. Fixed in2e9deba: any subclass that overrides a member keeps the site asMailKit SmtpClient subclass.2e9deba(frome4a2fef): correctness found nothing; fresh eyes found that this description's Calls bullet and Gaps didn't name the MailKit rows, fixed here.2e9deba: passes: "gate: pass (kinds: live-run, prod-shape, shadow-diff; review: final read 70 by gpt-6.1-sol, claude-opus-5-5; CI: green; judge: pass by gpt-6.1-sol)". Risk high, quality low (a wording nit on the suppressed-send clause).2e9deba: one P2, that a catcher set only in an env file got a report note, so development sends went through PostHog to real recipients. Fixed incb7dd6fwith a branch on the environment name, then in7004c6d,dfd069f,dae7537,594bdde,12f2f94,1629ac7and6f8b4b1with a branch on the variable's own value; the thread is answered and resolved.cb7dd6f(from2e9deba): correctness found nothing; fresh eyes found that an environment name can disagree with the host, such as staging withNODE_ENV=productionand a Mailpit host. Fixed in7004c6d: the branch reads the host. It also found this description silent on the rule, fixed here.7004c6d(fromcb7dd6f): correctness found nothing; fresh eyes found that the host after a fallback such asSMTP_HOST ?? 'localhost'would keep production on SMTP once the person removes the variable, and that the catcher list insdk-reference.mdis only examples. Fixed indfd069f: the branch compares the variable's own value with the catcher host the env file sets.dfd069f(from7004c6d): correctness found nothing; fresh eyes found a catcher named only by the code's fallback, two files with different catcher values, and the person removing the catcher line with the SMTP variables. Fixed indae7537: the branch compares with every catcher the repo's env or compose files set, a fallback-only catcher gets the variable added to the development env file, and the catcher lines stay after cutover.dae7537(fromdfd069f): correctness found nothing; fresh eyes found catcher hosts set only in CI workflows or test setup, and fallback-only catchers where the one added line isn't loaded. Fixed in594bdde: the values come from every place Step 6 searches, and the line goes into each committed env file loaded outside production.594bdde(fromdae7537): both lenses found that adding a catcher line to a committed.envthat production also loads would send production into the catcher once its override is removed (major), and fresh eyes found that Step 6's search looks for the key, not the host. Fixed in12f2f94: such a catcher, and one only the code's fallback names, keeps the site, and the hosts come from a search for the variable itself.12f2f94(from594bdde): correctness found nothing; fresh eyes found a fallback catcher that a dev env file also sets while test or CI leaves it unset, and a stale "added line" in this description. Fixed in1629ac7and here: a fallback catcher keeps the site unless every environment outside production sets the variable.1629ac7(from12f2f94): both lenses found ways a fallback catcher still moved, an explicitly empty value with||and a CI job that never names the variable (major), and fresh eyes found that its reason named production. Fixed in6f8b4b1: any catcher in the code's fallback keeps the site, with its own reasona local catcher in the code's fallback.6f8b4b1(from1629ac7): correctness found nothing; fresh eyes found that a fallback inside a branch the code picks only outside production kept a site whose production path could move.8587c1cnarrowed the stay to a fallback on a path production can run, thena4d4130reverted it.8587c1c(from6f8b4b1): correctness found nothing; fresh eyes found that the narrowing moved a site whose non-production branch reads a real host in staging, which then breaks once the person removes the variable. Reverted ina4d4130: keeping the whole site is the safe side, and it only leaves on SMTP a site that could have moved. The finding of the read at6f8b4b1is declined for that reason.a4d4130: two P2s, fixed and resolved: a queue worker that sends from a Nodemailer pool'sidleevent stops draining once its sends leave the pool, fixed inb07917f(an SMTP pool's idle event); and Nodemailer's messageencoding, which its docs have described both as the encoding of thetextandhtmlstrings and as their transfer encoding, so the site stays (a Nodemailer body encoding).b07917f(froma4d4130): correctness found nothing; fresh eyes found that theidlerule named onlyonand theencodingrule only two values. Both widened in8e60385: any listener of the event, and any value other than UTF-8 or quoted-printable. Its nit thatpendingCount()isn't Nodemailer's is declined: the pooled SMTP docs document it.8e60385(fromb07917f): correctness found nothing; fresh eyes found that'quoted-printable'moved though the row's own argument keeps it. Fixed in94b2a0d: only UTF-8 moves.94b2a0d(from8e60385): correctness found nothing; fresh eyes found one nit, that'UTF-8'in upper case stays though Node reads it as UTF-8. Declined: Nodemailer's docs spell it in lower case, and the site only stays on SMTP, the safe side.94b2a0d: passes: "gate: pass (kinds: live-run, prod-shape, shadow-diff; review: final read 83 by gpt-6.1-sol, claude-opus-5-5; CI: green; judge: pass by gpt-6.1-sol)". Risk high, two-way at merge; quality low (the same upper-case nit).94b2a0d: two P2s, fixed and resolved: aSystem.Net.Mailpickup directory hands the message to another program, so the site stays (be1fbd2); and an emptytextnext tohtml, first kept as the Resend mapping does, then moved like a left-outtextinda9c846, since no SMTP client makes a text part from the HTML, with a reply on the thread.be1fbd2(from94b2a0d): correctness found nothing; fresh eyes found thattext: ''sends the same message as a left-outtext, fixed inda9c846, and that a pickup directory set only for development keeps production on SMTP, declined: the stay is the safe side, and a run-time branch would keep the SMTP client after cutover.da9c846(frombe1fbd2): correctness found nothing; fresh eyes found one nit, that PHPMailer'smsgHTML()and Symfony'sBodyRendererdo make a text part from the HTML. Declined as wording: no site is misclassified, and the plan-row note that PostHog adds a text part holds there too.da9c846: passes: "gate: pass (kinds: live-run, prod-shape, shadow-diff; review: final read 85 by gpt-6.1-sol, claude-opus-5-5; CI: green; judge: pass by gpt-6.1-sol)". Risk high, two-way at merge; quality low (the samemsgHTML()nit).da9c846: one P2, fixed infb720aaand resolved:info.messageIdbecamedata.id, which throws after a suppressed send the code goes on from; it now becomesdata?.id.fb720aa(fromda9c846): both lenses found nothing.fb720aa: passes: "gate: pass (kinds: live-run, prod-shape, shadow-diff; review: final read 86 by gpt-6.1-sol, claude-opus-5-5; CI: green; judge: pass by gpt-6.1-sol)". Risk high, two-way at merge; quality low (themsgHTML()and upper-caseUTF-8nits, both declined above).fb720aa: 0 must fix, 0 should fix, 0 consider.main(8cd7381) againstfb720aa: 288 bundles at the base, 289 at the head. Only the newmigrate-email-smtpbundle, Resend's SMTP row, and the manifest and skill-menu entries change; the SMTP bundle's shared step and rewrite files are byte-identical to the core's, and every other bundle is byte-identical.e7a7f3fagainst0c8563f: 287 bundles at the base, 288 at the head. Only the newmigrate-email-smtpbundle, Resend's SMTP row, and the manifest and skill-menu entries change; the SMTP bundle's shared step and rewrite files are byte-identical to the core's, and every other bundle is byte-identical.a548b41(correctness on GPT-6.1 Sol, fresh eyes on Opus 5.5): the convergence had made every SMTP step timeout a whole-send deadline with no retries, and the suppressed-send message-id rule sat only in Rewrite, where Step 3 never reads it. Both came in witha548b41, fixed in6545921: a deadline is only a limit around the whole send, and the message-id rule is in Step 3's table.6545921:System.Net.Mail'sSmtpClient.Timeoutbounds a whole synchronousSend, and go-mail'sWithTimeout(checked in its v0.7.2 source: the dial, then one deadline for the whole message) does too, so both counted as the site's deadline in1d23cbc; a stored Message-ID tests the store and the code that reads it, not the callers, fixed in1d23cbc.1d23cbc: both families showed that neither timeout maps onto a PostHog request either: go-mail bounds the dial and then each message apart, andSendMailAsyncignoresSmtpClient.Timeout, so the site made async loses it anyway.468b5c5settles on one rule: only a limit the code puts around the whole send is a deadline, and every client timeout the code set is noted in the plan row.468b5c5and363e569: correctness found nothing in either. Fresh eyes found that go-mail'sDialAndSendWithContextcontext bounds only the dial (checked in go-mail v0.7.2's source), that the plan-row note about retries belonged only on sites without a deadline, and that the rule didn't say which context the moved go-mail send takes. Fixed in363e569andb3aec86.b3aec86: both families found that the moved go-mail send took the context the dial's context came from, which gave it a deadline or cancellation that had bounded only the dial. Fixed inc78a2c9: it takescontext.WithoutCancelof that context, which keeps its values only, and the plan row notes it.c78a2c9: correctness found that a go-mail context already done failed the dial without sending, whichWithoutCancelalone would lose; fresh eyes found that the rule missedDialAndSendsites with a context in scope and sites with a limit around the whole send, and that this description lacked the two new rules. Fixed in2dd505band here: every moved Go site without a whole-send limit takesWithoutCancelof its context, and a done go-mail context keeps the dial's failure path.2dd505b: correctness found nothing. Fresh eyes found that a Go deadline built from the caller's context took its cancellation, and that the cancellation note belonged only onDialAndSendWithContextsites. Fixed in1b4b634together with the reconcile.1b4b634: fresh eyes found that aPromise.raceor a Goselectwith a timer ends only the caller's wait while the SMTP send runs on, so it is no deadline, and thatSmtpClient.Timeoutbounds the whole synchronousSend. Fixed in4611d78: the race orselectstays around the PostHog send, and a site made async keepsSmtpClient.Timeoutas a cancellation token. Correctness flagged the order of aservice_unavailableand anapplication_errorbranch in Resend's mapping, core text this merge brought in, reported to the core as a follow-up.4611d78: correctness found nothing. Fresh eyes found that a caller'scatch (SmtpException)lost the timeout of a keptSmtpClient.Timeout, that a .NET token passed only to MailKit'sConnectAsynclimits connecting alone, and that this description still named a kept Go deadline. Fixed in55ca62cand here.55ca62c: correctness found nothing. Fresh eyes found that catchingOperationCanceledExceptionfor a keptSmtpClient.Timeoutwidened a caller's catch, that a cancellable token passed only toConnectAsynchad no rule, and that Step 3's table missed the new stay case. Fixed inc5e4958by narrowing: a synchronousSendwithSmtpClient.Timeoutstays, a connect-only token is checked before the send and not passed to it, and Step 3's table names both.c5e4958: correctness found nothing. Fresh eyes found that Step 3's timeout row still read as moving a synchronousSmtpClient.Timeout, that the async question was asked of a site the timeout keeps anyway, and that a pre-send cancellation check would fail a queue worker's sends whose connection was made once. Fixed in6a2a56b.6a2a56b: correctness found that a MailKit reconnect after anIsConnectedcheck failed on a cancelled token only while disconnected, which no PostHog send can follow; fresh eyes found that Step 3's row read as keeping aSendMailAsyncsite whose timeout never applied. Fixed ind06e0f0: that reconnect keeps the site, and the row saysSmtpClient.Timeoutcounts only on a synchronousSend.fb720aa:vitest run scriptspasses 344 tests in 30 files, andnode scripts/build.jsbuilds the marketplace with a clean tree.migrate-email-skill.test.js,smtpin itsPROVIDERSlist): the built SMTP bundle holds its three files and the eight rewrite files and no other provider's folder, and it is amigrate smtpsubcommand in the menu the Wizard reads. Each "Step N says under" pointer in the bundle names a section that step has. The core's other tests run on the shared bundle.63a6536: fresh eyes (Opus 5.5), correctness, risk, design, anti-overengineering, Michael's review perspective and sweep (GPT-6.1 Sol). Design, anti-overengineering and the perspective found nothing. 14 findings fixed ind6cd766, each checked against the package sources (aiosmtplib 5.1.3, nodemailer-express-handlebars 7.0.0, email-templates, CPython'ssmtplib); 2 rejected with reasons in the ledger (a Nodemailer socket timeout, and owed prod-shape and shadow-diff proofs), and 2 partly fixed: the tracking wording, with the rest left to Michael's tracking decision, and the stale evidence, rewritten here, with the live run kept as a gap.d6cd766: correctness, fresh eyes, risk and systems on the fix diff. Four lenses found the sameaiosmtplibgap (anexcept ConnectionErrorthat a read timeout passed); fresh eyes also found that a refusal branch of one kind would widen to everyvalidation_error, and that the .NET rows keyed on the call name. All 7 fixed inaa979b9, including one mistaked6cd766introduced (raise_delivery_errorsread fromdelivery_method, which themailgem ignores).d6cd766: 4 should-fix threads (perform_deliveries,raise_delivery_errors,aiosmtplibtimeouts,disableFileAccess), all fixed inaa979b9and resolved.aa979b9: 4 should-fix threads, all fixed ind649de3and resolved, each checked against the client's source: a refused-recipient check on a one-recipient send never ran, since the client raised instead, so it is dropped, not turned into a branch; a Rubyrescue Net::SMTPSyntaxErroralone takes50xreplies only and keeps the site; sends started at once through a Nodemailerpoolkeep the site, since the pool held them to its connections andrateLimit; and a connection timeout the code set moved only onto a PostHog client that took one, a rule that6545921replaced, as below.d649de3: the timeout rule still let the SDK's retries run past the code's deadline, a mistaked649de3introduced, fixed inc2e3369: such sites move only onto a PostHog client of their own with the same timeout and no retries. Its ask for a fixture run is the live-run gap. The final read atc2e3369found nothing.d649de3, its third and last round: 3 should-fix threads, all fixed in1cc615cand resolved: a Ruby invalid-send branch moves only when it rescuesSMTPFatalErrorandSMTPSyntaxErrortogether, and a Symfony Mailer transport with aMessageEventlistener and a PHPMaileraction_functionkeep the site, since the moved send would skip them. The final read at1cc615casked again for fixture runs, here of the inventory step alone, which could run before the SDKs release. Rejected for this PR: context-mill has no harness that runs an agent on a fixture, and building one is a core change, listed as a follow-up for the core skill.b3aec86: 1 should-fix thread, fixed inc78a2c9and resolved: a standalone Symfony Mailer built with a message bus,new Mailer($transport, $bus), can queue the send for a worker, so the site stays asqueued through a message bus.aa979b9(GPT-6.1 Sol, the fix diff sinced6cd766): one finding, that no fixture run exercises the new rules. Rejected as a recorded gap: it is the live run below.0d981d6. They predate the tracking rule ofcf8f7b9and15972d0and this round's rules, so they show the shape of a run, not this head's outcome. A prod-shape survey of real codebases' SMTP send shapes, saved atd651c6e, added the skip check on missing SMTP settings, areplyToread at its callers, a helper that takes several recipients while every caller passes one, a PHPMailer site, and a sender on a mailbox provider's domain.build.ymlruns only on PRs intomain; this PR's base wasfeat/migrate-email-all-sdksuntil feat(migrate-email): move Resend sends in every PostHog SDK's language #472 merged. It targetsmainnow, so the requiredbuildruns on this head. The lane gate above ran locally on this head.perform_deliveriesandraise_delivery_errorsoff,gen_smtpsend/2, a .NET send outside anasyncmethod andSendAsyncwithSendCompleted,aiosmtplibcatches, refusal branches of one kind or without a5xxcheck, a caller's catch of the client's class,disableFileAccesswith apathbody, concurrent sends through apooland a pool'srateLimit, a pool'sidleevent, a Nodemailer bodyencoding, a .NET pickup directory, a sharedaiosmtplib.SMTPclient, Rubymailtimeouts, the installed-client reads this PR asks for (a framework-assigneddelivery_handler,net-smtp's write timeout, anaiosmtplibTLS failure outsideSMTPException), a limit on the whole send and a timeout on one step of the connection, a RubySMTPFatalErrororSMTPSyntaxErrorrescue alone, a SymfonyMessageEventlistener or message bus, PHPMailer'saction_function, a MailKitMessageSenthandler orSmtpClientsubclass, a local catcher set only in an env file, the context a moved Go send takes,email-templates, and the tracking question for each kind of host.Decisions
captureEngagement. Emails that had no open pixel, from a host with no tracking provider or with open tracking off at the provider behind it, follow the core's one ask for every provider (Step 3, "Opens the provider didn't track"): they move only when the person agrees that PostHog may add its pixel; unknown stays; opens tracked moves788dc38and120ff07nodemailer-express-handlebarsandemail-templatessites move when the moved code renders the same content first, as the package did.email-templateswith defaultsendorpreviewstaysvalidation_erroronly when it takes every permanent refusal, with a5xxcheck: the refusal classes carry temporary refusals too, andvalidation_errorcovers more than one kind of refusal. A failed login, a connection error, a temporary refusal, or a refusal of one kind keeps the site. Replaced mapping every refusal-class branch tovalidation_errorexcept SMTPExceptionaiosmtplibgets its own rule, since its refusals are notOSErrorsmailinterceptor or observer, adelivery_handlerthe app's code sets on aMail::Message(only a handler the app's own code assigns; whether a framework such as Action Mailer assigned it is read in the installed framework), andgen_smtp's asynchronoussend/2, keep the site, since the moved send would skip them or block the callerrewrite-dotnet.mddoes: a send not awaited in anasyncmethod stays assynchronous .NET sendunless the person agrees, so Step 4 sets up no sender for a site that staysaiosmtplibexcept ConnectionError, which a read timeout passed, and a Pythonexcept SMTPExceptionthat ran other code than itsOSErrorpath keep the site ascatches one kind of network failure, the core's Step 7 reasonpool, any send through a pool that setsrateLimit, and concurrent tasks sharing oneaiosmtplib.SMTPclient, which sends one message after another, as aiosmtplib's docs say under "Parallel Execution", keep the site: the move would drop the queue and rate. A .NET token the send call takes is the site's own deadline, which it keeps as the core's Step 7 says; a timer around the call, such asasyncio.wait_for, Ruby'sTimeout.timeout, aPromise.raceor a Goselect, stays around the PostHog send, as the core's rewrite files say.smtplib'stimeoutlimits each network wait, the kind of limit Python's SDK keeps, so such a site keeps it on a client of its own. The Rubymailgem sets only open and read timeouts, so the agent reads the installednet-smtpandnet-protocolfor the write timeout: the site keeps one number for all three on its own client, as the core'srewrite-ruby.mdkeeps, and otherwise, or when the installed client doesn't settle it, stays. Every other timeout the code sets on the SMTP client limits connecting and each command apart, which no PostHog timeout matches, so the site stays asthe PostHog SDK can't keep the request's deadline, as the core's Step 7 says of a limit on connecting alone; that covers go-mail'sWithTimeout, a deadline on its dial context, a .NET token with a timeout that onlyConnectAsynctakes, andSmtpClient.Timeouton a synchronousSend, whose cancellation a catch ofSmtpExceptioncouldn't tell apart. A client's default timeout is no deadline: the site sends through the default email client, and its plan row notes the SDK's timeout and retriesMessageEventlistener or message bus, a PHPMaileraction_function, and a MailKitMessageSenthandler orSmtpClientsubclass with an override keep the site: the moved send would skip them or go out at once instead of through the queuestatusCode, neverresponseCode, since SMTP code reads that as an SMTP replyinfomessageIdbecomes PostHog'sdata.id; any other field keeps the sitewizard migrate smtporwizard skill migrate-email-smtp;smtp.loops.sosends go to the Loops skill🤖 Agent context
Agent: Claude Code, Claude Opus 5.5 (
claude-opus-5-5, high), as the migration-skills slice of Silthus/posthog#461. Reviews on GPT-6.1 Sol (high), the fresh-eyes lens on Opus 5.5; fixes on Opus 5.5 (high). Earlier dry runs on Claude Sonnet 5.5.Involvement: qa-swarm, earlier review history of 2 panel rounds and 16 final reads before the 2026-11-12 forward merge; on 2026-11-12, round 1 with seven lenses (fresh eyes, correctness, risk, design, anti-overengineering, Michael's review perspective, sweep), round 2 with four (correctness, fresh eyes, risk, systems), and final reads after each fix, 5 through 65 across six merges of #472, then 66 through 86 after the merge of main; fifteen ReviewHog rounds, on
d6cd766,aa979b9,d649de3,b3aec86,00f94ad,0eae397,b1cb775,788dc38,120ff07,70cdd37,2e9deba,a4d4130,94b2a0d,da9c846andfb720aa. Proof captured: 17 dry runs and a prod-shape survey at earlier heads; the live run at this head is a gap.🤖 Generated with Claude Code